[{"id":17635,"web_url":"https://patchwork.libcamera.org/comment/17635/","msgid":"<8b339fcf-fe49-ae51-db22-831dfa1bfef0@ideasonboard.com>","date":"2021-06-18T20:06:50","subject":"Re: [libcamera-devel] [PATCH v2 2/3] libcamera: ipa: raspberrypi:\n\tDemote warnings about lack of AWB results","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi David\n\nOn 18/06/2021 17:18, David Plowman wrote:\n> Warnings about the lack of AWB status results are demoted to being\n> just \"Debug\". With monochrome sensors becoming more common this would\n> otherwise overwhelm the console output, and in practice nothing is\n> really lost as it is normally very evident if AWB is failing to run.\n> \n> Signed-off-by: David Plowman \n> ---\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> index 55e80ac7..2c95f287 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> @@ -481,7 +481,7 @@ void Agc::fetchAwbStatus(Metadata *image_metadata)\n> \tawb_.gain_g = 1.0;\n> \tawb_.gain_b = 1.0;\n> \tif (image_metadata->Get(\"awb.status\", awb_) != 0)\n> -\t\tLOG(RPiAgc, Warning) << \"Agc: no AWB status found\";\n> +\t\tLOG(RPiAgc, Debug) << \"Agc: no AWB status found\";\n\nWould it make any more sense to disable the warning instead if the\nsensor is mono?\n\n> }\n> \n> static double compute_initial_Y(bcm2835_isp_stats *stats, AwbStatus const &awb,\n> diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> index b0d24aa2..c58ef7d0 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> @@ -267,7 +267,7 @@ double get_ct(Metadata *metadata, double default_ct)\n> \tAwbStatus awb_status;\n> \tawb_status.temperature_K = default_ct; // in case nothing found\n> \tif (metadata->Get(\"awb.status\", awb_status) != 0)\n> -\t\tLOG(RPiAlsc, Warning) << \"no AWB results found, using \"\n> +\t\tLOG(RPiAlsc, Debug) << \"no AWB results found, using \"\n> \t\t\t\t << awb_status.temperature_K;\n\nSame comment as above, but also - when the indentation on a multiline\nstatement changes, the other lines should be adjusted as well (in this\ncase to maintain the vertical alignment of the <<'s.\n\nIf it doesn't make sense (or isn't feasible) to disable on Mono sensors,\nthen with the alignment fixed:\n\nReviewed-by: Kieran Bingham \n\n> \telse\n> \t\tLOG(RPiAlsc, Debug) << \"AWB results found, using \"\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 57372C3218\n\tfor ;\n\tFri, 18 Jun 2021 20:06:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7ED1F68943;\n\tFri, 18 Jun 2021 22:06:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9719D6050D\n\tfor ;\n\tFri, 18 Jun 2021 22:06:53 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 198F93F0;\n\tFri, 18 Jun 2021 22:06:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fH/hbzHw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624046813;\n\tbh=9oZKf1XYBhr4C0u1IzyYmF2h5qCOllE/Z6Xao+Y5egk=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=fH/hbzHwlF++E3Rt0qwJWQjplU7eHaA/WgVvu0SlScXnewXsDi6p7gOGLzYI2MysA\n\tZnXwVx85nxXAMdLRchQ/fwlj2JrcyE9dLK6LZebFA143PvEC8+qdzZXUZHcAmNs6n7\n\tLX55CbusoNVL8NVI8G1OLU3Qn8EUDOxQxLU5Ta78=","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210618161807.24242-1-david.plowman@raspberrypi.com>\n\t<20210618161807.24242-3-david.plowman@raspberrypi.com>","From":"Kieran Bingham ","Organization":"Ideas on Board","Message-ID":"<8b339fcf-fe49-ae51-db22-831dfa1bfef0@ideasonboard.com>","Date":"Fri, 18 Jun 2021 21:06:50 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.8.1","MIME-Version":"1.0","In-Reply-To":"<20210618161807.24242-3-david.plowman@raspberrypi.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] libcamera: ipa: raspberrypi:\n\tDemote warnings about lack of AWB results","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]