{"id":12651,"url":"https://patchwork.libcamera.org/api/patches/12651/?format=json","web_url":"https://patchwork.libcamera.org/patch/12651/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210618161807.24242-3-david.plowman@raspberrypi.com>","date":"2021-06-18T16:18:06","name":"[libcamera-devel,v2,2/3] libcamera: ipa: raspberrypi: Demote warnings about lack of AWB results","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5344ad06dfd5709e3193fa70d0b0904c87f238fe","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12651/mbox/","series":[{"id":2152,"url":"https://patchwork.libcamera.org/api/series/2152/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2152","date":"2021-06-18T16:18:04","name":"Support monochrome raw sensors","version":2,"mbox":"https://patchwork.libcamera.org/series/2152/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12651/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12651/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9EBABC3219\n\tfor ;\n\tFri, 18 Jun 2021 16:18:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E457A6894C;\n\tFri, 18 Jun 2021 18:18:15 +0200 (CEST)","from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com\n\t[IPv6:2a00:1450:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66ACE68941\n\tfor ;\n\tFri, 18 Jun 2021 18:18:14 +0200 (CEST)","by mail-wr1-x42b.google.com with SMTP id j2so807882wrs.12\n\tfor ;\n\tFri, 18 Jun 2021 09:18:14 -0700 (PDT)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tz5sm8908492wrp.92.2021.06.18.09.18.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 18 Jun 2021 09:18:13 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Sxx32nof\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=QVArBmBrjrypsLGJa1m5fvTRw+qpuCABtPTcmqBl12A=;\n\tb=Sxx32nofExNzHAO/sOzvl3bvOqeoNalp3aMai1nJpn36snprfVDz677miptn6xarRL\n\twH9yciEPzRXR8/+aQFVe4deV9gPlj9wS7kod8sYQ0G9ppeW5mpf+x/Pr9WjRcI3i1GA5\n\tCy+BJ8VxXdLsLlM/icxmg7eKmccHGVrpETn/OcQ+M4igKu9rVj6izRMJVLIDH66Txasc\n\tdaItJ31x28vKeOlbRHjiFEdT8Xb0IXqGmwW2LlF74CO2bTs3i10T5zGMOEIN5V2PMJZR\n\tN1JWct4Kk9cktWZFvg8at+qURYybPFPkDE7Fl0b226wR540Z7C87gCBcOhSjjYc/3YRI\n\tOhZA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=QVArBmBrjrypsLGJa1m5fvTRw+qpuCABtPTcmqBl12A=;\n\tb=cTkSdNlC7ETC1OKeXeeqM1hZUDr+K5NNWEFRMVFj9cjHxiJXt8tDO5C9m1CtNLicdS\n\tp86pr2j8Xq/GtBZ4K0eBteZ7055zOwsEqo+JlXTDK1s+U6lYL8jhtv1X7ft9sfhsgRgl\n\txhSipktgCjX40npTyL2CstHqfn+78X9fLzT24o2xMjKMhoxK086TFxWDQYDV/1WPuF1N\n\tlnf6JetiwVSqg30v75Vb6sz0utJYb+X09C3nc6oMl+aB2KPsbg5W1EHwcsqQFJQmsrzw\n\titJMAxQIgBE7VSX81SmQ9+IqPOjpcY9amknAsj0bvtD4ZMaWaPvkqK5Jvmo2lakFII0R\n\tptwg==","X-Gm-Message-State":"AOAM531Smx8KkJYk/Z8iaQQdZznhnd74PcuZLN/kICDK6W54/I4iCl92\n\tJLff7dTu8KB8V8jfuz1Q55yuWNZt8NifNH0N","X-Google-Smtp-Source":"ABdhPJxiB4y9zbs1b0eHKp7BrOBFj8WaSRdX16WMZnTj8INISPAoQHwQxHcldFbeJCeEq/ENQvpdEw==","X-Received":"by 2002:a05:6000:1084:: with SMTP id\n\ty4mr12159565wrw.173.1624033093979; \n\tFri, 18 Jun 2021 09:18:13 -0700 (PDT)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 18 Jun 2021 17:18:06 +0100","Message-Id":"<20210618161807.24242-3-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20210618161807.24242-1-david.plowman@raspberrypi.com>","References":"<20210618161807.24242-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 2/3] libcamera: ipa: raspberrypi:\n\tDemote warnings about lack of AWB results","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Warnings about the lack of AWB status results are demoted to being\njust \"Debug\". With monochrome sensors becoming more common this would\notherwise overwhelm the console output, and in practice nothing is\nreally lost as it is normally very evident if AWB is failing to run.\n\nSigned-off-by: David Plowman \n---\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\nindex 55e80ac7..2c95f287 100644\n--- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n@@ -481,7 +481,7 @@ void Agc::fetchAwbStatus(Metadata *image_metadata)\n \tawb_.gain_g = 1.0;\n \tawb_.gain_b = 1.0;\n \tif (image_metadata->Get(\"awb.status\", awb_) != 0)\n-\t\tLOG(RPiAgc, Warning) << \"Agc: no AWB status found\";\n+\t\tLOG(RPiAgc, Debug) << \"Agc: no AWB status found\";\n }\n \n static double compute_initial_Y(bcm2835_isp_stats *stats, AwbStatus const &awb,\ndiff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\nindex b0d24aa2..c58ef7d0 100644\n--- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n@@ -267,7 +267,7 @@ double get_ct(Metadata *metadata, double default_ct)\n \tAwbStatus awb_status;\n \tawb_status.temperature_K = default_ct; // in case nothing found\n \tif (metadata->Get(\"awb.status\", awb_status) != 0)\n-\t\tLOG(RPiAlsc, Warning) << \"no AWB results found, using \"\n+\t\tLOG(RPiAlsc, Debug) << \"no AWB results found, using \"\n \t\t\t\t << awb_status.temperature_K;\n \telse\n \t\tLOG(RPiAlsc, Debug) << \"AWB results found, using \"\n","prefixes":["libcamera-devel","v2","2/3"]}