[{"id":17838,"web_url":"https://patchwork.libcamera.org/comment/17838/","msgid":"","date":"2021-06-28T01:56:25","subject":"Re: [libcamera-devel] [RFC PATCH 14/14] FULL: pipeline: ipu3: Set\n\tAwbLock ControlInfo","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Jun 18, 2021 at 07:33:51PM +0900, Paul Elder wrote:\n> Set the AwbLock ControlInfo in IPU3, to satisfy CTS FULL\n> requirements.\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=45\n> Signed-off-by: Paul Elder \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 32d0bc1c..7355edc0 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -50,6 +50,7 @@ static constexpr Size IPU3ViewfinderSize(1280, 720);\n> static const ControlInfoMap::Map IPU3Controls = {\n> \t{ &controls::AeEnable, ControlInfo(false, true) },\n> \t{ &controls::AeLock, ControlInfo(false, true) },\n> +\t{ &controls::AwbLock, ControlInfo(false, true) },\n\nAssuming the discussions on 03/14 conclude it's the way to go, and with\nthe comments on 11/14 addressed,\n\nReviewed-by: Laurent Pinchart \n\n> \t{ &controls::AwbMode, ControlInfo(controls::AwbModeValues) },\n> \t{ &controls::draft::MaxLatency, ControlInfo(0, 0, 0) },\n> \t{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 063FDC321D\n\tfor ;\n\tMon, 28 Jun 2021 01:56:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B6EA6684D5;\n\tMon, 28 Jun 2021 03:56:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 013836028C\n\tfor ;\n\tMon, 28 Jun 2021 03:56:27 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 92DF757E;\n\tMon, 28 Jun 2021 03:56:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bi/IuBpu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624845386;\n\tbh=nofEr7cCvadMy2k1XPwRMavQmmVoNrO7nKgx5HPu2MQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bi/IuBpuwTz4E3DLsq3SvnfDPLlWmfpkBGWDILnf5kQgOuBi2up21rpAbH3kHPXvx\n\t1VlPCgeILJpO8P1rgeDcYwK0FOyRfzkwtjbFT2JlfrOVC9SSHQupe22vmalPm1r0Mh\n\tftFdhl8e/j8zU/vBeIVJ8qNoP1Q1SeDkzRi5HpqA=","Date":"Mon, 28 Jun 2021 04:56:25 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210618103351.1642060-1-paul.elder@ideasonboard.com>\n\t<20210618103351.1642060-15-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210618103351.1642060-15-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 14/14] FULL: pipeline: ipu3: Set\n\tAwbLock ControlInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]