[{"id":17839,"web_url":"https://patchwork.libcamera.org/comment/17839/","msgid":"","date":"2021-06-28T01:58:05","subject":"Re: [libcamera-devel] [RFC PATCH 13/14] FULL: pipeline: ipu3: Set\n\tAwbMode ControlInfo","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Jun 18, 2021 at 07:33:50PM +0900, Paul Elder wrote:\n> Set the AwbMode ControlInfo in IPU3, to satisfy CTS FULL\n> requirements.\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=44\n> Signed-off-by: Paul Elder \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index f315a411..32d0bc1c 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -50,6 +50,7 @@ static constexpr Size IPU3ViewfinderSize(1280, 720);\n> static const ControlInfoMap::Map IPU3Controls = {\n> \t{ &controls::AeEnable, ControlInfo(false, true) },\n> \t{ &controls::AeLock, ControlInfo(false, true) },\n> +\t{ &controls::AwbMode, ControlInfo(controls::AwbModeValues) },\n\nI'm OK with this as a first step, but shouldn't the supported values\nshould come from the IPA module ?\n\n> \t{ &controls::draft::MaxLatency, ControlInfo(0, 0, 0) },\n> \t{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },\n> };","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8416EC321D\n\tfor ;\n\tMon, 28 Jun 2021 01:58:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 46BA1684D5;\n\tMon, 28 Jun 2021 03:58:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F4F36028C\n\tfor ;\n\tMon, 28 Jun 2021 03:58:07 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9834857E;\n\tMon, 28 Jun 2021 03:58:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gROVqdDd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624845486;\n\tbh=REol/e0/GBdhKYRezDA1CPlFJ+zyLL8pANksMH8fYDQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gROVqdDdKvGG3Hwpu6217fGcIf/nA1pnLr94XR1pibenvuOy/T2Sj3nrMZqFaXvoP\n\t315ABc1uoqzHSGTq/oTig0/lfTxiMeccV5XMOuDzgs/16w1RXorcogcBg/ari8knW2\n\tmju22emg/FOde4mvu3c6M75uJYtEpcTW42MOqopc=","Date":"Mon, 28 Jun 2021 04:58:05 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210618103351.1642060-1-paul.elder@ideasonboard.com>\n\t<20210618103351.1642060-14-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210618103351.1642060-14-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 13/14] FULL: pipeline: ipu3: Set\n\tAwbMode ControlInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]