[{"id":17836,"web_url":"https://patchwork.libcamera.org/comment/17836/","msgid":"","date":"2021-06-28T01:54:57","subject":"Re: [libcamera-devel] [RFC PATCH 11/14] FULL: pipeline: ipu3: Set\n\tAeEnable ControlInfo","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nThe subject shouldn't start with \"FULL: \". Same for patch 10/14 and\n12/14 to 14/14.\n\nOn Fri, Jun 18, 2021 at 07:33:48PM +0900, Paul Elder wrote:\n> Set the AeEnable ControlInfo in IPU3, to satisfy CTS FULL\n> requirements.\n\nIt's not just to satisfy the CTS FULL requirements, we want the IPU3 IPA\nimplementations to support enabling and disabling AE. I'd write the\ncommit message based on that. Same comment for the other patches in the\nseries.\n\n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=42\n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 1899f389..a9faa9e3 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -48,6 +48,7 @@ static constexpr unsigned int IMGU_OUTPUT_HEIGHT_MARGIN = 32;\n> static constexpr Size IPU3ViewfinderSize(1280, 720);\n> \n> static const ControlInfoMap::Map IPU3Controls = {\n> +\t{ &controls::AeEnable, ControlInfo(false, true) },\n> \t{ &controls::draft::MaxLatency, ControlInfo(0, 0, 0) },\n> \t{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },\n> };","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 363DCC321A\n\tfor ;\n\tMon, 28 Jun 2021 01:55:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6EC66684D5;\n\tMon, 28 Jun 2021 03:55:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F4ED6028C\n\tfor ;\n\tMon, 28 Jun 2021 03:54:59 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A790A57E;\n\tMon, 28 Jun 2021 03:54:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KEaqPwFP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624845298;\n\tbh=vy7FiNz2lMAjUXW61rHNZB4ppqgYkt9N0BOEsL7u4TE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KEaqPwFPQge0xPweJhtrRIjum8xOd8yksQymzmrHLkQ3Xi444+VvEZowX+pkNr5Ns\n\tLOS/E4uxRh89oaenCLPuQC0rvkPE6rjpHjHTI6bcgOxG8Z4qZBrfYMKYaxI/8WPAs9\n\tB22ltlsqQkiHheGaqpyfTPyNodbrumDxeQl+4QIY=","Date":"Mon, 28 Jun 2021 04:54:57 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210618103351.1642060-1-paul.elder@ideasonboard.com>\n\t<20210618103351.1642060-12-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210618103351.1642060-12-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 11/14] FULL: pipeline: ipu3: Set\n\tAeEnable ControlInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]