[{"id":17833,"web_url":"https://patchwork.libcamera.org/comment/17833/","msgid":"","date":"2021-06-28T01:42:27","subject":"Re: [libcamera-devel] [RFC PATCH 08/14] android: Plumb AwbMode\n\tcontrol","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Jun 18, 2021 at 07:33:45PM +0900, Paul Elder wrote:\n> Plumb the AwbMode control into the HAL for\n> CONTROL_AWB_AVAILABLE_MODES for static metadata.\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=44\n> Signed-off-by: Paul Elder \n> \n> ---\n> TODO: plumb result metadata\n\nSame comment as for 07/14.\n\n> ---\n> src/android/camera_device.cpp | 26 ++++++++++++++++++--------\n> 1 file changed, 18 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 3add5bc6..a8b6fa38 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -985,15 +985,25 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstaticMetadata_->addEntry(ANDROID_CONTROL_AVAILABLE_VIDEO_STABILIZATION_MODES,\n> \t\t\t\t availableStabilizationModes);\n> \n> -\t/*\n> -\t * \\todo Inspect the Camera capabilities to report the available\n> -\t * AWB modes. Default to AUTO as CTS tests require it.\n> -\t */\n> -\tstd::vector availableAwbModes = {\n> -\t\tANDROID_CONTROL_AWB_MODE_AUTO,\n> -\t};\n> +\tstd::vector awbAvailableModes;\n> +\tawbAvailableModes.reserve(2);\n> +\tconst auto &awbModesInfo = controlsInfo.find(&controls::AwbMode);\n> +\tif (awbModesInfo != controlsInfo.end()) {\n> +\t\tfor (const auto &value : awbModesInfo->second.values())\n> +\t\t\tawbAvailableModes.push_back(value.get());\n> +\t} else {\n> +\t\tawbAvailableModes.push_back(ANDROID_CONTROL_AWB_MODE_AUTO);\n> +\t}\n> +\n> +\tif (std::find(awbAvailableModes.begin(),\n> +\t\t awbAvailableModes.end(),\n> +\t\t ANDROID_CONTROL_AWB_MODE_OFF) == awbAvailableModes.end()) {\n> +\t\tfullSupport = false;\n> +\t\t/* \\todo Double check if this is the correct capability */\n> +\t\tcapabilities[ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING] = false;\n\nIt's not explicitly mentioned in the documentation, but the manual\npost-processing capability requires supporting\nandroid.colorCorrection.gains, which is only taken into account when AWB\nis OFF, so this makes sense.\n\nReviewed-by: Laurent Pinchart \n\n> +\t}\n> \tstaticMetadata_->addEntry(ANDROID_CONTROL_AWB_AVAILABLE_MODES,\n> -\t\t\t\t availableAwbModes);\n> +\t\t\t\t awbAvailableModes);\n> \n> \tstd::vector availableMaxRegions = {\n> \t\t0, 0, 0,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4AD2C321A\n\tfor ;\n\tMon, 28 Jun 2021 01:42:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3C00A684D4;\n\tMon, 28 Jun 2021 03:42:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A9A56028C\n\tfor ;\n\tMon, 28 Jun 2021 03:42:29 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B92F157E;\n\tMon, 28 Jun 2021 03:42:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"E0CkV/RS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624844548;\n\tbh=Y72tXQ49IhWHSb5z81q+3PTIF5kf584cOgGv1uU3qKI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=E0CkV/RSybVMQrR3tzU/gkVdWgEQ6IqFqXtahkHzYo1SwZ4d2binQpmFijjRa1h4c\n\tM5rT5KpLNToTmV4zHkMMcT1rGm+t72DltsUetjr8Y3TqK1FppBGxC+3EepSTx0U02b\n\txrI59wu5QBH+N65PLHtclFF1IfnMu9/p2UUn2DbA=","Date":"Mon, 28 Jun 2021 04:42:27 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210618103351.1642060-1-paul.elder@ideasonboard.com>\n\t<20210618103351.1642060-9-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210618103351.1642060-9-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 08/14] android: Plumb AwbMode\n\tcontrol","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]