[{"id":17832,"web_url":"https://patchwork.libcamera.org/comment/17832/","msgid":"","date":"2021-06-28T01:32:47","subject":"Re: [libcamera-devel] [RFC PATCH 07/14] android: Plumb AeLock\n\tcontrol","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Jun 18, 2021 at 07:33:44PM +0900, Paul Elder wrote:\n> Plumb the AeLock control into the HAL for\n> CONTROL_AE_LOCK_AVAILABLE_MODES for static metadata.\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=43\n> Signed-off-by: Paul Elder \n> \n> ---\n> TODO: plumb result metadata\n\nPlease record this in the bug once this patch gets merged (or address\nthe issue in this series :-))\n\n> ---\n> src/android/camera_device.cpp | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 3446cdb6..3add5bc6 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1010,6 +1010,14 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\t\t\t sceneModesOverride);\n> \n> \tuint8_t aeLockAvailable = ANDROID_CONTROL_AE_LOCK_AVAILABLE_FALSE;\n> +\tconst auto &aeLockInfo = controlsInfo.find(&controls::AeLock);\n> +\tif (aeLockInfo != controlsInfo.end()) {\n> +\t\taeLockAvailable = aeLockInfo->second.max().get();\n> +\t}\n\nIt makes little sense for a camera to expose AeLock with only false as a\nsupported value. I'd write this\n\n\tif (controlsInfo.find(&controls::AeLock) != controlsInfo.end())\n\t\taeLockAvailable = ANDROID_CONTROL_AE_LOCK_AVAILABLE_TRUE;\n\nThe AeLock documentation should state that both true and false need to\nbe supported when the control is reported by the camera.\n\nReviewed-by: Laurent Pinchart \n\n> +\tif (!aeLockAvailable) {\n> +\t\tcapabilities[ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BURST_CAPTURE] = false;\n> +\t\tcapabilities[ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR] = false;\n> +\t}\n> \tstaticMetadata_->addEntry(ANDROID_CONTROL_AE_LOCK_AVAILABLE,\n> \t\t\t\t aeLockAvailable);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5E26BC321D\n\tfor ;\n\tMon, 28 Jun 2021 01:32:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B2248684D5;\n\tMon, 28 Jun 2021 03:32:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 427086028C\n\tfor ;\n\tMon, 28 Jun 2021 03:32:49 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A937857E;\n\tMon, 28 Jun 2021 03:32:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"p9KFXJg6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624843968;\n\tbh=XLzVn4sgzq65ZyC0oleeDeADJmY4Y8Z2lMrSuRkp+Ts=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=p9KFXJg6F6StA4RXotyuoXd4wh2o0uHquBxdecNdjUWCSG9qaOxE3Cw615bEREZv7\n\tsLYLfeYWUnWADIKRtEPJk3y7JVNxDfiTsb/+QCPpMDEEWFiG4T5Ta275w+3dc3OpyK\n\tcmneFbQF4GkUNdAMVH1/bv2OBXFHbYNcDfg3q+08=","Date":"Mon, 28 Jun 2021 04:32:47 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210618103351.1642060-1-paul.elder@ideasonboard.com>\n\t<20210618103351.1642060-8-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210618103351.1642060-8-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 07/14] android: Plumb AeLock\n\tcontrol","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]