[{"id":17606,"web_url":"https://patchwork.libcamera.org/comment/17606/","msgid":"<20210617073315.GG1351869@pyrite.rasen.tech>","date":"2021-06-17T07:33:15","subject":"Re: [libcamera-devel] [PATCH] android: Add infrastructure for\n\tdetermining capabilities and hardware level","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi me,\n\nOn Thu, Jun 17, 2021 at 04:22:46PM +0900, Paul Elder wrote:\n> Add the infrastructure for checking and reporting capabilities. Use\n> these capabilities to determine the hardware level as well.\n> \n> Since the raw capability is set to true when support is determined to be\n> available, leave that as default false and set to true, since copying\n> the pattern of the other capabilities would cause redundant code.\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=55\n> Signed-off-by: Paul Elder \n> \n> ---\n> This is my vision of how we would support the various capabilities.\n> Although we don't have anything for FULL yet; I imagine that we would\n> start the flags for manual sensor and manual post processing with true,\n> and then if a required control is unavailable, then we would set the\n> flag to false.\n> \n> I considered declaring an enum in CameraDevice to mirror the android\n> ones, just for shorthand, but it seemed like a lot of code for not much\n> gain. Unless the shorthand would be valuable because these constant\n> names are so long?\n> \n> I think the available keys lists will have to be moved to the head of\n> the function, and then as available controls are discovered add them to\n> that list.\n> ---\n> src/android/camera_device.cpp | 39 ++++++++++++++++++++++++++---------\n> 1 file changed, 29 insertions(+), 10 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 8c71fd06..1e437907 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -13,6 +13,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -840,6 +841,15 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tconst ControlInfoMap &controlsInfo = camera_->controls();\n> \tconst ControlList &properties = camera_->properties();\n> \n> +\tstd::map\n> +\tcapabilities = {\n> +\t\t{ ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE, true },\n> +\t\t/* \\todo Change these two to true when we have checks for them */\n> +\t\t{ ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR, false },\n> +\t\t{ ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING, false },\n> +\t\t{ ANDROID_REQUEST_AVAILABLE_CAPABILITIES_RAW, false },\n> +\t};\n> +\n> \t/* Color correction static metadata. */\n> \t{\n> \t\tstd::vector data;\n> @@ -1298,11 +1308,6 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tuint8_t croppingType = ANDROID_SCALER_CROPPING_TYPE_CENTER_ONLY;\n> \tstaticMetadata_->addEntry(ANDROID_SCALER_CROPPING_TYPE, croppingType);\n> \n> -\t/* Info static metadata. */\n> -\tuint8_t supportedHWLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED;\n> -\tstaticMetadata_->addEntry(ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL,\n> -\t\t\t\t supportedHWLevel);\n> -\n> \t/* Request static metadata. */\n> \tint32_t partialResultCount = 1;\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n> @@ -1323,10 +1328,6 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n> \t\t\t\t maxNumInputStreams);\n> \n> -\tstd::vector availableCapabilities = {\n> -\t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE,\n> -\t};\n> -\n> \t/* Report if camera supports RAW. */\n> \tbool rawStreamAvailable = false;\n> \tstd::unique_ptr cameraConfig =\n> @@ -1338,7 +1339,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW &&\n> \t\t info.bitsPerPixel == 16) {\n> \t\t\trawStreamAvailable = true;\n> -\t\t\tavailableCapabilities.push_back(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_RAW);\n> +\t\t\tcapabilities[ANDROID_REQUEST_AVAILABLE_CAPABILITIES_RAW] = true;\n> \t\t}\n> \t}\n> \n> @@ -1347,9 +1348,27 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS,\n> \t\t\t\t numOutStreams);\n> \n> +\t/* Check capabilities */\n> +\tstd::vector availableCapabilities;\n> +\tfor (auto cap : capabilities) {\n> +\t\tif (cap.second)\n> +\t\t\tavailableCapabilities.push_back(CapabilityTable.at(cap.first));\n> +\t}\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n> \t\t\t\t availableCapabilities);\n> \n> +\tuint8_t supportedHWLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED;\n> +\tif (capabilities[ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR] &&\n> +\t capabilities[ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING])\n> +\t\tsupportedHWLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_FULL;\n\nApparently this is insufficient to conclude FULL support [1]:\n\nA FULL device will support below capabilities:\n\n BURST_CAPTURE capability (android.request.availableCapabilities contains BURST_CAPTURE)\n Per frame control (android.sync.maxLatency == PER_FRAME_CONTROL)\n Manual sensor control (android.request.availableCapabilities contains MANUAL_SENSOR)\n Manual post-processing control (android.request.availableCapabilities contains MANUAL_POST_PROCESSING)\n The required exposure time range defined in android.sensor.info.exposureTimeRange\n The required maxFrameDuration defined in android.sensor.info.maxFrameDuration\n\n\n[1] https://developer.android.com/reference/android/hardware/camera2/CameraMetadata#INFO_SUPPORTED_HARDWARE_LEVEL_FULL\n\nSo I guess we need a flag just to check FULL support :/\n\n\nPaul\n\n> +\tstaticMetadata_->addEntry(ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL,\n> +\t\t\t\t supportedHWLevel);\n> +\n> +\tLOG(HAL, Info)\n> +\t\t<< \"Hardware level: \"\n> +\t\t<< supportedHWLevel == ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_FULL\n> +\t\t ? \"FULL\" : \"LIMITED\";\n> +\n> \tstd::vector availableCharacteristicsKeys = {\n> \t\tANDROID_COLOR_CORRECTION_AVAILABLE_ABERRATION_MODES,\n> \t\tANDROID_CONTROL_AE_AVAILABLE_ANTIBANDING_MODES,\n> -- \n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77B98C3218\n\tfor ;\n\tThu, 17 Jun 2021 07:33:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E29B368946;\n\tThu, 17 Jun 2021 09:33:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9DC1960297\n\tfor ;\n\tThu, 17 Jun 2021 09:33:22 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 90BE9E53\n\tfor ;\n\tThu, 17 Jun 2021 09:33:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Dsy5COWL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623915202;\n\tbh=R0ynEhsfdhCstrql4o70s9jm/QZR6xjFsKJE6NZxSaM=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=Dsy5COWLu6wSLM4BMuOjO+a5STHwjukgHLxhUVn/lh4yP8q1HGF3p5HFw/604/HsP\n\t/xk2xOdF8nCsTUzc7LOdKLBRzLoVeDrl9AnlEMuAoHRweoWbApWvXd9vGdIGYPKVYd\n\tPdATHvvy5xO7BtL6Qz5BmaeHxLizT0zjz5RTqAh4=","Date":"Thu, 17 Jun 2021 16:33:15 +0900","From":"paul.elder@ideasonboard.com","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20210617073315.GG1351869@pyrite.rasen.tech>","References":"<20210617072246.1455382-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210617072246.1455382-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] android: Add infrastructure for\n\tdetermining capabilities and hardware level","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]