[{"id":17596,"web_url":"https://patchwork.libcamera.org/comment/17596/","msgid":"<CAO5uPHP-RMfafEUsJs03KhzCdK+5gFfjs1BZF1thqAno=n_kuQ@mail.gmail.com>","date":"2021-06-17T05:31:11","subject":"Re: [libcamera-devel] [PATCH v3] android: jpeg: get ISO from\n\tSENSOR_SENSITIVITY","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"HI Paul, thank you for the patch.\n\nOn Thu, Jun 17, 2021 at 1:58 PM Paul Elder <paul.elder@ideasonboard.com>\nwrote:\n\n> The data for the exif ISO tag needs to come from SENSOR_SENSITIVITY. Set\n> it.\n>\n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>\n> ---\n> This on its own doesn't fix any CTS tests, but it prevents a test\n> failure later on when we add the proper static metadata for the FULL\n> hardware level.\n> ---\n>  src/android/jpeg/post_processor_jpeg.cpp | 5 ++++-\n>  1 file changed, 4 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/android/jpeg/post_processor_jpeg.cpp\n> b/src/android/jpeg/post_processor_jpeg.cpp\n> index 058ccc99..921ac823 100644\n> --- a/src/android/jpeg/post_processor_jpeg.cpp\n> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n> @@ -119,7 +119,10 @@ int PostProcessorJpeg::process(const FrameBuffer\n> &source,\n>         ret = requestMetadata.getEntry(ANDROID_LENS_APERTURE, &entry);\n>         if (ret)\n>                 exif.setAperture(*entry.data.f);\n> -       exif.setISO(100);\n> +\n> +       ret = resultMetadata->getEntry(ANDROID_SENSOR_SENSITIVITY, &entry);\n> +       exif.setISO(ret ? *entry.data.i32 : 100);\n>\n\nNoob: where does 100 come from?\n\nReviewed-by: Hirokazu Honda <hiroh@chromium.org>\n\n> +\n>         exif.setFlash(Exif::Flash::FlashNotPresent);\n>         exif.setWhiteBalance(Exif::WhiteBalance::Auto);\n>\n> --\n> 2.27.0\n>\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA50DBD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 17 Jun 2021 05:31:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0273068941;\n\tThu, 17 Jun 2021 07:31:25 +0200 (CEST)","from mail-ej1-x636.google.com (mail-ej1-x636.google.com\n\t[IPv6:2a00:1450:4864:20::636])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 76A1460296\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 17 Jun 2021 07:31:23 +0200 (CEST)","by mail-ej1-x636.google.com with SMTP id hv20so1680373ejc.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Jun 2021 22:31:23 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"GTz9uaAK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=QE6rLSQrobTLAHZcLaVdm8RlMZQFNr8kG3MbeRESIIc=;\n\tb=GTz9uaAK8mi5msm9M5Bu3G3wknmMFN8dj/J1kfiYCs4MbywM1LOYpWPP2jb5PNE87E\n\tiNryFQQ0WQxYhvZmfeYD5lQ+aqNz5QYhOgU1aDdZedbSjW5/9kAyzbVoSuRyfebTOQpa\n\tN69lS1Js/Bz+HJzaQYcLOWV+n73Sr5A7xqhWY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=QE6rLSQrobTLAHZcLaVdm8RlMZQFNr8kG3MbeRESIIc=;\n\tb=qZV4R4W6mDtkRt2q/euOcTrm+8tNhnGJysn4wRucM9HeYQUrAIbsiPoiu29yME/Z/f\n\t689nfK8sYCwP/yOHH7T49fqc+7SgmGtBHCKSA2FyqhlPTiwBrT4ts6dyJE61DwOu5rXT\n\tHn0+fnmTXZ+nI9qhjXOj/bMfaMC8lvrWLt0SXoYUmdeMtQqYsnFv7V9BRCT/7R7UwiDi\n\tZDmf1Yij3y+xp0itGtFl/ry6K4PPFMK0l3MaZSVG7RorhMF/Lpt5qTDFWYxJfyYZOHHk\n\tUuWQFw6S5YaMDbeTy4IAgKqiXaOYcmZf8+gRQ+BNdacSTm04FhONp3FkMx/GJjIYzPUT\n\tkmqg==","X-Gm-Message-State":"AOAM533fZUXqGaDsS/0S1b0e+cvdYtcMCRMUstz+q9f8e32M+++yCfcf\n\txZuAtRr4gSRZXOTGwBrmokOz1klFwcheYKmPSs8HOhaQT6mYmA==","X-Google-Smtp-Source":"ABdhPJxUPUrhLMlpYVIXoT9HoMQu+CBQQEZ3m5hO75a2PSPN1fVRWCcyG6X53OsSP45n1DSNI+bKmt2OlDn8XLp9xQE=","X-Received":"by 2002:a17:906:19cc:: with SMTP id\n\th12mr3228821ejd.306.1623907883183; \n\tWed, 16 Jun 2021 22:31:23 -0700 (PDT)","MIME-Version":"1.0","References":"<20210617045758.1432766-1-paul.elder@ideasonboard.com>","In-Reply-To":"<20210617045758.1432766-1-paul.elder@ideasonboard.com>","From":"Hirokazu Honda <hiroh@chromium.org>","Date":"Thu, 17 Jun 2021 14:31:11 +0900","Message-ID":"<CAO5uPHP-RMfafEUsJs03KhzCdK+5gFfjs1BZF1thqAno=n_kuQ@mail.gmail.com>","To":"Paul Elder <paul.elder@ideasonboard.com>","Content-Type":"multipart/alternative; boundary=\"000000000000867e3805c4ef8461\"","Subject":"Re: [libcamera-devel] [PATCH v3] android: jpeg: get ISO from\n\tSENSOR_SENSITIVITY","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":17599,"web_url":"https://patchwork.libcamera.org/comment/17599/","msgid":"<20210617054427.GE1351869@pyrite.rasen.tech>","date":"2021-06-17T05:44:27","subject":"Re: [libcamera-devel] [PATCH v3] android: jpeg: get ISO from\n\tSENSOR_SENSITIVITY","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the review.\n\nOn Thu, Jun 17, 2021 at 02:31:11PM +0900, Hirokazu Honda wrote:\n> HI Paul, thank you for the patch.\n> \n> On Thu, Jun 17, 2021 at 1:58 PM Paul Elder <paul.elder@ideasonboard.com> wrote:\n> \n>     The data for the exif ISO tag needs to come from SENSOR_SENSITIVITY. Set\n>     it.\n> \n>     Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n>     Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n>     ---\n>     This on its own doesn't fix any CTS tests, but it prevents a test\n>     failure later on when we add the proper static metadata for the FULL\n>     hardware level.\n>     ---\n>      src/android/jpeg/post_processor_jpeg.cpp | 5 ++++-\n>      1 file changed, 4 insertions(+), 1 deletion(-)\n> \n>     diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/\n>     post_processor_jpeg.cpp\n>     index 058ccc99..921ac823 100644\n>     --- a/src/android/jpeg/post_processor_jpeg.cpp\n>     +++ b/src/android/jpeg/post_processor_jpeg.cpp\n>     @@ -119,7 +119,10 @@ int PostProcessorJpeg::process(const FrameBuffer &\n>     source,\n>             ret = requestMetadata.getEntry(ANDROID_LENS_APERTURE, &entry);\n>             if (ret)\n>                     exif.setAperture(*entry.data.f);\n>     -       exif.setISO(100);\n>     +\n>     +       ret = resultMetadata->getEntry(ANDROID_SENSOR_SENSITIVITY, &entry);\n>     +       exif.setISO(ret ? *entry.data.i32 : 100);\n> \n> \n> Noob: where does 100 come from?\n\nIt was an arbitrary number that passed CTS LIMITED :D\n\n\nPaul\n\n> \n> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> \n> \n>     +\n>             exif.setFlash(Exif::Flash::FlashNotPresent);\n>             exif.setWhiteBalance(Exif::WhiteBalance::Auto);\n> \n>     --\n>     2.27.0\n> \n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9E90C3218\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 17 Jun 2021 05:44:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7A52268941;\n\tThu, 17 Jun 2021 07:44:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D338260296\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 17 Jun 2021 07:44:34 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E14CE53;\n\tThu, 17 Jun 2021 07:44:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J8niJGUa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623908674;\n\tbh=WxmF6UzNO3Y7Nlm+9AUaAoS5Vs4eSI6p0CN10ScoMBo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=J8niJGUau5Kh0s3KqZ1JkDlU8/C31rC/G8CCHKjSPGuiRe7clXOIEWK45HMNaC2WS\n\tlfx0AexuG/lpw3J+2Wb8IOoFdWIeJjxIDyvOvHLURMiSP1/m3lo01D23SbNhJ+Nhef\n\t9ksW9/LtTCBp0CC6XS357VsLNSKh506PlfssGfxg=","Date":"Thu, 17 Jun 2021 14:44:27 +0900","From":"paul.elder@ideasonboard.com","To":"Hirokazu Honda <hiroh@chromium.org>","Message-ID":"<20210617054427.GE1351869@pyrite.rasen.tech>","References":"<20210617045758.1432766-1-paul.elder@ideasonboard.com>\n\t<CAO5uPHP-RMfafEUsJs03KhzCdK+5gFfjs1BZF1thqAno=n_kuQ@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<CAO5uPHP-RMfafEUsJs03KhzCdK+5gFfjs1BZF1thqAno=n_kuQ@mail.gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v3] android: jpeg: get ISO from\n\tSENSOR_SENSITIVITY","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":17600,"web_url":"https://patchwork.libcamera.org/comment/17600/","msgid":"<CAO5uPHO7H3i3DyuSgkWNY3QTfr3nYEtWkXcnu57e1RHAcwz2Lw@mail.gmail.com>","date":"2021-06-17T05:47:55","subject":"Re: [libcamera-devel] [PATCH v3] android: jpeg: get ISO from\n\tSENSOR_SENSITIVITY","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Paul,\n\nOn Thu, Jun 17, 2021 at 2:44 PM <paul.elder@ideasonboard.com> wrote:\n\n> Hi Hiro,\n>\n> Thank you for the review.\n>\n> On Thu, Jun 17, 2021 at 02:31:11PM +0900, Hirokazu Honda wrote:\n> > HI Paul, thank you for the patch.\n> >\n> > On Thu, Jun 17, 2021 at 1:58 PM Paul Elder <paul.elder@ideasonboard.com>\n> wrote:\n> >\n> >     The data for the exif ISO tag needs to come from SENSOR_SENSITIVITY.\n> Set\n> >     it.\n> >\n> >     Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n> >     Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> >\n> >     ---\n> >     This on its own doesn't fix any CTS tests, but it prevents a test\n> >     failure later on when we add the proper static metadata for the FULL\n> >     hardware level.\n> >     ---\n> >      src/android/jpeg/post_processor_jpeg.cpp | 5 ++++-\n> >      1 file changed, 4 insertions(+), 1 deletion(-)\n> >\n> >     diff --git a/src/android/jpeg/post_processor_jpeg.cpp\n> b/src/android/jpeg/\n> >     post_processor_jpeg.cpp\n> >     index 058ccc99..921ac823 100644\n> >     --- a/src/android/jpeg/post_processor_jpeg.cpp\n> >     +++ b/src/android/jpeg/post_processor_jpeg.cpp\n> >     @@ -119,7 +119,10 @@ int PostProcessorJpeg::process(const\n> FrameBuffer &\n> >     source,\n> >             ret = requestMetadata.getEntry(ANDROID_LENS_APERTURE,\n> &entry);\n> >             if (ret)\n> >                     exif.setAperture(*entry.data.f);\n> >     -       exif.setISO(100);\n> >     +\n> >     +       ret = resultMetadata->getEntry(ANDROID_SENSOR_SENSITIVITY,\n> &entry);\n> >     +       exif.setISO(ret ? *entry.data.i32 : 100);\n> >\n> >\n> > Noob: where does 100 come from?\n>\n> It was an arbitrary number that passed CTS LIMITED :D\n>\n>\nI see.\nShall we add a comment about it?\n\nThanks,\n-Hiro\n\n>\n> Paul\n>\n> >\n> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org>\n> >\n> >     +\n> >             exif.setFlash(Exif::Flash::FlashNotPresent);\n> >             exif.setWhiteBalance(Exif::WhiteBalance::Auto);\n> >\n> >     --\n> >     2.27.0\n> >\n> >\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AFB8CBD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 17 Jun 2021 05:48:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2112868941;\n\tThu, 17 Jun 2021 07:48:09 +0200 (CEST)","from mail-ej1-x631.google.com (mail-ej1-x631.google.com\n\t[IPv6:2a00:1450:4864:20::631])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 573FF60296\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 17 Jun 2021 07:48:07 +0200 (CEST)","by mail-ej1-x631.google.com with SMTP id ho18so7684435ejc.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Jun 2021 22:48:07 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"bbETfuUZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=oBmWVIMmzgDtZnltiM0zO3cjE93994HSYJ6bpuxNgq4=;\n\tb=bbETfuUZ+GV6zqnXP9NmAnK7Pktgz1kh8mJg187RVEQO8Ili3qTaQBHXntT0hV60Gt\n\tylcmKpCj6BypfsBSLjWAgE06eIv5NERA5K7Vltf4oQZbEJzqXdjFKomRfn7QWW3T6KEr\n\t6CX5dpchTdP5lYHseO/BOrCHGZEggyPnjlYqQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=oBmWVIMmzgDtZnltiM0zO3cjE93994HSYJ6bpuxNgq4=;\n\tb=KB0IXu5FTy2u6tNySvBGjvKnzuP0iZL1wIVtOKWkFl8lNo3tVDo3ArVn6kpylJQUYf\n\tJkpyL9TL0yK/j4D+wgw3sT09EEmQ2TAZ2qFV+k9RogPBC2SJZDm+RpUhiu7xZ7YoQjHl\n\tvSpJViwWptGKdEWuUddiZA1DMkL+rNgYpYR0zZkLy6JFDck2xbKIFzUWBbaLS9cGvakt\n\tO/zC6OS1BGXyDF0u6gk2qRqdGnsD3sEtG807+P0TMmxWSA/7bHiD5qv/N+AsRr+WO1dR\n\tjN3oAF9kCOtRdHGe65mtBjTIHkTa8CmuZAnavDpcIkXq7x54PR+9J5Y6xdvWDnbftY6h\n\t2+9A==","X-Gm-Message-State":"AOAM533jDSslK6x/7pvH0Zv44ykXjFbr+WBq+4McrskqB31/bdsEDsQA\n\t9v2D4VxzafJFvCbPVin16UH+O2+qbO5DP68AvtrRKA==","X-Google-Smtp-Source":"ABdhPJxVuJ2Qz1IKhUaVsryboc0LW5vDbGRkBYUPcqvJEvfruttBpurRaP2SYCZ8O5K002qxkDBsk5MtYeNDrnNPGns=","X-Received":"by 2002:a17:906:19cc:: with SMTP id\n\th12mr3291004ejd.306.1623908886962; \n\tWed, 16 Jun 2021 22:48:06 -0700 (PDT)","MIME-Version":"1.0","References":"<20210617045758.1432766-1-paul.elder@ideasonboard.com>\n\t<CAO5uPHP-RMfafEUsJs03KhzCdK+5gFfjs1BZF1thqAno=n_kuQ@mail.gmail.com>\n\t<20210617054427.GE1351869@pyrite.rasen.tech>","In-Reply-To":"<20210617054427.GE1351869@pyrite.rasen.tech>","From":"Hirokazu Honda <hiroh@chromium.org>","Date":"Thu, 17 Jun 2021 14:47:55 +0900","Message-ID":"<CAO5uPHO7H3i3DyuSgkWNY3QTfr3nYEtWkXcnu57e1RHAcwz2Lw@mail.gmail.com>","To":"Paul Elder <paul.elder@ideasonboard.com>","Content-Type":"multipart/alternative; boundary=\"0000000000005aefc705c4efc026\"","Subject":"Re: [libcamera-devel] [PATCH v3] android: jpeg: get ISO from\n\tSENSOR_SENSITIVITY","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":17603,"web_url":"https://patchwork.libcamera.org/comment/17603/","msgid":"<20210617060513.GF1351869@pyrite.rasen.tech>","date":"2021-06-17T06:05:13","subject":"Re: [libcamera-devel] [PATCH v3] android: jpeg: get ISO from\n\tSENSOR_SENSITIVITY","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Hiro,\n\nOn Thu, Jun 17, 2021 at 02:47:55PM +0900, Hirokazu Honda wrote:\n> Hi Paul,\n> \n> On Thu, Jun 17, 2021 at 2:44 PM <paul.elder@ideasonboard.com> wrote:\n> \n>     Hi Hiro,\n> \n>     Thank you for the review.\n> \n>     On Thu, Jun 17, 2021 at 02:31:11PM +0900, Hirokazu Honda wrote:\n>     > HI Paul, thank you for the patch.\n>     >\n>     > On Thu, Jun 17, 2021 at 1:58 PM Paul Elder <paul.elder@ideasonboard.com>\n>     wrote:\n>     >\n>     >     The data for the exif ISO tag needs to come from SENSOR_SENSITIVITY.\n>     Set\n>     >     it.\n>     >\n>     >     Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n>     >     Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>     >\n>     >     ---\n>     >     This on its own doesn't fix any CTS tests, but it prevents a test\n>     >     failure later on when we add the proper static metadata for the FULL\n>     >     hardware level.\n>     >     ---\n>     >      src/android/jpeg/post_processor_jpeg.cpp | 5 ++++-\n>     >      1 file changed, 4 insertions(+), 1 deletion(-)\n>     >\n>     >     diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/\n>     jpeg/\n>     >     post_processor_jpeg.cpp\n>     >     index 058ccc99..921ac823 100644\n>     >     --- a/src/android/jpeg/post_processor_jpeg.cpp\n>     >     +++ b/src/android/jpeg/post_processor_jpeg.cpp\n>     >     @@ -119,7 +119,10 @@ int PostProcessorJpeg::process(const FrameBuffer\n>     &\n>     >     source,\n>     >             ret = requestMetadata.getEntry(ANDROID_LENS_APERTURE, &\n>     entry);\n>     >             if (ret)\n>     >                     exif.setAperture(*entry.data.f);\n>     >     -       exif.setISO(100);\n>     >     +\n>     >     +       ret = resultMetadata->getEntry(ANDROID_SENSOR_SENSITIVITY, &\n>     entry);\n>     >     +       exif.setISO(ret ? *entry.data.i32 : 100);\n>     >\n>     >\n>     > Noob: where does 100 come from?\n> \n>     It was an arbitrary number that passed CTS LIMITED :D\n> \n> \n> \n> I see.\n> Shall we add a comment about it?\n\nYeah we probably should.\n\nAlso I checked the EXIF documentation [1] and it says this field is for\n\"Indicates the ISO Speed and ISO Latitude of the camera or input device\nas specified in ISO 12232\", so that doesn't seem to match with\nSENSOR_SENSITIVITY [2]...\n\nBut also this allowed CTS FULL to pass when I tested it a long time\nago... I'll have to check again.\n\n[1] https://www.exif.org/Exif2-2.PDF\n[2] https://developer.android.com/reference/android/hardware/camera2/CaptureRequest#SENSOR_SENSITIVITY\n\n\nPaul\n\n> \n>     >\n>     > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> \n>     >\n>     >     +\n>     >             exif.setFlash(Exif::Flash::FlashNotPresent);\n>     >             exif.setWhiteBalance(Exif::WhiteBalance::Auto);\n>     >\n>     >     --\n>     >     2.27.0\n>     >\n>     >\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A936BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 17 Jun 2021 06:05:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 99B3468947;\n\tThu, 17 Jun 2021 08:05:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4988060296\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 17 Jun 2021 08:05:21 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 842E8E53;\n\tThu, 17 Jun 2021 08:05:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d/EXEQqg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623909920;\n\tbh=DDBYkpbeSR5V+HfiglGnE9Q91MFEmrwlpyKQkOPILFw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=d/EXEQqgYkWQsOl0C2H9z4olljxVgxemtwfrKujCKqtteFDGL23MW38z3pWbXpeoX\n\t/3DiISDpUfPemD4YiFut7crhWl8oDHnnP2krxxa066+5uST3KyKZy0d/0GIY3Va0+o\n\twY2Rhf27jYL7mnYy5P9PK7xr1J3dzSDW5COIdKZM=","Date":"Thu, 17 Jun 2021 15:05:13 +0900","From":"paul.elder@ideasonboard.com","To":"Hirokazu Honda <hiroh@chromium.org>","Message-ID":"<20210617060513.GF1351869@pyrite.rasen.tech>","References":"<20210617045758.1432766-1-paul.elder@ideasonboard.com>\n\t<CAO5uPHP-RMfafEUsJs03KhzCdK+5gFfjs1BZF1thqAno=n_kuQ@mail.gmail.com>\n\t<20210617054427.GE1351869@pyrite.rasen.tech>\n\t<CAO5uPHO7H3i3DyuSgkWNY3QTfr3nYEtWkXcnu57e1RHAcwz2Lw@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<CAO5uPHO7H3i3DyuSgkWNY3QTfr3nYEtWkXcnu57e1RHAcwz2Lw@mail.gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v3] android: jpeg: get ISO from\n\tSENSOR_SENSITIVITY","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]