[{"id":17593,"web_url":"https://patchwork.libcamera.org/comment/17593/","msgid":"","date":"2021-06-17T05:08:13","subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Simplify\n\tleftover CameraMetadata calls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Thu, Jun 17, 2021 at 01:57:13PM +0900, Paul Elder wrote:\n> There were some CameraMetadata calls that were left in the old version.\n> Update them.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 7 +++----\n> 1 file changed, 3 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index b8df7817..11d5c21b 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -931,7 +931,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\t{ 0, 1 }\n> \t};\n> \tstaticMetadata_->addEntry(ANDROID_CONTROL_AE_COMPENSATION_STEP,\n> -\t\t\t\t aeCompensationStep, 1);\n> +\t\t\t\t aeCompensationStep);\n> \n> \tstd::vector availableAfModes = {\n> \t\tANDROID_CONTROL_AF_MODE_OFF,\n> @@ -1153,7 +1153,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t/* Statistics static metadata. */\n> \tuint8_t faceDetectMode = ANDROID_STATISTICS_FACE_DETECT_MODE_OFF;\n> \tstaticMetadata_->addEntry(ANDROID_STATISTICS_INFO_AVAILABLE_FACE_DETECT_MODES,\n> -\t\t\t\t &faceDetectMode, 1);\n> +\t\t\t\t faceDetectMode);\n> \n> \tint32_t maxFaceCount = 0;\n> \tstaticMetadata_->addEntry(ANDROID_STATISTICS_INFO_MAX_FACE_COUNT,\n> @@ -1273,8 +1273,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\t\tANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS_OUTPUT);\n> \t}\n> \tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS,\n> -\t\t\t\t availableStreamConfigurations.data(),\n> -\t\t\t\t availableStreamConfigurations.size());\n> +\t\t\t\t availableStreamConfigurations);\n> \n> \tstd::vector availableStallDurations = {\n> \t\tANDROID_SCALER_AVAILABLE_FORMATS_BLOB, 2560, 1920, 33333333,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3AB3C3218\n\tfor ;\n\tThu, 17 Jun 2021 05:08:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6FC6068941;\n\tThu, 17 Jun 2021 07:08:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 77E9160296\n\tfor ;\n\tThu, 17 Jun 2021 07:08:34 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0C0AEE53;\n\tThu, 17 Jun 2021 07:08:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y1c+jWSU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623906514;\n\tbh=ElFxM6+hZoIlC7MfdH+Bwr5kRL03muRMqUQREvWgn1I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Y1c+jWSU3sPGU8wjbamI1YNf/JIOjmxlpXjDgHuYoMMkOA5cO63em3vg6IdbZQE9E\n\tt1bxCbkyndviK92qS9J8B83kKjOZshHG7Jb1UGJ/ddlN2l4TDYkofDenQ0Bv/RC3Xq\n\t6i4NmQ9Qi9n4J/d0gsNw8voY7lgvo2REwPVicfSU=","Date":"Thu, 17 Jun 2021 08:08:13 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210617045713.1432573-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210617045713.1432573-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Simplify\n\tleftover CameraMetadata calls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17595,"web_url":"https://patchwork.libcamera.org/comment/17595/","msgid":"","date":"2021-06-17T05:16:59","subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Simplify\n\tleftover CameraMetadata calls","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Paul, thank you for the patch.\n\nOn Thu, Jun 17, 2021 at 2:08 PM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Paul,\n>\n> Thank you for the patch.\n>\n> On Thu, Jun 17, 2021 at 01:57:13PM +0900, Paul Elder wrote:\n> > There were some CameraMetadata calls that were left in the old version.\n> > Update them.\n> >\n> > Signed-off-by: Paul Elder \n>\n> Reviewed-by: Laurent Pinchart \n>\n\nReviewed-by: Hirokazu Honda \n\n\n>\n> > ---\n> > src/android/camera_device.cpp | 7 +++----\n> > 1 file changed, 3 insertions(+), 4 deletions(-)\n> >\n> > diff --git a/src/android/camera_device.cpp\n> b/src/android/camera_device.cpp\n> > index b8df7817..11d5c21b 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -931,7 +931,7 @@ const camera_metadata_t\n> *CameraDevice::getStaticMetadata()\n> > { 0, 1 }\n> > };\n> > staticMetadata_->addEntry(ANDROID_CONTROL_AE_COMPENSATION_STEP,\n> > - aeCompensationStep, 1);\n> > + aeCompensationStep);\n> >\n> > std::vector availableAfModes = {\n> > ANDROID_CONTROL_AF_MODE_OFF,\n> > @@ -1153,7 +1153,7 @@ const camera_metadata_t\n> *CameraDevice::getStaticMetadata()\n> > /* Statistics static metadata. */\n> > uint8_t faceDetectMode = ANDROID_STATISTICS_FACE_DETECT_MODE_OFF;\n> >\n> staticMetadata_->addEntry(ANDROID_STATISTICS_INFO_AVAILABLE_FACE_DETECT_MODES,\n> > - &faceDetectMode, 1);\n> > + faceDetectMode);\n> >\n> > int32_t maxFaceCount = 0;\n> > staticMetadata_->addEntry(ANDROID_STATISTICS_INFO_MAX_FACE_COUNT,\n> > @@ -1273,8 +1273,7 @@ const camera_metadata_t\n> *CameraDevice::getStaticMetadata()\n> >\n> ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS_OUTPUT);\n> > }\n> >\n> staticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS,\n> > - availableStreamConfigurations.data(),\n> > - availableStreamConfigurations.size());\n> > + availableStreamConfigurations);\n> >\n> > std::vector availableStallDurations = {\n> > ANDROID_SCALER_AVAILABLE_FORMATS_BLOB, 2560, 1920,\n> 33333333,\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 515A8C3218\n\tfor ;\n\tThu, 17 Jun 2021 05:17:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1438C6893F;\n\tThu, 17 Jun 2021 07:17:13 +0200 (CEST)","from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com\n\t[IPv6:2a00:1450:4864:20::52e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF28060296\n\tfor ;\n\tThu, 17 Jun 2021 07:17:11 +0200 (CEST)","by mail-ed1-x52e.google.com with SMTP id t7so2136939edd.5\n\tfor ;\n\tWed, 16 Jun 2021 22:17:11 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"j6zN7ZeD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=iNM0F6PXd4/IFvMMRCbKZEJaiwpTCIc6j6eeFpx9118=;\n\tb=j6zN7ZeDRliR5g1HqekirmkFFN9HkFbjn6ARx//6ozNIgyfJqsP9YV+SC4qQ4bzq64\n\tP/hAISSs9zH1F4F77BTVrIXghPqn4NQFhyfbBCWAH87DzFx2H9xu4OinVe6zjzlgdRz0\n\t7oOiH54loZNftcbJfbdWl2IgY8pbSLHpNpyeU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=iNM0F6PXd4/IFvMMRCbKZEJaiwpTCIc6j6eeFpx9118=;\n\tb=svD4bpkrdIlnqaUJCz6YWRVZR62zr8wz6Nm7nFNQoGtTW1JeNo9vuCY294coIsh5Ye\n\tZXNk9XDwnJNy1OZyLJdrMYxdo8+YbobDwL/n76OuSI+ugesBspHdlcCX1Eh5CbY+Ar4R\n\t2G7p8IDmtJWqbRmrIO7NyahUscepfrxCQW+jxCTaEUDSevdczw1gK+3lY3qnuCQMTtlr\n\taaO5+utfzfCwVCDHdzGGZFSyFQvvWuxdJE9k7b+4TK+hQRMU7xam6mmzARdJq4RtVEWs\n\tgUaICeAGwfUmtfWB3+C4LVYfq+BlYHklucdTih5XG0ywqNt6XtYVTNnK2sduBnrRuwIw\n\tRKFw==","X-Gm-Message-State":"AOAM531KpGhDS9Li5w9hRgL/xTOtn8fAUzakY35TSW6BP/m8Q1nS6zBA\n\tqRR0bHaeOaJUkEcQ0HhtcmZgqk9kTHdoln9Ij3gFug==","X-Google-Smtp-Source":"ABdhPJyB1R2rQFTsc9KW5tfGAity7Zm937cz9Q+NWGyYxY3YTZAUdtwK23vD9YGWW1iRheQKtMMDu8CxcZrcwPa+RQ0=","X-Received":"by 2002:aa7:ce05:: with SMTP id d5mr3892359edv.325.1623907031478;\n\tWed, 16 Jun 2021 22:17:11 -0700 (PDT)","MIME-Version":"1.0","References":"<20210617045713.1432573-1-paul.elder@ideasonboard.com>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Thu, 17 Jun 2021 14:16:59 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"000000000000c281bc05c4ef5191\"","Subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Simplify\n\tleftover CameraMetadata calls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]