{"id":12625,"url":"https://patchwork.libcamera.org/api/patches/12625/?format=json","web_url":"https://patchwork.libcamera.org/patch/12625/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210617045713.1432573-1-paul.elder@ideasonboard.com>","date":"2021-06-17T04:57:13","name":"[libcamera-devel] android: camera_device: Simplify leftover CameraMetadata calls","commit_ref":"b4c3db4c015082a2866e3e546b74d3b3de253d7f","pull_url":null,"state":"accepted","archived":false,"hash":"2a7e25366b8373652cfd6170ea89a8c83b16a70b","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12625/mbox/","series":[{"id":2146,"url":"https://patchwork.libcamera.org/api/series/2146/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2146","date":"2021-06-17T04:57:13","name":"[libcamera-devel] android: camera_device: Simplify leftover CameraMetadata calls","version":1,"mbox":"https://patchwork.libcamera.org/series/2146/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12625/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12625/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 43071BD78E\n\tfor ;\n\tThu, 17 Jun 2021 04:57:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B76816893F;\n\tThu, 17 Jun 2021 06:57:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 57F7F60296\n\tfor ;\n\tThu, 17 Jun 2021 06:57:31 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A9A3AE53;\n\tThu, 17 Jun 2021 06:57:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jDVA3v6I\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623905850;\n\tbh=mpn45AkillXMmM+EYzsiws2WVoO9EeZAB1lB92wRlJk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=jDVA3v6IgsSWf89b7TBE7RhWv5sfnxTUPD5MPfcPlrmhd2hK8pPACl5hTs5b+UJ+d\n\tGkkayAKeq/sOtRJjIV0HtE/0QEjyZcFneJ+ynm6oH9x4SEvsfdRwd5XTzY21NlXk5c\n\tecwWJ+y4F2Uaat918r1bmpQEDeXPp/tvy7cA6QRY=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 17 Jun 2021 13:57:13 +0900","Message-Id":"<20210617045713.1432573-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] android: camera_device: Simplify leftover\n\tCameraMetadata calls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There were some CameraMetadata calls that were left in the old version.\nUpdate them.\n\nSigned-off-by: Paul Elder \n---\n src/android/camera_device.cpp | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex b8df7817..11d5c21b 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -931,7 +931,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\t{ 0, 1 }\n \t};\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AE_COMPENSATION_STEP,\n-\t\t\t\t aeCompensationStep, 1);\n+\t\t\t\t aeCompensationStep);\n \n \tstd::vector availableAfModes = {\n \t\tANDROID_CONTROL_AF_MODE_OFF,\n@@ -1153,7 +1153,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t/* Statistics static metadata. */\n \tuint8_t faceDetectMode = ANDROID_STATISTICS_FACE_DETECT_MODE_OFF;\n \tstaticMetadata_->addEntry(ANDROID_STATISTICS_INFO_AVAILABLE_FACE_DETECT_MODES,\n-\t\t\t\t &faceDetectMode, 1);\n+\t\t\t\t faceDetectMode);\n \n \tint32_t maxFaceCount = 0;\n \tstaticMetadata_->addEntry(ANDROID_STATISTICS_INFO_MAX_FACE_COUNT,\n@@ -1273,8 +1273,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\t\tANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS_OUTPUT);\n \t}\n \tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS,\n-\t\t\t\t availableStreamConfigurations.data(),\n-\t\t\t\t availableStreamConfigurations.size());\n+\t\t\t\t availableStreamConfigurations);\n \n \tstd::vector availableStallDurations = {\n \t\tANDROID_SCALER_AVAILABLE_FORMATS_BLOB, 2560, 1920, 33333333,\n","prefixes":["libcamera-devel"]}