[{"id":17578,"web_url":"https://patchwork.libcamera.org/comment/17578/","msgid":"","date":"2021-06-16T10:01:06","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Report\n\terror when failing to configure","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Kieran, thank you for the patch.\n\nOn Wed, Jun 16, 2021 at 6:56 PM Kieran Bingham <\nkieran.bingham@ideasonboard.com> wrote:\n\n> If the IPA fails to configure, this can now be caught by the pipeline\n> handler\n> but the cause may not be clear.\n>\n> If the IPA is isolated, then reports from that IPA will not be visible\n> in the libcamera logs directly.\n>\n> Print the return error value to help identify any issue that has arisen.\n>\n> Signed-off-by: Kieran Bingham \n>\n\nReviewed-by: Hirokazu Honda \n\n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 35f1e977ab19..113e70a5e692 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -644,7 +644,8 @@ int PipelineHandlerIPU3::configure(Camera *camera,\n> CameraConfiguration *c)\n>\n> ret = data->ipa_->configure(configInfo);\n> if (ret) {\n> - LOG(IPU3, Error) << \"Failed to configure IPA\";\n> + LOG(IPU3, Error) << \"Failed to configure IPA: \"\n> + << strerror(-ret);\n> return ret;\n> }\n>\n> --\n> 2.30.2\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AEECABD78E\n\tfor ;\n\tWed, 16 Jun 2021 10:01:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 29B486892E;\n\tWed, 16 Jun 2021 12:01:20 +0200 (CEST)","from mail-ej1-x631.google.com (mail-ej1-x631.google.com\n\t[IPv6:2a00:1450:4864:20::631])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59BA16892D\n\tfor ;\n\tWed, 16 Jun 2021 12:01:18 +0200 (CEST)","by mail-ej1-x631.google.com with SMTP id ce15so2937730ejb.4\n\tfor ;\n\tWed, 16 Jun 2021 03:01:18 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"eECGwi10\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=F+PwZbThIwPE/X1YBD/HpgNq6VtPAoU8ABr7UCpCvS0=;\n\tb=eECGwi10fXTVrC7DFaVXhF/u2UVEOWPkc9TjQ9yvSvOkYMwDkH8xujfxJc6A63a6c/\n\tsYR5TE3UAI0BflkG44zRJdJCadriWMyR8eJBSsfOrFMy7UJIaEDFhXj8DJL+5I4Td2a5\n\tNYET+EN7PQy1ylRBmTS8QVU/cafElanfyAbc8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=F+PwZbThIwPE/X1YBD/HpgNq6VtPAoU8ABr7UCpCvS0=;\n\tb=rUeD7DNKaXgE7+9HXj/uRcPO4lpVhSXjVXEbOnikTEvq5Yuqg2rzuENYL0zjyETX99\n\tDQq1P7xdaH39i8fCFr23DHHALn+kAryLY7MPt4M9B1dIBNNs5YRY7xcYrUUcV2neYHGH\n\tnznErv5vnwCOgk5Iy5jKTK28vXXqsuptiFMwnupAiVUiHBmQ5Fzta3NPjN8PsCEIQo9+\n\t3NP2ShMdoU5zKrxQDwAQFHiU5DLM0bCnjf+vaLEqo7EGu2JDrqnv3+FRz3TuMk790FpQ\n\t8HEqqCzxVL5pGq5GQ9VgRLWcIDVzqMSV3ks+PFmCrGoCrJ0TN7FPh2p7rWip7xzCLgJx\n\ttNyg==","X-Gm-Message-State":"AOAM532rlUpyuQ0DFit9X04Ep4+z5k1dImvPVnweRexMGjbrlzAZuk1y\n\tH+VjlXvvy0ijAPpyIbuHEPbiTQ84lj2A3S0TkTuuqg==","X-Google-Smtp-Source":"ABdhPJzz8k/QgF4hzUnYrUaDaCFAPTr2HGsNCykxNst9fzfHiWxVQ1Z1H1DgCuifFqstHjmmagmeFkpJkSyN3TyOVo0=","X-Received":"by 2002:a17:906:ccc3:: with SMTP id\n\tot3mr4379206ejb.475.1623837677963; \n\tWed, 16 Jun 2021 03:01:17 -0700 (PDT)","MIME-Version":"1.0","References":"<20210616095617.3593384-1-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20210616095617.3593384-1-kieran.bingham@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Wed, 16 Jun 2021 19:01:06 +0900","Message-ID":"","To":"Kieran Bingham ","Content-Type":"multipart/alternative; boundary=\"000000000000f7dbd705c4df2b0b\"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Report\n\terror when failing to configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17579,"web_url":"https://patchwork.libcamera.org/comment/17579/","msgid":"<20210616100302.GC1351869@pyrite.rasen.tech>","date":"2021-06-16T10:03:02","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Report\n\terror when failing to configure","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Wed, Jun 16, 2021 at 10:56:17AM +0100, Kieran Bingham wrote:\n> If the IPA fails to configure, this can now be caught by the pipeline handler\n> but the cause may not be clear.\n> \n> If the IPA is isolated, then reports from that IPA will not be visible\n> in the libcamera logs directly.\n> \n> Print the return error value to help identify any issue that has arisen.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 35f1e977ab19..113e70a5e692 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -644,7 +644,8 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> \n> \tret = data->ipa_->configure(configInfo);\n> \tif (ret) {\n> -\t\tLOG(IPU3, Error) << \"Failed to configure IPA\";\n> +\t\tLOG(IPU3, Error) << \"Failed to configure IPA: \"\n> +\t\t\t\t << strerror(-ret);\n> \t\treturn ret;\n> \t}\n> \n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4FD15BD78E\n\tfor ;\n\tWed, 16 Jun 2021 10:03:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B111068940;\n\tWed, 16 Jun 2021 12:03:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7C616892D\n\tfor ;\n\tWed, 16 Jun 2021 12:03:09 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 20245F88;\n\tWed, 16 Jun 2021 12:03:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rQi8N1t6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623837789;\n\tbh=L6THIIGLIZzGqc7pmwcEHyVD+nof251nJYughWRmOnc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rQi8N1t6Z/UHGe8x9IMRQUsTWh/wTQFgjM3pV5VHfX7xr4Dfzp9l+ckS7ll1sp4XG\n\tmkRrBGJWd7q7y6Eho6PjBKzFIHLVyg7JPjuWeHQyys+AxN6Vy72mFuePXR5k+cSR9w\n\tC6YXD7Bem2C0zOT0uk+P29p5/sG9RziBW4Pe40nM=","Date":"Wed, 16 Jun 2021 19:03:02 +0900","From":"paul.elder@ideasonboard.com","To":"Kieran Bingham ","Message-ID":"<20210616100302.GC1351869@pyrite.rasen.tech>","References":"<20210616095617.3593384-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210616095617.3593384-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Report\n\terror when failing to configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17580,"web_url":"https://patchwork.libcamera.org/comment/17580/","msgid":"<7b8ed556-89af-1551-3cde-df73ccf8ce97@ideasonboard.com>","date":"2021-06-16T11:10:42","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Report\n\terror when failing to configure","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 6/16/21 3:26 PM, Kieran Bingham wrote:\n> If the IPA fails to configure, this can now be caught by the pipeline handler\n> but the cause may not be clear.\n>\n> If the IPA is isolated, then reports from that IPA will not be visible\n> in the libcamera logs directly.\nDrive by: We discussed file-logging for IPAs(isolated or otherwise). I \nwonder while at it,\nwould it be worth to let pipeline-handler know how IPA is loaded (in \nisolated context\nor otherwise) by querying a flag in Proxy maybe and log that flag value \nin PH(s)?\n>\n> Print the return error value to help identify any issue that has arisen.\n>\n> Signed-off-by: Kieran Bingham \nReviewed-by: Umang Jain \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 35f1e977ab19..113e70a5e692 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -644,7 +644,8 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> \n> \tret = data->ipa_->configure(configInfo);\n> \tif (ret) {\n> -\t\tLOG(IPU3, Error) << \"Failed to configure IPA\";\n> +\t\tLOG(IPU3, Error) << \"Failed to configure IPA: \"\n> +\t\t\t\t << strerror(-ret);\n> \t\treturn ret;\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4A62C3218\n\tfor ;\n\tWed, 16 Jun 2021 11:10:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 57E7D68940;\n\tWed, 16 Jun 2021 13:10:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E197A6892F\n\tfor ;\n\tWed, 16 Jun 2021 13:10:46 +0200 (CEST)","from [192.168.0.107] (unknown [103.238.109.26])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E04BFF88;\n\tWed, 16 Jun 2021 13:10:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c5mFkRxi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623841846;\n\tbh=fIqp/Y0552WLr/VPioPx+bT84etlouG6KW1is/E3rH4=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=c5mFkRxi9Mag4+X5VEuczHEhRkPCVHjt8S2dx/mHqkehDbuTPPD4Kkx00g6io/aTB\n\tCqjmijYvTPDxdm24zRZegGCYD9eUCmky6qdDS+MCfem0/CF2Gtej7pAQsbUrbIE3mt\n\tpJIQj1SH4a45QM7gn2jzEhX1hdqZYxfsHeYNxp0Q=","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20210616095617.3593384-1-kieran.bingham@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<7b8ed556-89af-1551-3cde-df73ccf8ce97@ideasonboard.com>","Date":"Wed, 16 Jun 2021 16:40:42 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210616095617.3593384-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Report\n\terror when failing to configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17581,"web_url":"https://patchwork.libcamera.org/comment/17581/","msgid":"","date":"2021-06-16T11:27:28","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Report\n\terror when failing to configure","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nOn Wed, Jun 16, 2021 at 04:40:42PM +0530, Umang Jain wrote:\n> On 6/16/21 3:26 PM, Kieran Bingham wrote:\n> > If the IPA fails to configure, this can now be caught by the pipeline handler\n> > but the cause may not be clear.\n> >\n> > If the IPA is isolated, then reports from that IPA will not be visible\n> > in the libcamera logs directly.\n>\n> Drive by: We discussed file-logging for IPAs(isolated or otherwise). I \n> wonder while at it,\n> would it be worth to let pipeline-handler know how IPA is loaded (in \n> isolated context\n> or otherwise) by querying a flag in Proxy maybe and log that flag value \n> in PH(s)?\n\nI'd really, really prefer not making it possible for pipeline handlers\nto differenciate between IPAs. If we want to log this information, we\ncan do so in IPAManager::createIPA() for instance.\n\n> > Print the return error value to help identify any issue that has arisen.\n> >\n> > Signed-off-by: Kieran Bingham \n>\n> Reviewed-by: Umang Jain \n>\n> > ---\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 3 ++-\n> > 1 file changed, 2 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index 35f1e977ab19..113e70a5e692 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -644,7 +644,8 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> > \n> > \tret = data->ipa_->configure(configInfo);\n> > \tif (ret) {\n> > -\t\tLOG(IPU3, Error) << \"Failed to configure IPA\";\n> > +\t\tLOG(IPU3, Error) << \"Failed to configure IPA: \"\n> > +\t\t\t\t << strerror(-ret);\n> > \t\treturn ret;\n> > \t}\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E839BD78E\n\tfor ;\n\tWed, 16 Jun 2021 11:27:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EA06568944;\n\tWed, 16 Jun 2021 13:27:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DF3E6892F\n\tfor ;\n\tWed, 16 Jun 2021 13:27:50 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E0C14F88;\n\tWed, 16 Jun 2021 13:27:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IyfeX0R4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623842870;\n\tbh=eX/FgS+gA/RfSt8DoItbYWR2hon6ZxTlsdQWZINRgEA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IyfeX0R43XuEYgIgA3+TeuZZ4ZJ9xzoNmZIearZzA8V8AiNe4HK4Dxusq9b4WMr/K\n\tGbx25buX7TsXbocc3CCBuU7Z0+8T5sFX+UeYbPpSM66BG74ddPlKSh3+OJeDb1lMRv\n\t5Bg+zLRnbQClnFJuWpQWuNvhF+9IR3Qj6guzk7nU=","Date":"Wed, 16 Jun 2021 14:27:28 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20210616095617.3593384-1-kieran.bingham@ideasonboard.com>\n\t<7b8ed556-89af-1551-3cde-df73ccf8ce97@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<7b8ed556-89af-1551-3cde-df73ccf8ce97@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Report\n\terror when failing to configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]