[{"id":17647,"web_url":"https://patchwork.libcamera.org/comment/17647/","msgid":"<CAO5uPHNHNP95320+ZhhhLGReqnw_GC3rgrn9OR1xzsjggEwhuA@mail.gmail.com>","date":"2021-06-21T02:41:38","subject":"Re: [libcamera-devel] [PATCH] android: mm: cros_camera_buffer: Fix\n\twrong indexing in plane()","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"gentle ping for review.\n\nOn Wed, Jun 16, 2021 at 5:59 PM Hirokazu Honda <hiroh@chromium.org> wrote:\n\n> CameraBuffer::plane() should be accessed in zero based index.\n> Fix the wrong indexing in CameraBuffer::plane() in\n> cros_camera_buffer.cpp.\n>\n> Signed-off-by: Hirokazu Honda <hiroh@chromium.org>\n> ---\n>  src/android/mm/cros_camera_buffer.cpp | 6 +++---\n>  1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/android/mm/cros_camera_buffer.cpp\n> b/src/android/mm/cros_camera_buffer.cpp\n> index 59e26d1b..c4157606 100644\n> --- a/src/android/mm/cros_camera_buffer.cpp\n> +++ b/src/android/mm/cros_camera_buffer.cpp\n> @@ -113,13 +113,13 @@ Span<uint8_t> CameraBuffer::Private::plane(unsigned\n> int plane)\n>                 break;\n>         default:\n>                 switch (plane) {\n> -               case 1:\n> +               case 0:\n>                         addr = mem.ycbcr.y;\n>                         break;\n> -               case 2:\n> +               case 1:\n>                         addr = mem.ycbcr.cb;\n>                         break;\n> -               case 3:\n> +               case 2:\n>                         addr = mem.ycbcr.cr;\n>                         break;\n>                 }\n> --\n> 2.32.0.272.g935e593368-goog\n>\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51D35BE58C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Jun 2021 02:41:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0EB2168935;\n\tMon, 21 Jun 2021 04:41:50 +0200 (CEST)","from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com\n\t[IPv6:2a00:1450:4864:20::62b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C5CA60297\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Jun 2021 04:41:49 +0200 (CEST)","by mail-ej1-x62b.google.com with SMTP id g20so26175979ejt.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 20 Jun 2021 19:41:49 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"gdLxan5J\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=MHPqAsoveif2Yyko6Iheer3IFxskVXPuLxM9RolnTEI=;\n\tb=gdLxan5JGX7u7ZWhuvcnktV/ompsnMj7hIoBuYXtrw3DfgaprO0z1U8zq4hfmDX1H9\n\tMRb608Civ2zPgMIKhjEl31zVtouylBpg0owG/ORWDTBOUFMOCA+/Cm8SMDU5XhL3k+1j\n\tXgYTJhg2gwjBzNmKGpaCx5vj8robc7fYsA/Eg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=MHPqAsoveif2Yyko6Iheer3IFxskVXPuLxM9RolnTEI=;\n\tb=KJDb/9KbtvVjHICZ5Cnsa/BlNVEMOam1rrYF5QQc4AseV6E+N/P/fQLzu8OY/OD0EN\n\tVBUsAk2DkO5lDMKQ2fVipZT4y8udKZpnedQRmFT5l/2xCgZXL477TdVIRv+WFlfEQLQj\n\tEMYAOAMzpXUUHq5Jh1xDgPwqQdwbGNKbnaUWBn8UMqAy3pjqbO3kxT6AAlbO/DuLn1yD\n\tKIkij85aLcQHdmadRT0xg7f1teQRD06B9TzLUvquvshw4T/noCB8hNrtd2YDpWbO0R0V\n\tBszGJF53gCxc9hFoW8+0qm/+BdjDQkE5EQ80yFW8vf7Se9KbREMp/8Kh39mjd6/qhJij\n\t/M5w==","X-Gm-Message-State":"AOAM5339ELO0r1SX2J31Y87KJAkP7cBFQ1YAgO/biW+8tiHOMx4m1xdh\n\tY/cQ79Ly+Mg911ktJ06tecJD2X5q9J7Kz2ewoalzewRZFZp3Ug==","X-Google-Smtp-Source":"ABdhPJwJjGhWBUytkr02KzyAz332B9op/IfWiciSQrlTqFte/MAb5zhhA4kl58BQkLINhTCWWOWGBd0AxENra2ubhSI=","X-Received":"by 2002:a17:906:5d14:: with SMTP id\n\tg20mr21749792ejt.243.1624243308660; \n\tSun, 20 Jun 2021 19:41:48 -0700 (PDT)","MIME-Version":"1.0","References":"<20210616085923.2888083-1-hiroh@chromium.org>","In-Reply-To":"<20210616085923.2888083-1-hiroh@chromium.org>","From":"Hirokazu Honda <hiroh@chromium.org>","Date":"Mon, 21 Jun 2021 11:41:38 +0900","Message-ID":"<CAO5uPHNHNP95320+ZhhhLGReqnw_GC3rgrn9OR1xzsjggEwhuA@mail.gmail.com>","To":"libcamera devel <libcamera-devel@lists.libcamera.org>","Content-Type":"multipart/alternative; boundary=\"000000000000711bc405c53d9d62\"","Subject":"Re: [libcamera-devel] [PATCH] android: mm: cros_camera_buffer: Fix\n\twrong indexing in plane()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":17743,"web_url":"https://patchwork.libcamera.org/comment/17743/","msgid":"<CAO5uPHP-miFf-b+4dR+ue+gzRqDF-tOa9+MNTvnU7RuTBkRQpA@mail.gmail.com>","date":"2021-06-25T02:39:41","subject":"Re: [libcamera-devel] [PATCH] android: mm: cros_camera_buffer: Fix\n\twrong indexing in plane()","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"gentle ping for review :)\n\nOn Mon, Jun 21, 2021 at 11:41 AM Hirokazu Honda <hiroh@chromium.org> wrote:\n>\n> gentle ping for review.\n>\n> On Wed, Jun 16, 2021 at 5:59 PM Hirokazu Honda <hiroh@chromium.org> wrote:\n>>\n>> CameraBuffer::plane() should be accessed in zero based index.\n>> Fix the wrong indexing in CameraBuffer::plane() in\n>> cros_camera_buffer.cpp.\n>>\n>> Signed-off-by: Hirokazu Honda <hiroh@chromium.org>\n>> ---\n>>  src/android/mm/cros_camera_buffer.cpp | 6 +++---\n>>  1 file changed, 3 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp\n>> index 59e26d1b..c4157606 100644\n>> --- a/src/android/mm/cros_camera_buffer.cpp\n>> +++ b/src/android/mm/cros_camera_buffer.cpp\n>> @@ -113,13 +113,13 @@ Span<uint8_t> CameraBuffer::Private::plane(unsigned int plane)\n>>                 break;\n>>         default:\n>>                 switch (plane) {\n>> -               case 1:\n>> +               case 0:\n>>                         addr = mem.ycbcr.y;\n>>                         break;\n>> -               case 2:\n>> +               case 1:\n>>                         addr = mem.ycbcr.cb;\n>>                         break;\n>> -               case 3:\n>> +               case 2:\n>>                         addr = mem.ycbcr.cr;\n>>                         break;\n>>                 }\n>> --\n>> 2.32.0.272.g935e593368-goog\n>>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8DE01C321A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 25 Jun 2021 02:39:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 98727684CE;\n\tFri, 25 Jun 2021 04:39:52 +0200 (CEST)","from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com\n\t[IPv6:2a00:1450:4864:20::52f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4FD3684C9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 25 Jun 2021 04:39:51 +0200 (CEST)","by mail-ed1-x52f.google.com with SMTP id m14so11383631edp.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Jun 2021 19:39:51 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"fQOzIp74\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=XY140NbA6PlldB4rpELtvfDiTR3kss8tvyBgdWo+a1w=;\n\tb=fQOzIp74BZcL2yhF0iKiWiiNssR/SniwTFJnT1Px6PnzLeOm6tV2uCGBOkUY8gIFWv\n\t8elaNAVpO+TLLsLBmiS/BgYA1sXYWwOiUHSTr4EIMBxXZ44ZtXMlnTQ4Jux9jo9ulnjs\n\tC9QF1STXosjaSoJHFIdS/OojirMoaxHOyXO1Q=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=XY140NbA6PlldB4rpELtvfDiTR3kss8tvyBgdWo+a1w=;\n\tb=R9Xh6wvrueKeLNGbLpClKQv1lfdKG8poSozwIge8oyAiJWmAItQAVGuVtvN8Bl55mv\n\t+9hC7YHC1njoHQ03iLy25BN2k3xlnbnvS6dJoLe2euEs1iA1DNXZ5E4amb5MEXrH9gkO\n\tDo1jWH+bzJcqcSNxDKPhDqhl+WSeR4YrghAn5b1mldiYg9PTp+pu6XYhj8U8D2h/KISN\n\tpEPHlV8scvgzXU3hQHw5LAZaWMaT7O3zdP3byIOJ3TrosWzoxfafoi+q+4+CicevDZf3\n\tSmWrO6idcoyBykyhEJKHspjoGDYKrRakTxjVH2sukD+zlkrQjHP7ZsfZAUDcA/vJnQBW\n\tlJ6Q==","X-Gm-Message-State":"AOAM5304VV87s1JOaCqmbv4Q8WMJi9S8lb1ziNz4m9ZUwmKiTLuFC46p\n\te78FCJml83hrQMnoUZWJJyZdBYvuk01183vJOo3g8pW2+/R/Yg==","X-Google-Smtp-Source":"ABdhPJxSCQS97mXPw2beri06VS2XBogyo+dMuTHAmkTQWZy83vbi19GkML1tNupv10OsxghZdGlCFDdPp5uIInA/Pa4=","X-Received":"by 2002:a05:6402:3548:: with SMTP id\n\tf8mr11466210edd.116.1624588791267; \n\tThu, 24 Jun 2021 19:39:51 -0700 (PDT)","MIME-Version":"1.0","References":"<20210616085923.2888083-1-hiroh@chromium.org>\n\t<CAO5uPHNHNP95320+ZhhhLGReqnw_GC3rgrn9OR1xzsjggEwhuA@mail.gmail.com>","In-Reply-To":"<CAO5uPHNHNP95320+ZhhhLGReqnw_GC3rgrn9OR1xzsjggEwhuA@mail.gmail.com>","From":"Hirokazu Honda <hiroh@chromium.org>","Date":"Fri, 25 Jun 2021 11:39:41 +0900","Message-ID":"<CAO5uPHP-miFf-b+4dR+ue+gzRqDF-tOa9+MNTvnU7RuTBkRQpA@mail.gmail.com>","To":"libcamera devel <libcamera-devel@lists.libcamera.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] android: mm: cros_camera_buffer: Fix\n\twrong indexing in plane()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":17756,"web_url":"https://patchwork.libcamera.org/comment/17756/","msgid":"<YNVMWJBn4HoIcDt1@pendragon.ideasonboard.com>","date":"2021-06-25T03:24:08","subject":"Re: [libcamera-devel] [PATCH] android: mm: cros_camera_buffer: Fix\n\twrong indexing in plane()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the patch, and sorry for the delay. Sometimes the simplest\nfix, that should be easy to review, still fall through the cracks :-S\n\nOn Fri, Jun 25, 2021 at 11:39:41AM +0900, Hirokazu Honda wrote:\n> gentle ping for review :)\n> \n> On Mon, Jun 21, 2021 at 11:41 AM Hirokazu Honda wrote:\n> >\n> > gentle ping for review.\n> >\n> > On Wed, Jun 16, 2021 at 5:59 PM Hirokazu Honda wrote:\n> >>\n> >> CameraBuffer::plane() should be accessed in zero based index.\n> >> Fix the wrong indexing in CameraBuffer::plane() in\n> >> cros_camera_buffer.cpp.\n> >>\n> >> Signed-off-by: Hirokazu Honda <hiroh@chromium.org>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> >> ---\n> >>  src/android/mm/cros_camera_buffer.cpp | 6 +++---\n> >>  1 file changed, 3 insertions(+), 3 deletions(-)\n> >>\n> >> diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp\n> >> index 59e26d1b..c4157606 100644\n> >> --- a/src/android/mm/cros_camera_buffer.cpp\n> >> +++ b/src/android/mm/cros_camera_buffer.cpp\n> >> @@ -113,13 +113,13 @@ Span<uint8_t> CameraBuffer::Private::plane(unsigned int plane)\n> >>                 break;\n> >>         default:\n> >>                 switch (plane) {\n> >> -               case 1:\n> >> +               case 0:\n> >>                         addr = mem.ycbcr.y;\n> >>                         break;\n> >> -               case 2:\n> >> +               case 1:\n> >>                         addr = mem.ycbcr.cb;\n> >>                         break;\n> >> -               case 3:\n> >> +               case 2:\n> >>                         addr = mem.ycbcr.cr;\n> >>                         break;\n> >>                 }","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 24227C321A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 25 Jun 2021 03:24:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 759E5684D1;\n\tFri, 25 Jun 2021 05:24:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A821684C9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 25 Jun 2021 05:24:40 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8A3C2501;\n\tFri, 25 Jun 2021 05:24:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qqX545AH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624591479;\n\tbh=t6SmkKrFKYmC6sTXUyXmI4zTHPqKpGhLH4Gp+iUb5z8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qqX545AHy8UM/5WB/kblVXg6j5O2psuSzdiurmXzmUhwXcpIAs/tK0xou7WXwId8R\n\tXwQJZpWRl7/QP5X5SjQ6v2ISTVtbQWeUcAO1AogRYkgGOX9wjgyghyYglNj985G8lI\n\tfOPveLd+gDcfnrk/3IN1t5H78pspKYPAffXWM0Ag=","Date":"Fri, 25 Jun 2021 06:24:08 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Hirokazu Honda <hiroh@chromium.org>","Message-ID":"<YNVMWJBn4HoIcDt1@pendragon.ideasonboard.com>","References":"<20210616085923.2888083-1-hiroh@chromium.org>\n\t<CAO5uPHNHNP95320+ZhhhLGReqnw_GC3rgrn9OR1xzsjggEwhuA@mail.gmail.com>\n\t<CAO5uPHP-miFf-b+4dR+ue+gzRqDF-tOa9+MNTvnU7RuTBkRQpA@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<CAO5uPHP-miFf-b+4dR+ue+gzRqDF-tOa9+MNTvnU7RuTBkRQpA@mail.gmail.com>","Subject":"Re: [libcamera-devel] [PATCH] android: mm: cros_camera_buffer: Fix\n\twrong indexing in plane()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":17782,"web_url":"https://patchwork.libcamera.org/comment/17782/","msgid":"<20210625091406.GR2599@pyrite.rasen.tech>","date":"2021-06-25T09:14:06","subject":"Re: [libcamera-devel] [PATCH] android: mm: cros_camera_buffer: Fix\n\twrong indexing in plane()","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Hiro,\n\nSorry for the delay.\n\nOn Wed, Jun 16, 2021 at 05:59:23PM +0900, Hirokazu Honda wrote:\n> CameraBuffer::plane() should be accessed in zero based index.\n> Fix the wrong indexing in CameraBuffer::plane() in\n> cros_camera_buffer.cpp.\n> \n> Signed-off-by: Hirokazu Honda <hiroh@chromium.org>\n\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n> ---\n>  src/android/mm/cros_camera_buffer.cpp | 6 +++---\n>  1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp\n> index 59e26d1b..c4157606 100644\n> --- a/src/android/mm/cros_camera_buffer.cpp\n> +++ b/src/android/mm/cros_camera_buffer.cpp\n> @@ -113,13 +113,13 @@ Span<uint8_t> CameraBuffer::Private::plane(unsigned int plane)\n>  \t\tbreak;\n>  \tdefault:\n>  \t\tswitch (plane) {\n> -\t\tcase 1:\n> +\t\tcase 0:\n>  \t\t\taddr = mem.ycbcr.y;\n>  \t\t\tbreak;\n> -\t\tcase 2:\n> +\t\tcase 1:\n>  \t\t\taddr = mem.ycbcr.cb;\n>  \t\t\tbreak;\n> -\t\tcase 3:\n> +\t\tcase 2:\n>  \t\t\taddr = mem.ycbcr.cr;\n>  \t\t\tbreak;\n>  \t\t}\n> -- \n> 2.32.0.272.g935e593368-goog\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 488F8C321D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 25 Jun 2021 09:14:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 25D8A684CF;\n\tFri, 25 Jun 2021 11:14:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03195684CA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 25 Jun 2021 11:14:13 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D1AF501;\n\tFri, 25 Jun 2021 11:14:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"agSXvI9y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1624612453;\n\tbh=fB6HnWbv0w2bAedASzFUlozRavU/bsVPiMgN66H/FvE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=agSXvI9yiyY2vb12rA5XK3z5fnQ3tYvn6rBlQ7B2Fj/b+WRu7HtGFL2JSwtU5PDO+\n\tT9vbG4If6mQCAR70ZdeJOo9i/kNPkVQGAp/52wd6GBfCQXRxWljPgfekOihXonhtqr\n\tSns8occegb2bDdqNniQIZlvABuEtWBHM6tl5dmQo=","Date":"Fri, 25 Jun 2021 18:14:06 +0900","From":"paul.elder@ideasonboard.com","To":"Hirokazu Honda <hiroh@chromium.org>","Message-ID":"<20210625091406.GR2599@pyrite.rasen.tech>","References":"<20210616085923.2888083-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210616085923.2888083-1-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH] android: mm: cros_camera_buffer: Fix\n\twrong indexing in plane()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]