[{"id":166,"web_url":"https://patchwork.libcamera.org/comment/166/","msgid":"<1710078.CtVnm7fWyb@avalon>","date":"2019-01-02T01:37:20","subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: Remove libcamera class","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tuesday, 1 January 2019 23:29:47 EET Kieran Bingham wrote:\n> From: Laurent Pinchart \n> \n> The class was just a placeholder, now that we have other objects\n> defined, remove it along with the associated test.\n> \n> The libcamera/libcamera.h header is kept as a shortcut to include the\n> whole libcamera public API.\n> \n> Signed-off-by: Laurent Pinchart \n> [Kieran: Rebase to master]\n> Signed-off-by: Kieran Bingham \n\nPushed to master already :-)\n\n> ---\n> include/libcamera/libcamera.h | 10 ----------\n> src/libcamera/main.cpp | 19 -------------------\n> src/libcamera/meson.build | 1 -\n> test/init.cpp | 16 ----------------\n> test/meson.build | 1 -\n> 5 files changed, 47 deletions(-)\n> delete mode 100644 src/libcamera/main.cpp\n> delete mode 100644 test/init.cpp\n> \n> diff --git a/include/libcamera/libcamera.h b/include/libcamera/libcamera.h\n> index 32fb1ff741a7..f9556a8bce62 100644\n> --- a/include/libcamera/libcamera.h\n> +++ b/include/libcamera/libcamera.h\n> @@ -10,14 +10,4 @@\n> #include \n> #include \n> \n> -namespace libcamera {\n> -\n> -class libcamera\n> -{\n> -public:\n> -\tvoid init_lib(void);\n> -};\n> -\n> -};\n> -\n> #endif /* __LIBCAMERA_LIBCAMERA_H__ */\n> diff --git a/src/libcamera/main.cpp b/src/libcamera/main.cpp\n> deleted file mode 100644\n> index 7ed37dfcfd5b..000000000000\n> --- a/src/libcamera/main.cpp\n> +++ /dev/null\n> @@ -1,19 +0,0 @@\n> -/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> -/*\n> - * Copyright (C) 2018, Google Inc.\n> - *\n> - * main.cpp - libcamera main class\n> - */\n> -\n> -#include \n> -\n> -#include \"log.h\"\n> -\n> -namespace libcamera {\n> -\n> -void libcamera::init_lib(void)\n> -{\n> -\tLOG(Info) << \"Lib Camera Init\";\n> -}\n> -\n> -};\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 2ff5bb5e7515..78562299fc42 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -3,7 +3,6 @@ libcamera_sources = files([\n> 'camera_manager.cpp',\n> 'device_enumerator.cpp',\n> 'log.cpp',\n> - 'main.cpp',\n> 'media_device.cpp',\n> 'media_object.cpp',\n> 'pipeline_handler.cpp',\n> diff --git a/test/init.cpp b/test/init.cpp\n> deleted file mode 100644\n> index 4ade4e7690fc..000000000000\n> --- a/test/init.cpp\n> +++ /dev/null\n> @@ -1,16 +0,0 @@\n> -/* SPDX-License-Identifier: GPL-2.0-or-later */\n> -/*\n> - * Copyright (C) 2018, Google Inc.\n> - *\n> - * init.cpp - libcamera initialization test\n> - */\n> -\n> -#include \n> -\n> -int main(void)\n> -{\n> -\tlibcamera::libcamera l = libcamera::libcamera();\n> -\tl.init_lib();\n> -\n> -\treturn 0;\n> -}\n> diff --git a/test/meson.build b/test/meson.build\n> index 9270a55e052a..184a7eeb5e27 100644\n> --- a/test/meson.build\n> +++ b/test/meson.build\n> @@ -3,7 +3,6 @@ subdir('libtest')\n> subdir('media_device')\n> \n> public_tests = [\n> - ['test_init', 'init.cpp'],\n> ['list', 'list.cpp'],\n> ]","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1917E600CC\n\tfor ;\n\tWed, 2 Jan 2019 02:36:24 +0100 (CET)","from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 38DA7505;\n\tWed, 2 Jan 2019 02:36:20 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546392980;\n\tbh=sX78Fnro6srkNki6WaVa1wyiCTKNDazku0jMQazxoao=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=h/9Av9XEPDmTozs71noQHrfKpGL8EbDiqszmS9AaTTUOndvvJNjYd9gvqnkoD82oo\n\t4IycxiY0zLpuwzXFKvdQ1/+epH8/0M7yMKRtrP0ecM1q3cJTwTM/n+euwPX3I0l4bw\n\t3ux7qEx/6adcAAGR17/t9EDd7UtE2FmdjrGLJYrY=","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Date":"Wed, 02 Jan 2019 03:37:20 +0200","Message-ID":"<1710078.CtVnm7fWyb@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"<20190101212947.28098-6-kieran.bingham@ideasonboard.com>","References":"<20190101212947.28098-1-kieran.bingham@ideasonboard.com>\n\t<20190101212947.28098-6-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: Remove libcamera class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 02 Jan 2019 01:36:24 -0000"}}]