[{"id":17570,"web_url":"https://patchwork.libcamera.org/comment/17570/","msgid":"","date":"2021-06-15T13:34:10","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: ipa: raspberrypi:\n\tDemote warnings about lack of AWB results","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for your patch.\n\nOn Tue, 15 Jun 2021 at 11:51, David Plowman \nwrote:\n\n> Warnings about the lack of AWB status results are demoted to being\n> just \"Debug\". With monochrome sensors becoming more common this would\n> otherwise overwhelm the console output, and in practice nothing is\n> really lost as it is normally very evident if AWB is failing to run.\n>\n> Signed-off-by: David Plowman \n>\n\nLooks good!\n\nReviewed-by: Naushir Patuck \n\n\n\n> ---\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> index 55e80ac7..2c95f287 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> @@ -481,7 +481,7 @@ void Agc::fetchAwbStatus(Metadata *image_metadata)\n> awb_.gain_g = 1.0;\n> awb_.gain_b = 1.0;\n> if (image_metadata->Get(\"awb.status\", awb_) != 0)\n> - LOG(RPiAgc, Warning) << \"Agc: no AWB status found\";\n> + LOG(RPiAgc, Debug) << \"Agc: no AWB status found\";\n> }\n>\n> static double compute_initial_Y(bcm2835_isp_stats *stats, AwbStatus const\n> &awb,\n> diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> index b0d24aa2..c58ef7d0 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> @@ -267,7 +267,7 @@ double get_ct(Metadata *metadata, double default_ct)\n> AwbStatus awb_status;\n> awb_status.temperature_K = default_ct; // in case nothing found\n> if (metadata->Get(\"awb.status\", awb_status) != 0)\n> - LOG(RPiAlsc, Warning) << \"no AWB results found, using \"\n> + LOG(RPiAlsc, Debug) << \"no AWB results found, using \"\n> << awb_status.temperature_K;\n> else\n> LOG(RPiAlsc, Debug) << \"AWB results found, using \"\n> --\n> 2.20.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3DE7BBD78E\n\tfor ;\n\tTue, 15 Jun 2021 13:34:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE68568930;\n\tTue, 15 Jun 2021 15:34:28 +0200 (CEST)","from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com\n\t[IPv6:2a00:1450:4864:20::12e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8F846029A\n\tfor ;\n\tTue, 15 Jun 2021 15:34:27 +0200 (CEST)","by mail-lf1-x12e.google.com with SMTP id p7so27110977lfg.4\n\tfor ;\n\tTue, 15 Jun 2021 06:34:27 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"GS2DhKM4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=AqLxMG6fAVRwuwG9T/H+FzkvIVSpZ9FKRBlC0OFBf8I=;\n\tb=GS2DhKM45iGxdoFEIHJ8wQLqkgIXBPMABckT/e0w1+DL4+2eNNCC65xuYNuWRw2ECK\n\tLGgjVS3tDOF4UjWB+8yWn6jSrE6Qn0U7le2uS8yRidnHBCnDR4gNe1mERed7QBzhVrAc\n\tIfr/oI9OaVjSTyMP+SY/ugAX091q0O/P7jA0Kt5sWSMAb9tDN7T5Bjgiqwyer+aTRA//\n\tSeX983vbh5A36bEg8+h3lPDGV0Nzur2vhng56KYLSEY+kKZzn0N2XMnHGl1NoeFKcO75\n\t+Nfg58N4C0GEYJrPeb4+U9DSfnUs5WUGQ/f9qYPpzV76FOa7dMiiQ6fSD6FbjV29hJy4\n\th2kw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=AqLxMG6fAVRwuwG9T/H+FzkvIVSpZ9FKRBlC0OFBf8I=;\n\tb=lcdV2ZS1jPr2+sbrD2cnulDdVkww1FLuT+NMo8hMOquqsJqOWMOHaE7SMxDpvY3xrK\n\t1Z6nloeLCoXvfVPuamEzFEhUAj9c0Q2fiwarLUiMq04x8axS1mmahwDx5zpWk7MlnHJU\n\ts+DTOz/p6uWXypOJIC/+/gvuD+sOnIOQCIseaB9Wf0/matinmbS1NuJxfI0FsfCqofqf\n\tBZ0BBAyOu0YOJXx7eDuaDpJ9MQj1YP3bjsiXv8cb9VFzOwmczLv6TROXJTQsNtE/6CgP\n\t326CP5iX3nRC4Oln31xK7FQ4stwU279BnVhsMaXH7MrqkDnc/BVwB/wgDfbLNmjtbc8W\n\tfR/A==","X-Gm-Message-State":"AOAM533ZqNspTLM99zR7IwBARsSFm8lM2pn0ri9cR/Np8YaXK+ujzK7Y\n\tQJ8vC3SK3Isaer3cSOdbcnc0BTOL3DSnod0+V1UDVQ==","X-Google-Smtp-Source":"ABdhPJw+W6aAepjeGIq/DPweVQW2kDc5ntOBDnDwC0OGuQmvCrb9BZa+4bT3DPNPWNNw8P7Ux6EzGEAAACu3lIugsC4=","X-Received":"by 2002:a05:6512:3fa5:: with SMTP id\n\tx37mr15808197lfa.617.1623764067350; \n\tTue, 15 Jun 2021 06:34:27 -0700 (PDT)","MIME-Version":"1.0","References":"<20210615105139.16171-1-david.plowman@raspberrypi.com>\n\t<20210615105139.16171-3-david.plowman@raspberrypi.com>","In-Reply-To":"<20210615105139.16171-3-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Tue, 15 Jun 2021 14:34:10 +0100","Message-ID":"","To":"David Plowman ","Content-Type":"multipart/alternative; boundary=\"0000000000006f0e3b05c4ce085f\"","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: ipa: raspberrypi:\n\tDemote warnings about lack of AWB results","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]