[{"id":17532,"web_url":"https://patchwork.libcamera.org/comment/17532/","msgid":"","date":"2021-06-14T22:28:47","subject":"Re: [libcamera-devel] [PATCH] libcamera: CameraSensorProperties:\n\tAdd test pattern mode of imx258","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the patch.\n\nOn Mon, Jun 14, 2021 at 09:22:15PM +0900, Hirokazu Honda wrote:\n> Add supported test pattern modes of imx258 in CameraSensorProperties.\n\nBased on the V4L2 driver, this looks correct. I don't have access to the\ndatasheet, so I can't perform further checks.\n\n> Signed-off-by: Hirokazu Honda \n> ---\n> src/libcamera/camera_sensor_properties.cpp | 8 +++++++-\n> 1 file changed, 7 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index f660743a..afa59b82 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -65,7 +65,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t{ \"imx258\", {\n> \t\t\t.unitCellSize = { 1120, 1120 },\n> \t\t\t/* \\todo fill test pattern modes for imx258. */\n\nThis should be dropped.\n\n> -\t\t\t.testPatternModes = {},\n> +\t\t\t.testPatternModes = {\n> +\t\t\t\t{0, controls::draft::TestPatternModeOff },\n> +\t\t\t\t{1, controls::draft::TestPatternModeSolidColor},\n> +\t\t\t\t{2, controls::draft::TestPatternModeColorBars},\n> +\t\t\t\t{3, controls::draft::TestPatternModeColorBarsFadeToGray},\n> +\t\t\t\t{4, controls::draft::TestPatternModePn9},\n\nMissing spaces after { and before }.\n\nI'll fix this when applying.\n\nReviewed-by: Laurent Pinchart \n\n> +\t\t\t},\n> \t\t} },\n> \t\t{ \"ov5670\", {\n> \t\t\t.unitCellSize = { 1120, 1120 },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D96AC3218\n\tfor ;\n\tMon, 14 Jun 2021 22:29:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ACEC76892B;\n\tTue, 15 Jun 2021 00:29:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66788687EF\n\tfor ;\n\tTue, 15 Jun 2021 00:29:08 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CCD7245E;\n\tTue, 15 Jun 2021 00:29:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U8fXHHHX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623709748;\n\tbh=n1yOjIj3GeDYTUu8leHDswM5R8HD4J9rlsktynj5OZs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=U8fXHHHXvipNQN5GI9o3794FK/akpEBDlgANNAhQP8YTsKNMZlSCD7b131zg8ygMD\n\tZfNL3zBFYTqh/71UNmpfASBqNxmdYEj3OUTK5w5ViV8NqlDXGONLc7Ug57Vs90lRpq\n\tcqc2LbpyQahl1B+y/u4L0YRZx1wTfnTPH2UXu3Mo=","Date":"Tue, 15 Jun 2021 01:28:47 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210614122215.510562-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210614122215.510562-1-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: CameraSensorProperties:\n\tAdd test pattern mode of imx258","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]