[{"id":17534,"web_url":"https://patchwork.libcamera.org/comment/17534/","msgid":"","date":"2021-06-14T22:44:12","subject":"Re: [libcamera-devel] [RFC PATCH] android: camera_device: Drop\n\tHAL_PIXEL_FORMAT_RAW_OPAQUE support","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the patch.\n\nOn Mon, Jun 14, 2021 at 07:45:53PM +0900, Hirokazu Honda wrote:\n> HAL_PIXEL_FORMAT_RAW_OPAQUE is requested only for\n> Zero-Shutter-Lag (ZSL). ZSL requires RAW and YUV reprocessing.\n> Since either of them is not supported by libcamera, supporting\n> RAW_OPAQUE format doesn't make sense. Drop the format from the\n> supported format list.\n> \n> Signed-off-by: Hirokazu Honda \n\nThis looks sensible to me. Given that the formats below are specific to\nthe IPU3, the code would need to be reworked when we'll implement ZSL\nsupport anyway.\n\nReviewed-by: Laurent Pinchart \n\nI'll wait for a second tag before merging.\n\n> ---\n> src/android/camera_device.cpp | 11 -----------\n> 1 file changed, 11 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index fe332ec3..14022aed 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -120,17 +120,6 @@ const std::map camera3FormatsMap = {\n> \t\t\tfalse,\n> \t\t\t\"RAW16\"\n> \t\t}\n> -\t}, {\n> -\t\tHAL_PIXEL_FORMAT_RAW_OPAQUE, {\n> -\t\t\t{\n> -\t\t\t\tformats::SBGGR10_IPU3,\n> -\t\t\t\tformats::SGBRG10_IPU3,\n> -\t\t\t\tformats::SGRBG10_IPU3,\n> -\t\t\t\tformats::SRGGB10_IPU3\n> -\t\t\t},\n> -\t\t\tfalse,\n> -\t\t\t\"RAW_OPAQUE\"\n> -\t\t}\n> \t},\n> };\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32AF0C3218\n\tfor ;\n\tMon, 14 Jun 2021 22:44:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A9771687EF;\n\tTue, 15 Jun 2021 00:44:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F0EA687EF\n\tfor ;\n\tTue, 15 Jun 2021 00:44:33 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E875445E;\n\tTue, 15 Jun 2021 00:44:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J8h6Af62\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623710673;\n\tbh=6GlKQVwwZNHybRMw+b3V2xxJ0aHANiGamzlX0RwpHjo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=J8h6Af62Os4Azrs/eAHB6m7lRvDgJyFbVBFO/7/LMmDvwrIbnRo8QLYjzFMj2i89/\n\t98rH9AKsUh1Cq9lj/jA31Ppqmx11JD3RUYJAvxcgKDnDl6Qs8CVxESJJj7i+21gbuI\n\tfDdWGZPzN7yoSo15meLY7UkRpPzHc4wy+eG5fA/Q=","Date":"Tue, 15 Jun 2021 01:44:12 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210614104553.497626-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210614104553.497626-1-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [RFC PATCH] android: camera_device: Drop\n\tHAL_PIXEL_FORMAT_RAW_OPAQUE support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17555,"web_url":"https://patchwork.libcamera.org/comment/17555/","msgid":"","date":"2021-06-15T07:44:24","subject":"Re: [libcamera-devel] [RFC PATCH] android: camera_device: Drop\n\tHAL_PIXEL_FORMAT_RAW_OPAQUE support","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent,\n\nOn Tue, Jun 15, 2021 at 7:44 AM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Hiro,\n>\n> Thank you for the patch.\n>\n> On Mon, Jun 14, 2021 at 07:45:53PM +0900, Hirokazu Honda wrote:\n> > HAL_PIXEL_FORMAT_RAW_OPAQUE is requested only for\n> > Zero-Shutter-Lag (ZSL). ZSL requires RAW and YUV reprocessing.\n> > Since either of them is not supported by libcamera, supporting\n> > RAW_OPAQUE format doesn't make sense. Drop the format from the\n> > supported format list.\n> >\n> > Signed-off-by: Hirokazu Honda \n>\n> This looks sensible to me. Given that the formats below are specific to\n> the IPU3, the code would need to be reworked when we'll implement ZSL\n> support anyway.\n>\n>\nJust note:\nFor ZSL capture request, the format is either RAW_OPAQUE or\nIMPLEMENTATION_DEFINED.\nIn ChromeOS, IMPLEMENTATION_DEFINED is used for ZSL.\nBesides, gralloc implementation in ChromeOS doesn't support RAW_OPAQUE.\nSo we should not list this format in supported formats at least in ChromeOS.\nWe may want to support RAW_OPAQUE for other platforms though.\n\n-Hiro\n\n> Reviewed-by: Laurent Pinchart \n>\n> I'll wait for a second tag before merging.\n>\n> > ---\n> > src/android/camera_device.cpp | 11 -----------\n> > 1 file changed, 11 deletions(-)\n> >\n> > diff --git a/src/android/camera_device.cpp\n> b/src/android/camera_device.cpp\n> > index fe332ec3..14022aed 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -120,17 +120,6 @@ const std::map\n> camera3FormatsMap = {\n> > false,\n> > \"RAW16\"\n> > }\n> > - }, {\n> > - HAL_PIXEL_FORMAT_RAW_OPAQUE, {\n> > - {\n> > - formats::SBGGR10_IPU3,\n> > - formats::SGBRG10_IPU3,\n> > - formats::SGRBG10_IPU3,\n> > - formats::SRGGB10_IPU3\n> > - },\n> > - false,\n> > - \"RAW_OPAQUE\"\n> > - }\n> > },\n> > };\n> >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 276F9BD78E\n\tfor ;\n\tTue, 15 Jun 2021 07:44:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 94F7C68943;\n\tTue, 15 Jun 2021 09:44:37 +0200 (CEST)","from mail-ej1-x633.google.com (mail-ej1-x633.google.com\n\t[IPv6:2a00:1450:4864:20::633])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4B2260299\n\tfor ;\n\tTue, 15 Jun 2021 09:44:35 +0200 (CEST)","by mail-ej1-x633.google.com with SMTP id nb6so758750ejc.10\n\tfor ;\n\tTue, 15 Jun 2021 00:44:35 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"ISwLAXND\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=WCMQgi5ICRdBXDTV98mRtZsZMC4zp+akMyl+LqXHtNQ=;\n\tb=ISwLAXNDemmnXseK0qVtyt/jPbeqnHgs1LgqbMofceWYqBBzdFnqGn8RimoM9IdgCV\n\tDh5kkQLnPTpiTG1QONtoxeNifEBmnOmhFNdkHpESxinbfOFqFmY3OzWVoRBKrKGg4rtr\n\tKR47VlFzwrKM4++Cb1fOojKd/Uw2cAkppyxxw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=WCMQgi5ICRdBXDTV98mRtZsZMC4zp+akMyl+LqXHtNQ=;\n\tb=GOgHR0pZCy2pSUelnduPRJAgO+80Ab7G9W0olJWAgXm5+r1f7oYbebI1nnAZ9StnWA\n\txYI6rys6CmPdG7sF/WGLQ00UPti8hfEL3kxyWdzDGRsKPfSisodEEz0GfuTuqRIc/QP8\n\tOOeMb2hXtL4elXXMFFc2QbJVCu+pxGSOL449zb9nEFSehjSOJ78FSC4tncBVmNWxVje2\n\tCr0IUngUpOieMGpOfaqpzymVKXwFkp4T0NJQtZ+E0mtbBS1QH60lKSm6fzZfj5vEMPsP\n\tKK4atZR0FzKqwqs4IVrNba0i+eHBWHMocIkGdTOt46Sx5N1rWATn7e1mVm26Ss9WErG0\n\tE44g==","X-Gm-Message-State":"AOAM530ZsvykRa0IUZJN30bOpw+Lp4BiuIpEo93lxON75sOyot0yYj+J\n\t5/goMVFG3TMn7rf/6jimabIRwP31P2DJm3lTL2Cq+0EQy6x0KA==","X-Google-Smtp-Source":"ABdhPJyJWv22VEiGkSF2xKworaPI+m0/qylO/ZR0o7kJ1J1ZLe34G+Iom3S0SYP2HlNoVcZUl62orcqRI8KNR4JaABI=","X-Received":"by 2002:a17:906:dbd8:: with SMTP id\n\tyc24mr731742ejb.55.1623743075323; \n\tTue, 15 Jun 2021 00:44:35 -0700 (PDT)","MIME-Version":"1.0","References":"<20210614104553.497626-1-hiroh@chromium.org>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Tue, 15 Jun 2021 16:44:24 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"000000000000361e4605c4c925ae\"","Subject":"Re: [libcamera-devel] [RFC PATCH] android: camera_device: Drop\n\tHAL_PIXEL_FORMAT_RAW_OPAQUE support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17556,"web_url":"https://patchwork.libcamera.org/comment/17556/","msgid":"<20210615074610.gahotpcyvvbruraw@uno.localdomain>","date":"2021-06-15T07:46:10","subject":"Re: [libcamera-devel] [RFC PATCH] android: camera_device: Drop\n\tHAL_PIXEL_FORMAT_RAW_OPAQUE support","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hello,\n\nOn Tue, Jun 15, 2021 at 01:44:12AM +0300, Laurent Pinchart wrote:\n> Hi Hiro,\n>\n> Thank you for the patch.\n>\n> On Mon, Jun 14, 2021 at 07:45:53PM +0900, Hirokazu Honda wrote:\n> > HAL_PIXEL_FORMAT_RAW_OPAQUE is requested only for\n> > Zero-Shutter-Lag (ZSL). ZSL requires RAW and YUV reprocessing.\n> > Since either of them is not supported by libcamera, supporting\n> > RAW_OPAQUE format doesn't make sense. Drop the format from the\n> > supported format list.\n> >\n> > Signed-off-by: Hirokazu Honda \n>\n> This looks sensible to me. Given that the formats below are specific to\n> the IPU3, the code would need to be reworked when we'll implement ZSL\n> support anyway.\n>\n> Reviewed-by: Laurent Pinchart \n>\n> I'll wait for a second tag before merging.\n\nHave mine\nReviewed-by: Jacopo Mondi \n\nThose are IPU3 specific formats, not sure they belong here\n\n>\n> > ---\n> > src/android/camera_device.cpp | 11 -----------\n> > 1 file changed, 11 deletions(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index fe332ec3..14022aed 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -120,17 +120,6 @@ const std::map camera3FormatsMap = {\n> > \t\t\tfalse,\n> > \t\t\t\"RAW16\"\n> > \t\t}\n> > -\t}, {\n> > -\t\tHAL_PIXEL_FORMAT_RAW_OPAQUE, {\n> > -\t\t\t{\n> > -\t\t\t\tformats::SBGGR10_IPU3,\n> > -\t\t\t\tformats::SGBRG10_IPU3,\n> > -\t\t\t\tformats::SGRBG10_IPU3,\n> > -\t\t\t\tformats::SRGGB10_IPU3\n> > -\t\t\t},\n> > -\t\t\tfalse,\n> > -\t\t\t\"RAW_OPAQUE\"\n> > -\t\t}\n> > \t},\n> > };\n> >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 85DD9BD78E\n\tfor ;\n\tTue, 15 Jun 2021 07:45:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3175A68943;\n\tTue, 15 Jun 2021 09:45:22 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 104B360299\n\tfor ;\n\tTue, 15 Jun 2021 09:45:21 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 38690C000F;\n\tTue, 15 Jun 2021 07:45:19 +0000 (UTC)"],"Date":"Tue, 15 Jun 2021 09:46:10 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210615074610.gahotpcyvvbruraw@uno.localdomain>","References":"<20210614104553.497626-1-hiroh@chromium.org>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [RFC PATCH] android: camera_device: Drop\n\tHAL_PIXEL_FORMAT_RAW_OPAQUE support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17564,"web_url":"https://patchwork.libcamera.org/comment/17564/","msgid":"","date":"2021-06-15T10:04:33","subject":"Re: [libcamera-devel] [RFC PATCH] android: camera_device: Drop\n\tHAL_PIXEL_FORMAT_RAW_OPAQUE support","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nOn Tue, Jun 15, 2021 at 04:44:24PM +0900, Hirokazu Honda wrote:\n> On Tue, Jun 15, 2021 at 7:44 AM Laurent Pinchart wrote:\n> > On Mon, Jun 14, 2021 at 07:45:53PM +0900, Hirokazu Honda wrote:\n> > > HAL_PIXEL_FORMAT_RAW_OPAQUE is requested only for\n> > > Zero-Shutter-Lag (ZSL). ZSL requires RAW and YUV reprocessing.\n> > > Since either of them is not supported by libcamera, supporting\n> > > RAW_OPAQUE format doesn't make sense. Drop the format from the\n> > > supported format list.\n> > >\n> > > Signed-off-by: Hirokazu Honda \n> >\n> > This looks sensible to me. Given that the formats below are specific to\n> > the IPU3, the code would need to be reworked when we'll implement ZSL\n> > support anyway.\n>\n> Just note:\n> For ZSL capture request, the format is either RAW_OPAQUE or\n> IMPLEMENTATION_DEFINED.\n\nWhat's the practical difference between the two ? I'd expect both to map\nto the same opaque, device-specific RAW format.\n\n> In ChromeOS, IMPLEMENTATION_DEFINED is used for ZSL.\n> Besides, gralloc implementation in ChromeOS doesn't support RAW_OPAQUE.\n> So we should not list this format in supported formats at least in ChromeOS.\n> We may want to support RAW_OPAQUE for other platforms though.\n\nIs there a reason why minigbm couldn't support RAW_OPAQUE ?\n\n> > Reviewed-by: Laurent Pinchart \n> >\n> > I'll wait for a second tag before merging.\n> >\n> > > ---\n> > > src/android/camera_device.cpp | 11 -----------\n> > > 1 file changed, 11 deletions(-)\n> > >\n> > > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > > index fe332ec3..14022aed 100644\n> > > --- a/src/android/camera_device.cpp\n> > > +++ b/src/android/camera_device.cpp\n> > > @@ -120,17 +120,6 @@ const std::map camera3FormatsMap = {\n> > > false,\n> > > \"RAW16\"\n> > > }\n> > > - }, {\n> > > - HAL_PIXEL_FORMAT_RAW_OPAQUE, {\n> > > - {\n> > > - formats::SBGGR10_IPU3,\n> > > - formats::SGBRG10_IPU3,\n> > > - formats::SGRBG10_IPU3,\n> > > - formats::SRGGB10_IPU3\n> > > - },\n> > > - false,\n> > > - \"RAW_OPAQUE\"\n> > > - }\n> > > },\n> > > };\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7B6C2BD78E\n\tfor ;\n\tTue, 15 Jun 2021 10:04:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3D38160297;\n\tTue, 15 Jun 2021 12:04:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8917E60297\n\tfor ;\n\tTue, 15 Jun 2021 12:04:55 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B6251436;\n\tTue, 15 Jun 2021 12:04:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JX7OTej5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623751495;\n\tbh=zhY8lGUubedSq36A0AGuwIlGEkY+Dpbxehz2luhb3T4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JX7OTej5B1Sx09wQnsjcTP/VPvJPNzFM4PAaWlnR+Xdmz5UmP0Uq9L937LtuKgBUO\n\t4sNlLCfngUPSqKKGbDUMIRLXG2ETjrARCGmFGO/3or04PHJUL0wOH1+Rf2pZOjJ5cf\n\tCT4nzjyxbXwNllaFNRu67neGlhAXeg27rCZaXxkc=","Date":"Tue, 15 Jun 2021 13:04:33 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210614104553.497626-1-hiroh@chromium.org>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [RFC PATCH] android: camera_device: Drop\n\tHAL_PIXEL_FORMAT_RAW_OPAQUE support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17566,"web_url":"https://patchwork.libcamera.org/comment/17566/","msgid":"","date":"2021-06-15T10:15:39","subject":"Re: [libcamera-devel] [RFC PATCH] android: camera_device: Drop\n\tHAL_PIXEL_FORMAT_RAW_OPAQUE support","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent,\n\nOn Tue, Jun 15, 2021 at 7:04 PM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Hiro,\n>\n> On Tue, Jun 15, 2021 at 04:44:24PM +0900, Hirokazu Honda wrote:\n> > On Tue, Jun 15, 2021 at 7:44 AM Laurent Pinchart wrote:\n> > > On Mon, Jun 14, 2021 at 07:45:53PM +0900, Hirokazu Honda wrote:\n> > > > HAL_PIXEL_FORMAT_RAW_OPAQUE is requested only for\n> > > > Zero-Shutter-Lag (ZSL). ZSL requires RAW and YUV reprocessing.\n> > > > Since either of them is not supported by libcamera, supporting\n> > > > RAW_OPAQUE format doesn't make sense. Drop the format from the\n> > > > supported format list.\n> > > >\n> > > > Signed-off-by: Hirokazu Honda \n> > >\n> > > This looks sensible to me. Given that the formats below are specific to\n> > > the IPU3, the code would need to be reworked when we'll implement ZSL\n> > > support anyway.\n> >\n> > Just note:\n> > For ZSL capture request, the format is either RAW_OPAQUE or\n> > IMPLEMENTATION_DEFINED.\n>\n> What's the practical difference between the two ? I'd expect both to map\n> to the same opaque, device-specific RAW format.\n>\n>\n+Tomasz Figa \n\nI am not sure honestly as it is not documented anywhere.\nChromeOS camera people told me that RAW_OPAQUE is optional to support and\nmeant for vendor app use only.\nOnly IMPLEMENTATION_DEFINED needs to be supported for PRIVATE reprocessing.\n\n\n> > In ChromeOS, IMPLEMENTATION_DEFINED is used for ZSL.\n> > Besides, gralloc implementation in ChromeOS doesn't support RAW_OPAQUE.\n> > So we should not list this format in supported formats at least in\n> ChromeOS.\n> > We may want to support RAW_OPAQUE for other platforms though.\n>\n> Is there a reason why minigbm couldn't support RAW_OPAQUE ?\n>\n>\nIt must be because we don't use the RAW_OPAQUE buffer.\nThus we don't need to support it at all.\n\n-Hiro\n\n> > > Reviewed-by: Laurent Pinchart \n> > >\n> > > I'll wait for a second tag before merging.\n> > >\n> > > > ---\n> > > > src/android/camera_device.cpp | 11 -----------\n> > > > 1 file changed, 11 deletions(-)\n> > > >\n> > > > diff --git a/src/android/camera_device.cpp\n> b/src/android/camera_device.cpp\n> > > > index fe332ec3..14022aed 100644\n> > > > --- a/src/android/camera_device.cpp\n> > > > +++ b/src/android/camera_device.cpp\n> > > > @@ -120,17 +120,6 @@ const std::map\n> camera3FormatsMap = {\n> > > > false,\n> > > > \"RAW16\"\n> > > > }\n> > > > - }, {\n> > > > - HAL_PIXEL_FORMAT_RAW_OPAQUE, {\n> > > > - {\n> > > > - formats::SBGGR10_IPU3,\n> > > > - formats::SGBRG10_IPU3,\n> > > > - formats::SGRBG10_IPU3,\n> > > > - formats::SRGGB10_IPU3\n> > > > - },\n> > > > - false,\n> > > > - \"RAW_OPAQUE\"\n> > > > - }\n> > > > },\n> > > > };\n> > > >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 38209BD78E\n\tfor ;\n\tTue, 15 Jun 2021 10:15:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EBFA268942;\n\tTue, 15 Jun 2021 12:15:51 +0200 (CEST)","from mail-ed1-x534.google.com (mail-ed1-x534.google.com\n\t[IPv6:2a00:1450:4864:20::534])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B50F16029D\n\tfor ;\n\tTue, 15 Jun 2021 12:15:50 +0200 (CEST)","by mail-ed1-x534.google.com with SMTP id s15so9421450edt.13\n\tfor ;\n\tTue, 15 Jun 2021 03:15:50 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"iovSVlB0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=fear738nv/ugwdlCJv5VAZR05ZNG+2UG8za5tyBqVKQ=;\n\tb=iovSVlB0H+eBAsB3Igz3l6i//QYYplMC1UdJuyTMqFVYjaHH9dc2lU0QQUw9L9DH2b\n\tr5NZpg7er4zZSXn6oWwIR5s2RWCj/xuC4JzjP/BK7sZ5bzMVS/HAT2uDRBMfnlONHX9O\n\tJRi7iSKBx6/rXoFHrJ7LQuUFnWMd7QwAbCXRE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=fear738nv/ugwdlCJv5VAZR05ZNG+2UG8za5tyBqVKQ=;\n\tb=EtkzTUYTx2QPgste37l0ctbr6282xCvtLK8dG9RkuqXbzNSEaZQO7lpooeeVkcAGJq\n\tapEM9ZQx3TuCRP0ElPCW5W1uOJXfR3lFXmTww2MY3JfhxtvgxAwW99A5+PfMXMwV71R9\n\tnIXHBpFRkHfCzhkAJx4P0r6m8BAkGCXfXCyVT1CNJRzlvJr5/RTHAOTS6+45dUm36NLC\n\tyqgI9v1szR3ZoKyPtsZgNPBEzPJDanWNWidtWuH60m2DacfD92kPJbY1GgWml4PHmf2U\n\t5yRX0nh6OduMKjYC/pX/3Ik3RI9swLzjYDdvM9NrJelwsUNf9dfrYVgzUoD9GkheOBDw\n\tmH1w==","X-Gm-Message-State":"AOAM532R6NZZRZLqUnTjv+9a0iQvZOzaM4UWkZrOYZBAuNUysVu23Bng\n\to/uDRGbWLb0nY+L90bUOub6hL4jfkVLFyng5sEFbog==","X-Google-Smtp-Source":"ABdhPJx8/AlZ9e626vCf59lyrl4NyJVukSy7Kw7bjSzZuDMNMN5uz5gdEtLxRQsUMZWUEt6O8+p3JldPVOR/WXifgWs=","X-Received":"by 2002:a05:6402:524b:: with SMTP id\n\tt11mr22823207edd.327.1623752150400; \n\tTue, 15 Jun 2021 03:15:50 -0700 (PDT)","MIME-Version":"1.0","References":"<20210614104553.497626-1-hiroh@chromium.org>\n\t\n\t\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Tue, 15 Jun 2021 19:15:39 +0900","Message-ID":"","To":"Laurent Pinchart ,\n\tTomasz Figa ","Content-Type":"multipart/alternative; boundary=\"00000000000020d55e05c4cb42ae\"","Subject":"Re: [libcamera-devel] [RFC PATCH] android: camera_device: Drop\n\tHAL_PIXEL_FORMAT_RAW_OPAQUE support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]