[{"id":17572,"web_url":"https://patchwork.libcamera.org/comment/17572/","msgid":"","date":"2021-06-15T13:36:46","subject":"Re: [libcamera-devel] [PATCH 4/4] ipa: raspberrypi: Make variable\n\tnames consistent","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for this patch!\n\nOn Mon, 14 Jun 2021 at 11:00, Naushir Patuck wrote:\n>\n> s/DefaultAnalogueGain/defaultAnalogueGain/\n> s/DefaultExposureTime/defaultExposureTime/\n>\n> Change these for consistency with the other static const variables.\n>\n> Signed-off-by: Naushir Patuck \n\nReviewed-by: David Plowman \n\nThanks\nDavid\n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 8a8e9c0a52ab..e15d49e49645 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -58,8 +58,8 @@ using namespace std::literals::chrono_literals;\n> using utils::Duration;\n>\n> /* Configure the sensor with these values initially. */\n> -constexpr double DefaultAnalogueGain = 1.0;\n> -constexpr Duration DefaultExposureTime = 20.0ms;\n> +constexpr double defaultAnalogueGain = 1.0;\n> +constexpr Duration defaultExposureTime = 20.0ms;\n> constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;\n> constexpr Duration defaultMaxFrameDuration = 250.0s;\n>\n> @@ -389,8 +389,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo,\n> /* Supply initial values for gain and exposure. */\n> ControlList ctrls(sensorCtrls_);\n> AgcStatus agcStatus;\n> - agcStatus.shutter_time = DefaultExposureTime;\n> - agcStatus.analogue_gain = DefaultAnalogueGain;\n> + agcStatus.shutter_time = defaultExposureTime;\n> + agcStatus.analogue_gain = defaultAnalogueGain;\n> applyAGC(&agcStatus, ctrls);\n>\n> ASSERT(controls);\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 487F5C3219\n\tfor ;\n\tTue, 15 Jun 2021 13:36:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0299968943;\n\tTue, 15 Jun 2021 15:36:59 +0200 (CEST)","from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6CC6B6029D\n\tfor ;\n\tTue, 15 Jun 2021 15:36:58 +0200 (CEST)","by mail-wm1-x32b.google.com with SMTP id\n\tk5-20020a05600c1c85b02901affeec3ef8so1831377wms.0\n\tfor ;\n\tTue, 15 Jun 2021 06:36:58 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"mB4gyQ3V\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=DYHzVqE5wHDvYL81Uz6Yge7dB8KqFuT3FKALPTOzfNA=;\n\tb=mB4gyQ3ViKBqK8WwOaLjNy9e3jvbiCCgx/MItjPNSAMjPpxluBzbxgjZW7o+iocUj+\n\tP5fT+UYNyggt8sZV7mQV59CyT9pSJ7V+u1/Vix23JnDO3DxYapcfT7j9lTgHze4PH41m\n\th3BUPIClth9k2A5SJKk9E/eimRT3elcOD3MQEtWr4+5Q9j/6eEMa/bKhwNUO8jhxDC2H\n\tpf6oJE+JeCWfAQTFusPYI1Bg8jmo1z1J1atl51a3wbPEiIyeDxDzj2ZGlykogXJqKNWT\n\teVPMsEbXf3/yX6AxAuEYQM+wObe6w4rjAmA4WDINJVo19ogkAk1O7ONe2qM3E/LuSykL\n\tkRAA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=DYHzVqE5wHDvYL81Uz6Yge7dB8KqFuT3FKALPTOzfNA=;\n\tb=Gz5m9fEy+EwVT77MApovAXwwT3YxQD9tKOGGUmMIjYsVjLoHMiZVBSYcvy5itTSBSH\n\tMvbJvp+RnHFwB6p4nOLO3WVbg12N4Rz6o3PyLhdn81cWG2MBK8F1+k2WENDiMKw4Uk0I\n\tlgu6PJAoEXMb0tWnAgZ1RzMLaRzYYV9rBCWWLNmHLgcABk6jBCBH6a/4zezHg9BGO7Dz\n\tZvzQMriyZAO6CxtAInyNiCBGoghMrX+16zYDe4KVKuHedlpvR1dBffyvsBO+PqKKl5S+\n\tjrUxFWJ8kUplGV2LbGrgajM4K4EciaBCg079GPk2iLNHoqfurCXOF4yik/l21zk5qEcg\n\tFKVQ==","X-Gm-Message-State":"AOAM532Gxna5RTZHfmuwzBecEF9g/7a6UL8IoThH1IcDu6yw1eU0v24M\n\ta0VEoPPG8j+GwxgXl/QhM1zQ8nucn+jCKhaNkEAWSw==","X-Google-Smtp-Source":"ABdhPJyNJri2GNY3StFHxgOJHZJgW6s5L6Av4gp6tUXdnCGDtslP/oSnJ2wSDd/Tcy3yyQUBNp+Fn6EKxijga7Au7io=","X-Received":"by 2002:a05:600c:4f09:: with SMTP id\n\tl9mr5430030wmq.114.1623764218202; \n\tTue, 15 Jun 2021 06:36:58 -0700 (PDT)","MIME-Version":"1.0","References":"<20210614100040.3054433-1-naush@raspberrypi.com>\n\t<20210614100040.3054433-5-naush@raspberrypi.com>","In-Reply-To":"<20210614100040.3054433-5-naush@raspberrypi.com>","From":"David Plowman ","Date":"Tue, 15 Jun 2021 14:36:46 +0100","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 4/4] ipa: raspberrypi: Make variable\n\tnames consistent","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]