{"id":12590,"url":"https://patchwork.libcamera.org/api/patches/12590/?format=json","web_url":"https://patchwork.libcamera.org/patch/12590/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210614100040.3054433-5-naush@raspberrypi.com>","date":"2021-06-14T10:00:40","name":"[libcamera-devel,4/4] ipa: raspberrypi: Make variable names consistent","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f31a50c0338dff5ce2c47fc852d5e1f000206f7f","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12590/mbox/","series":[{"id":2129,"url":"https://patchwork.libcamera.org/api/series/2129/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2129","date":"2021-06-14T10:00:36","name":"Raspberry Pi: Enable imx477 long exposure modes","version":1,"mbox":"https://patchwork.libcamera.org/series/2129/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12590/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12590/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F4C9BD78E\n\tfor ;\n\tMon, 14 Jun 2021 10:00:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F62868932;\n\tMon, 14 Jun 2021 12:00:52 +0200 (CEST)","from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n\t[IPv6:2a00:1450:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5041768939\n\tfor ;\n\tMon, 14 Jun 2021 12:00:49 +0200 (CEST)","by mail-wm1-x32e.google.com with SMTP id g204so11760254wmf.5\n\tfor ;\n\tMon, 14 Jun 2021 03:00:49 -0700 (PDT)","from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:fd93:d554:2dff:83ca])\n\tby smtp.gmail.com with ESMTPSA id\n\t89sm16235959wrq.14.2021.06.14.03.00.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 14 Jun 2021 03:00:48 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"MMnrpBIQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=BbEDq3QFhNs6q2Yo/EM3SLXoECkNfP5qpJtL0OjICrc=;\n\tb=MMnrpBIQ/k5aPK2T3eRenoR7To5f4+CykiuE3yFY/hBmusAF04+it1bPtSGReoD/aP\n\tiXVSUTuz88Fnp41iwo/TXakD9Pl3FezecaM2BMXdgC94S68iCLyEkxrUquxmTh/p1Yor\n\tUGSLmwrjZp30L5fhFbJitCNSFsUkkITyS3jUpIp1433CJd75kJmWFPS61nfGQ4bk0XD2\n\t3qXKE/jcdVUxs1cUhrWncmN6gtGXKH5CLP1pJ0B4W/uKgYCYV0V+XFzOPhld5CrQL2Vw\n\tDh2qhTMA+/Vn8zGpawNOmN68aa9iO0sgNGF6UmgMuRuTtNFd3pmhusZOjFvcNRJfK0nr\n\t9XHw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=BbEDq3QFhNs6q2Yo/EM3SLXoECkNfP5qpJtL0OjICrc=;\n\tb=VU4WVQZk4i5l84XCXpsGh37vwD+7eU4fOwrkrniwFVStnEEZ5DbLDLsQy2jhbjzqfB\n\tsLgXqIWa06pUsTYw12VO+mqlUZOwh0GWg4atsonGxEPcrAH+/8ZQ9MT1EJkYDqrSjr6c\n\tiglZXTXf4sUDHrCfw51T2jHAGe9//ypj7Yy5f49/dF2FN+YRHsqzGmiQKjc1eJWoyZVP\n\tS3g41pFDN1CRr0od6WIO6zlSr1NONVH5HSAPLytAzu46f1n19ElRAkLFRdFIQTC2pj2i\n\tf93juI9JU7r5MqVpmsVOYGFvHDCNKVQQzXUiawUFt9Gl504lGK+mIQAed7ki3jB14QVi\n\tSWdw==","X-Gm-Message-State":"AOAM5307hvFCM8LccMXdy/NVcpqYLPfW34YxT79UMii+NRJCGAlIB42c\n\toDwbZqLLIdvu1i6nQd8zYwjukbtAoLql+w==","X-Google-Smtp-Source":"ABdhPJxR3oB/19Ug8cHU4DbV/ejq37MI/B7OmYQOGVAEftWS4nBrCAjaV/ojmz9CLaEseOqxdzi10w==","X-Received":"by 2002:a05:600c:3594:: with SMTP id\n\tp20mr29412156wmq.52.1623664848795; \n\tMon, 14 Jun 2021 03:00:48 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 14 Jun 2021 11:00:40 +0100","Message-Id":"<20210614100040.3054433-5-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210614100040.3054433-1-naush@raspberrypi.com>","References":"<20210614100040.3054433-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 4/4] ipa: raspberrypi: Make variable names\n\tconsistent","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"s/DefaultAnalogueGain/defaultAnalogueGain/\ns/DefaultExposureTime/defaultExposureTime/\n\nChange these for consistency with the other static const variables.\n\nSigned-off-by: Naushir Patuck \n---\n src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 8a8e9c0a52ab..e15d49e49645 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -58,8 +58,8 @@ using namespace std::literals::chrono_literals;\n using utils::Duration;\n \n /* Configure the sensor with these values initially. */\n-constexpr double DefaultAnalogueGain = 1.0;\n-constexpr Duration DefaultExposureTime = 20.0ms;\n+constexpr double defaultAnalogueGain = 1.0;\n+constexpr Duration defaultExposureTime = 20.0ms;\n constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;\n constexpr Duration defaultMaxFrameDuration = 250.0s;\n \n@@ -389,8 +389,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo,\n \t\t/* Supply initial values for gain and exposure. */\n \t\tControlList ctrls(sensorCtrls_);\n \t\tAgcStatus agcStatus;\n-\t\tagcStatus.shutter_time = DefaultExposureTime;\n-\t\tagcStatus.analogue_gain = DefaultAnalogueGain;\n+\t\tagcStatus.shutter_time = defaultExposureTime;\n+\t\tagcStatus.analogue_gain = defaultAnalogueGain;\n \t\tapplyAGC(&agcStatus, ctrls);\n \n \t\tASSERT(controls);\n","prefixes":["libcamera-devel","4/4"]}