[{"id":17571,"web_url":"https://patchwork.libcamera.org/comment/17571/","msgid":"","date":"2021-06-15T13:36:45","subject":"Re: [libcamera-devel] [PATCH 3/4] ipa: raspberrypi: Increase the\n\tdefault max frame duration to 250s","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the patch.\n\nOn Mon, 14 Jun 2021 at 11:00, Naushir Patuck wrote:\n>\n> With the recent change to allow long exposures on the imx477, the existing 100s\n> limit was not adequate.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 1c1e802a2cdc..8a8e9c0a52ab 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -61,7 +61,7 @@ using utils::Duration;\n> constexpr double DefaultAnalogueGain = 1.0;\n> constexpr Duration DefaultExposureTime = 20.0ms;\n> constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;\n> -constexpr Duration defaultMaxFrameDuration = 100.0s;\n> +constexpr Duration defaultMaxFrameDuration = 250.0s;\n\nReviewed-by: David Plowman \n\nThanks!\nDavid\n\n>\n> /*\n> * Determine the minimum allowable inter-frame duration to run the controller\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E00DDC3218\n\tfor ;\n\tTue, 15 Jun 2021 13:36:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9EBEB68930;\n\tTue, 15 Jun 2021 15:36:58 +0200 (CEST)","from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com\n\t[IPv6:2a00:1450:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50FE56029A\n\tfor ;\n\tTue, 15 Jun 2021 15:36:57 +0200 (CEST)","by mail-wr1-x42e.google.com with SMTP id c9so18375955wrt.5\n\tfor ;\n\tTue, 15 Jun 2021 06:36:57 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"el5l2f9f\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=yDE4qwe7xQ4AgwDAAl9Bb5J8KFPV47YgtaLZwg1xSJY=;\n\tb=el5l2f9fCUYbl/Qaif8Rr7zNfMMlfoioxIQ0lSZd+mC5t2Ru/4y4Rf3juZCS4cknMT\n\tf+CUs/kB+4BZkXXmtjq7dXRDxS+HsjYyYEWL74WYJ+WYWJeJeZHN3BnuXAEiEOrnq5GP\n\tqJRmpvQ8qyWa8C3z2hbH2sdZ6UQcANTj7gpIzZG0NiZeWDjmTOCzjxLevTjZV0O4hd5U\n\taYt2hMQW3baTyL71PfZGivpsLxoM3UtxdP4cGwK45gPGXaOIPupJiusr9DDtFnrTi1uj\n\tmQZ20lEPRz5ugJrMIdSxGKfYJ7FCL+grI8Sgnn7NaEe6U1vlakY74Wci2uwy7GfVAGlE\n\tvVCA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=yDE4qwe7xQ4AgwDAAl9Bb5J8KFPV47YgtaLZwg1xSJY=;\n\tb=CvBfWB8cpsT2gPb/E+Bjl2HK9tS5QYQl3XiqdzHOstGQYY9GjLXLE+ZCV1rSB3qFDq\n\tl418jzM5sSUzAZWbShO6PsXn/X1FUFmcaVszvqL45//lLIfK41iFoui2GLa53NCcAnwQ\n\tI+81EYIJK/wMZHmejG+AZcENAnBLYxT9+v3uxXpQQK4iKeTlnpuCapepr7DBgZxFz2Zr\n\tl8BVa5JnEZ+OemFznoAoaKVOLSz/cOsqV83e+tuaZsSJJOvSti6SB9HW4/EpXj9JPquo\n\t3s6O/DQBRX4UGJjCf9ugw0JmCnyj+YalLioHOOvCM1VLG/bpikGB60Ci7kU6fNF0AJR7\n\tkrQg==","X-Gm-Message-State":"AOAM531YqQjZIptoAcGkvlnnYL61fXGvQev4gCqGRDn6W+wFfLuk5EWY\n\tK7qcUJCpxVeej+3fJBzSkpP4/PB3HUEHu++UWsY0E3hySF4U6w==","X-Google-Smtp-Source":"ABdhPJyop8Oo8vgver3Ygg8GTfl2b9OKxLia2KVtVqBk6ngmDg4ORFsFOEmzwg+1Z4GWYLs8jEe4ymiaWxyS24TlFIM=","X-Received":"by 2002:adf:d0cb:: with SMTP id\n\tz11mr10309998wrh.236.1623764217129; \n\tTue, 15 Jun 2021 06:36:57 -0700 (PDT)","MIME-Version":"1.0","References":"<20210614100040.3054433-1-naush@raspberrypi.com>\n\t<20210614100040.3054433-4-naush@raspberrypi.com>","In-Reply-To":"<20210614100040.3054433-4-naush@raspberrypi.com>","From":"David Plowman ","Date":"Tue, 15 Jun 2021 14:36:45 +0100","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 3/4] ipa: raspberrypi: Increase the\n\tdefault max frame duration to 250s","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]