{"id":12565,"url":"https://patchwork.libcamera.org/api/patches/12565/?format=json","web_url":"https://patchwork.libcamera.org/patch/12565/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210611084228.1830629-3-hiroh@chromium.org>","date":"2021-06-11T08:42:26","name":"[libcamera-devel,RFC,2/4] libcamera: ipu3: Disable a sensor test pattern mode at initialization","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e51f9418711f201b48d3ece076cc29e8eb5af956","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12565/mbox/","series":[{"id":2121,"url":"https://patchwork.libcamera.org/api/series/2121/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2121","date":"2021-06-11T08:42:24","name":"Support sensor test pattern mode in Android HAL","version":1,"mbox":"https://patchwork.libcamera.org/series/2121/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12565/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12565/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9813EC320B\n\tfor ;\n\tFri, 11 Jun 2021 08:42:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D39DE68939;\n\tFri, 11 Jun 2021 10:42:41 +0200 (CEST)","from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com\n\t[IPv6:2607:f8b0:4864:20::62d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E58D46029E\n\tfor ;\n\tFri, 11 Jun 2021 10:42:38 +0200 (CEST)","by mail-pl1-x62d.google.com with SMTP id h12so2491964plf.4\n\tfor ;\n\tFri, 11 Jun 2021 01:42:38 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:367e:c2e4:d691:eca1])\n\tby smtp.gmail.com with ESMTPSA id\n\t20sm4323542pfi.170.2021.06.11.01.42.36\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 11 Jun 2021 01:42:36 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"dHqDv8kz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=S/CTBALndrol7bWOFs/wylrYjCw+G6VOSg2fPR34U8E=;\n\tb=dHqDv8kzyjpyd1R+fXlETOCZU86gxypoOGZOMDPoDqPebbQqbA+JCYMuWFJD0dsnGJ\n\tj9jlGh7ZuL7pr1m5hdtwz/r0DdyLQsiPeRA1CxTS/30HCv7YPiJ7RIMalhPbzD8wj0qA\n\t0uoqk4xhgk6PT25U8kk4x4ji12ow/84SqMUoQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=S/CTBALndrol7bWOFs/wylrYjCw+G6VOSg2fPR34U8E=;\n\tb=q3aRsC2jYD9i5QLlRDyajZFJA//Pq8hRL2C0ADfzn+OOJroF9y+cyAAKstkehBRid+\n\tMX4EKt4a8HtcJTEIW/ROcAwDPmhML/u2c9PGyCXX7l0UVgIjza28M/qhsK9EX/Me7Tzy\n\tO5kFh9lgw7pxlLFNrUsWjOl+f+PMeA+9X2rWBHgxa+ontEg63qPJhtj3PO4vlCAFKdd5\n\tRfk7kpKzYfaoCdw6z0F5Gw1d5KXW1aotRgi6oHzD+bwECjFBCzm5j73ci8xLIuZ2A0wC\n\toCocUxqxFVaJbjoHhjNuZi55P9OqMWNYIrAFxZ23lvwRO3//PZ9KgKQbFYbo7/KHlraq\n\t7zOw==","X-Gm-Message-State":"AOAM531QPfc+cck1Tcreo5ypp7MeaCcyjL5G8fyBGTZpFvq6AUzlnw9s\n\tt7kk5IRE42fc/nEVB/v5scvg98sRqr1kIQ==","X-Google-Smtp-Source":"ABdhPJzggJvbkNRBm4oWoaxgdNBNz3V/A9jdJNzFclYwHeibuahZtITRvgS5Jjbh+RI2ErTa0hIQYA==","X-Received":"by 2002:a17:90a:dac1:: with SMTP id\n\tg1mr8021092pjx.199.1623400957334; \n\tFri, 11 Jun 2021 01:42:37 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 11 Jun 2021 17:42:26 +0900","Message-Id":"<20210611084228.1830629-3-hiroh@chromium.org>","X-Mailer":"git-send-email 2.32.0.272.g935e593368-goog","In-Reply-To":"<20210611084228.1830629-1-hiroh@chromium.org>","References":"<20210611084228.1830629-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 2/4] libcamera: ipu3: Disable a sensor\n\ttest pattern mode at initialization","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Turns off a sensor test pattern mode at the initialization of the\nsensor. Without this, the camera sensor is configured with the last\ntest pattern mode that has been set.\n\nSigned-off-by: Hirokazu Honda \n---\n src/libcamera/pipeline/ipu3/cio2.cpp | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\nindex 1be2cbcd..8548f749 100644\n--- a/src/libcamera/pipeline/ipu3/cio2.cpp\n+++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n@@ -9,6 +9,7 @@\n \n #include \n \n+#include \n #include \n #include \n #include \n@@ -192,6 +193,13 @@ int CIO2Device::configure(const Size &size, V4L2DeviceFormat *outputFormat)\n \n \tLOG(IPU3, Debug) << \"CIO2 output format \" << outputFormat->toString();\n \n+\tret = sensor_->setTestPatternMode(controls::draft::TestPatternModeOff);\n+\tif (ret) {\n+\t\tLOG(IPU3, Error)\n+\t\t\t<< \"Failed to reset test pattern mode: \" << ret;\n+\t\treturn ret;\n+\t}\n+\n \treturn 0;\n }\n \n","prefixes":["libcamera-devel","RFC","2/4"]}