{"id":12531,"url":"https://patchwork.libcamera.org/api/patches/12531/?format=json","web_url":"https://patchwork.libcamera.org/patch/12531/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210608212714.9381-1-laurent.pinchart@ideasonboard.com>","date":"2021-06-08T21:27:14","name":"[libcamera-devel] ipa: ipu3: Fix struct/class mismatch in forward declaration","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8ab032ab880c599c66601700a94c63eeaefcf8b6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12531/mbox/","series":[{"id":2113,"url":"https://patchwork.libcamera.org/api/series/2113/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2113","date":"2021-06-08T21:27:14","name":"[libcamera-devel] ipa: ipu3: Fix struct/class mismatch in forward declaration","version":1,"mbox":"https://patchwork.libcamera.org/series/2113/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12531/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12531/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E695BD22E\n\tfor ;\n\tTue, 8 Jun 2021 21:27:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C1D33602C5;\n\tTue, 8 Jun 2021 23:27:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 723D4602A7\n\tfor ;\n\tTue, 8 Jun 2021 23:27:37 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DECAFDD;\n\tTue, 8 Jun 2021 23:27:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nB2DIvEQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623187657;\n\tbh=qWZ+6tCb3ghgS2ylXbti1vcvcAbZeLJONoCF5a5BKPo=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=nB2DIvEQ7BqBLYXYjghl3krNQ4etc6aDxra0oa2Kcilj/d4eSrlt2D0Km2zFk26QD\n\tTlqODhuHqbVCZ8pT8t55GYkqyIL44/rznia6zY1PkHNMtn3TMpISRWCiIyz/5rCY2Y\n\tVd9K58Q+9Ced0HFHsr2bmMgkwnY7sLNuRNOxSatU=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 9 Jun 2021 00:27:14 +0300","Message-Id":"<20210608212714.9381-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] ipa: ipu3: Fix struct/class mismatch in\n\tforward declaration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ipu3_agc.h forward-declares the IPACameraSensorInfo structure, but\nincorrectly declares it as a class. This causes a compilation error with\nclang:\n\ninclude/libcamera/ipa/core_ipa_interface.h:24:1: error: 'IPACameraSensorInfo' defined as a struct here but previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]\nstruct IPACameraSensorInfo\n^\n../../src/ipa/ipu3/ipu3_agc.h:21:1: note: did you mean struct here?\nclass IPACameraSensorInfo;\n^~~~~\nstruct\n\nFix it.\n\nFixes: 384a53d3cdf7 (\"ipa: ipu3: Calculate line duration from IPACameraSensorInfo\")\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/ipu3/ipu3_agc.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/ipu3/ipu3_agc.h b/src/ipa/ipu3/ipu3_agc.h\nindex 99a582a9fdcf..f3d4055761e6 100644\n--- a/src/ipa/ipu3/ipu3_agc.h\n+++ b/src/ipa/ipu3/ipu3_agc.h\n@@ -18,7 +18,7 @@\n \n namespace libcamera {\n \n-class IPACameraSensorInfo;\n+struct IPACameraSensorInfo;\n \n namespace ipa::ipu3 {\n \n","prefixes":["libcamera-devel"]}