[{"id":17470,"web_url":"https://patchwork.libcamera.org/comment/17470/","msgid":"<20210608074856.GL156622@pyrite.rasen.tech>","date":"2021-06-08T07:48:56","subject":"Re: [libcamera-devel] [PATCH v2 2/3] ipa: ipu3: Copy\n\tIPACameraSensorInfo for future usage","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Umang,\n\nOn Tue, Jun 08, 2021 at 01:12:24PM +0530, Umang Jain wrote:\n> IPACameraSensorInfo members will be needed at various places in the\n> IPAIPU3 class, in subsequent commits. Hence, it seems trivial to copy\n> this structure for wider availability throughout the class.\n> \n> This commit does not introduce any functional changes.\n> \n> Signed-off-by: Umang Jain \n> Tested-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/ipu3/ipu3.cpp | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 2496b0a0..97ddb863 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -63,6 +63,8 @@ private:\n> \n> \tControlInfoMap ctrls_;\n> \n> +\tIPACameraSensorInfo sensorInfo_;\n> +\n> \t/* Camera sensor controls. */\n> \tuint32_t exposure_;\n> \tuint32_t minExposure_;\n> @@ -144,6 +146,8 @@ void IPAIPU3::configure(const IPAConfigInfo &configInfo)\n> \tif (configInfo.entityControls.empty())\n> \t\treturn;\n> \n> +\tsensorInfo_ = configInfo.sensorInfo;\n> +\n> \tctrls_ = configInfo.entityControls.at(0);\n> \n> \tconst auto itExp = ctrls_.find(V4L2_CID_EXPOSURE);\n> @@ -174,7 +178,7 @@ void IPAIPU3::configure(const IPAConfigInfo &configInfo)\n> \tawbAlgo_->initialise(params_, configInfo.bdsOutputSize, bdsGrid_);\n> \n> \tagcAlgo_ = std::make_unique();\n> -\tagcAlgo_->initialise(bdsGrid_, configInfo.sensorInfo);\n> +\tagcAlgo_->initialise(bdsGrid_, sensorInfo_);\n> }\n> \n> void IPAIPU3::mapBuffers(const std::vector &buffers)\n> -- \n> 2.31.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65D71BD22E\n\tfor ;\n\tTue, 8 Jun 2021 07:49:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18FDB6892B;\n\tTue, 8 Jun 2021 09:49:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2458368928\n\tfor ;\n\tTue, 8 Jun 2021 09:49:05 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 10FCF3E6;\n\tTue, 8 Jun 2021 09:49:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EjFdnom8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623138544;\n\tbh=kITigHUUbQpUn8CFmmPFaoV6Io3pF0qJeB1uCKLybuM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EjFdnom8AGTvIlsOy9gHOPaLQQacWZWdqASd9jaEJCSCikChPOHX/wQiIhdUVkk6J\n\tZ6IX6jgP/R1xEI31ITc/WYhFVYGOcymWBog9tES+UFDdWq7SR3MXbzKMcda6kNQXRP\n\t38AoX8kutg7Iddg7yw6eLXpOYYweirFhmQsGTYNQ=","Date":"Tue, 8 Jun 2021 16:48:56 +0900","From":"paul.elder@ideasonboard.com","To":"Umang Jain ","Message-ID":"<20210608074856.GL156622@pyrite.rasen.tech>","References":"<20210608074225.59862-1-umang.jain@ideasonboard.com>\n\t<20210608074225.59862-3-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210608074225.59862-3-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] ipa: ipu3: Copy\n\tIPACameraSensorInfo for future usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]