{"id":12480,"url":"https://patchwork.libcamera.org/api/patches/12480/?format=json","web_url":"https://patchwork.libcamera.org/patch/12480/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210601112456.118755-3-umang.jain@ideasonboard.com>","date":"2021-06-01T11:24:56","name":"[libcamera-devel,2/2] ipa: ipu3: Bump frame duration value","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6b9ce6117164809ad64a0daffac61a09a58e7553","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12480/mbox/","series":[{"id":2097,"url":"https://patchwork.libcamera.org/api/series/2097/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2097","date":"2021-06-01T11:24:54","name":"frame-durations CTS fixups","version":1,"mbox":"https://patchwork.libcamera.org/series/2097/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12480/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12480/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B01CFC3205\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  1 Jun 2021 11:25:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7138668929;\n\tTue,  1 Jun 2021 13:25:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BAA7C6891F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  1 Jun 2021 13:25:12 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.189])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 131CCA2A;\n\tTue,  1 Jun 2021 13:25:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HHPI4Den\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622546712;\n\tbh=R31OIcn3kTsWq7GlDxfoCYD/8mgB88Lcg0xYVWvP7GY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=HHPI4DenJvkCeyslrD/LyCp7HxsXr2/jW+PaONB/7wBgaNMtJwtDlf/QkRH5uA33w\n\tueERNwIr+wVgs6aK42Hs+yzkj18cZG6whXAXvEXm73GBcYWDscqchMor8c05sW4FHA\n\tx8mpnaW5z6b01MjFKL5XDT07StxJ2p322kRq9j68=","From":"Umang Jain <umang.jain@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Tue,  1 Jun 2021 16:54:56 +0530","Message-Id":"<20210601112456.118755-3-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210601112456.118755-1-umang.jain@ideasonboard.com>","References":"<20210601112456.118755-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] ipa: ipu3: Bump frame duration value","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"We report a hard-coded frame duration value for CTS. However, when the\nCTS is tested on nautilus, which has a 'imx258' sensor, the frame\nduration was found to be out-of-range. Since different sensors have\ndifferent frame durations range-limits, we need to bump up our value\nto match the lower end of the 'imx258' frame duration range-limit\n(rounded up to the nearest micro-second).\n\nThis allows the following CTS test to pass on nautilus platform:\n - android.hardware.camera2.cts.CaptureRequestTest#testNoiseReductionModeControl\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 700a5660..e51b0401 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -271,7 +271,7 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n \n \t/* \\todo Populate this with real values */\n \tctrls.set(controls::FrameDuration,\n-\t\t  static_cast<int64_t>(33334));\n+\t\t  static_cast<int64_t>(34483));\n \n \tIPU3Action op;\n \top.op = ActionMetadataReady;\n","prefixes":["libcamera-devel","2/2"]}