[{"id":17360,"web_url":"https://patchwork.libcamera.org/comment/17360/","msgid":"","date":"2021-06-01T00:19:28","subject":"Re: [libcamera-devel] [PATCH] android: Fix unused parameter\n\twarnings on Chrome OS","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jun 01, 2021 at 01:53:28AM +0300, Laurent Pinchart wrote:\n> The Chrome OS-specific code has multiple function parameters that are\n> not used. This results in compilation warnings. Fix them with\n> [[maybe_unused]].\n> \n> Signed-off-by: Laurent Pinchart \n> Change-Id: I4f05ace5c1781b2593e80532553b6a02e399fed6\n\nApologies for this.\n\n> ---\n> src/android/cros/camera3_hal.cpp | 2 +-\n> src/android/mm/cros_camera_buffer.cpp | 5 +++--\n> 2 files changed, 4 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/cros/camera3_hal.cpp b/src/android/cros/camera3_hal.cpp\n> index d6fc1d0fca06..fb863b5f9aa9 100644\n> --- a/src/android/cros/camera3_hal.cpp\n> +++ b/src/android/cros/camera3_hal.cpp\n> @@ -9,7 +9,7 @@\n> \n> #include \"../camera_hal_manager.h\"\n> \n> -static void set_up(cros::CameraMojoChannelManagerToken *token)\n> +static void set_up([[maybe_unused]] cros::CameraMojoChannelManagerToken *token)\n> {\n> }\n> \n> diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp\n> index 1a4fd5d1dfe3..59e26d1b5972 100644\n> --- a/src/android/mm/cros_camera_buffer.cpp\n> +++ b/src/android/mm/cros_camera_buffer.cpp\n> @@ -48,7 +48,8 @@ private:\n> };\n> \n> CameraBuffer::Private::Private(CameraBuffer *cameraBuffer,\n> -\t\t\t buffer_handle_t camera3Buffer, int flags)\n> +\t\t\t buffer_handle_t camera3Buffer,\n> +\t\t\t [[maybe_unused]] int flags)\n> \t: Extensible::Private(cameraBuffer), handle_(camera3Buffer),\n> \t numPlanes_(0), valid_(false), registered_(false)\n> {\n> @@ -128,7 +129,7 @@ Span CameraBuffer::Private::plane(unsigned int plane)\n> \t\t bufferManager_->GetPlaneSize(handle_, plane) };\n> }\n> \n> -size_t CameraBuffer::Private::jpegBufferSize(size_t maxJpegBufferSize) const\n> +size_t CameraBuffer::Private::jpegBufferSize([[maybe_unused]] size_t maxJpegBufferSize) const\n> {\n> \treturn bufferManager_->GetPlaneSize(handle_, 0);\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB4EEC3205\n\tfor ;\n\tTue, 1 Jun 2021 00:19:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A9096891C;\n\tTue, 1 Jun 2021 02:19:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7B936891B\n\tfor ;\n\tTue, 1 Jun 2021 02:19:39 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 14F0588C\n\tfor ;\n\tTue, 1 Jun 2021 02:19:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ADlN9xuJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622506779;\n\tbh=xMrzNt7YIjJYQc/1XYjuUOT2Tcvbvq4Lwhxxo5y3uls=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=ADlN9xuJHB6OjhfCg1/prfy9Jaiys6PqqFiIV4Uv2m5YigI3wP/6R9agE3QMQgi98\n\tb/i0t/Y1KRSUPTeXHIRgo0vK0Yt55Rmh/Kknuo8zU1jzNNoLl9IQy2WFaAn1DUJtlf\n\tGma32e8YdY7Q53Q0aij+GyA6BKs3fU+svuIuwaus=","Date":"Tue, 1 Jun 2021 03:19:28 +0300","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"","References":"<20210531225328.7595-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210531225328.7595-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] android: Fix unused parameter\n\twarnings on Chrome OS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17361,"web_url":"https://patchwork.libcamera.org/comment/17361/","msgid":"<20210601031143.GA1929@pyrite.rasen.tech>","date":"2021-06-01T03:11:43","subject":"Re: [libcamera-devel] [PATCH] android: Fix unused parameter\n\twarnings on Chrome OS","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Tue, Jun 01, 2021 at 01:53:28AM +0300, Laurent Pinchart wrote:\n> The Chrome OS-specific code has multiple function parameters that are\n> not used. This results in compilation warnings. Fix them with\n> [[maybe_unused]].\n> \n> Signed-off-by: Laurent Pinchart \n> Change-Id: I4f05ace5c1781b2593e80532553b6a02e399fed6\n\nReviewed-by: Paul Elder \n\n> ---\n> src/android/cros/camera3_hal.cpp | 2 +-\n> src/android/mm/cros_camera_buffer.cpp | 5 +++--\n> 2 files changed, 4 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/cros/camera3_hal.cpp b/src/android/cros/camera3_hal.cpp\n> index d6fc1d0fca06..fb863b5f9aa9 100644\n> --- a/src/android/cros/camera3_hal.cpp\n> +++ b/src/android/cros/camera3_hal.cpp\n> @@ -9,7 +9,7 @@\n> \n> #include \"../camera_hal_manager.h\"\n> \n> -static void set_up(cros::CameraMojoChannelManagerToken *token)\n> +static void set_up([[maybe_unused]] cros::CameraMojoChannelManagerToken *token)\n> {\n> }\n> \n> diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp\n> index 1a4fd5d1dfe3..59e26d1b5972 100644\n> --- a/src/android/mm/cros_camera_buffer.cpp\n> +++ b/src/android/mm/cros_camera_buffer.cpp\n> @@ -48,7 +48,8 @@ private:\n> };\n> \n> CameraBuffer::Private::Private(CameraBuffer *cameraBuffer,\n> -\t\t\t buffer_handle_t camera3Buffer, int flags)\n> +\t\t\t buffer_handle_t camera3Buffer,\n> +\t\t\t [[maybe_unused]] int flags)\n> \t: Extensible::Private(cameraBuffer), handle_(camera3Buffer),\n> \t numPlanes_(0), valid_(false), registered_(false)\n> {\n> @@ -128,7 +129,7 @@ Span CameraBuffer::Private::plane(unsigned int plane)\n> \t\t bufferManager_->GetPlaneSize(handle_, plane) };\n> }\n> \n> -size_t CameraBuffer::Private::jpegBufferSize(size_t maxJpegBufferSize) const\n> +size_t CameraBuffer::Private::jpegBufferSize([[maybe_unused]] size_t maxJpegBufferSize) const\n> {\n> \treturn bufferManager_->GetPlaneSize(handle_, 0);\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B612AC3206\n\tfor ;\n\tTue, 1 Jun 2021 03:11:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0C1B268921;\n\tTue, 1 Jun 2021 05:11:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB6AD602A4\n\tfor ;\n\tTue, 1 Jun 2021 05:11:51 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 51F8688C;\n\tTue, 1 Jun 2021 05:11:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fn0HIzcB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622517110;\n\tbh=tTmI0bn25mlEFwRlk4fQ/sSb52Q2WwpbrdxO73d9Gx8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fn0HIzcBfwQrjQKEuBoEKrM+QlFPhyBUXXY5B87VwTREuJNpa4YedwvwdMqGfab5r\n\tZXVDB4p35hF/r5WgbktwJtddYLd7FodqxFOvR9t15rPd9Dh8rAt8KGRxQA/1HqEGmi\n\tREOG6Qb8knOXK6RP6ZzXMOqMMw5NjP8jsypgYjsU=","Date":"Tue, 1 Jun 2021 12:11:43 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210601031143.GA1929@pyrite.rasen.tech>","References":"<20210531225328.7595-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210531225328.7595-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] android: Fix unused parameter\n\twarnings on Chrome OS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17362,"web_url":"https://patchwork.libcamera.org/comment/17362/","msgid":"","date":"2021-06-01T03:54:15","subject":"Re: [libcamera-devel] [PATCH] android: Fix unused parameter\n\twarnings on Chrome OS","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent, thank you for the patch.\n\nOn Tue, Jun 1, 2021 at 12:11 PM wrote:\n\n> Hi Laurent,\n>\n> On Tue, Jun 01, 2021 at 01:53:28AM +0300, Laurent Pinchart wrote:\n> > The Chrome OS-specific code has multiple function parameters that are\n> > not used. This results in compilation warnings. Fix them with\n> > [[maybe_unused]].\n> >\n> > Signed-off-by: Laurent Pinchart \n> > Change-Id: I4f05ace5c1781b2593e80532553b6a02e399fed6\n>\n> Reviewed-by: Paul Elder \n>\n\nReviewed-by: Hirokazu Honda \n\n>\n> > ---\n> > src/android/cros/camera3_hal.cpp | 2 +-\n> > src/android/mm/cros_camera_buffer.cpp | 5 +++--\n> > 2 files changed, 4 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/android/cros/camera3_hal.cpp\n> b/src/android/cros/camera3_hal.cpp\n> > index d6fc1d0fca06..fb863b5f9aa9 100644\n> > --- a/src/android/cros/camera3_hal.cpp\n> > +++ b/src/android/cros/camera3_hal.cpp\n> > @@ -9,7 +9,7 @@\n> >\n> > #include \"../camera_hal_manager.h\"\n> >\n> > -static void set_up(cros::CameraMojoChannelManagerToken *token)\n> > +static void set_up([[maybe_unused]] cros::CameraMojoChannelManagerToken\n> *token)\n> > {\n> > }\n> >\n> > diff --git a/src/android/mm/cros_camera_buffer.cpp\n> b/src/android/mm/cros_camera_buffer.cpp\n> > index 1a4fd5d1dfe3..59e26d1b5972 100644\n> > --- a/src/android/mm/cros_camera_buffer.cpp\n> > +++ b/src/android/mm/cros_camera_buffer.cpp\n> > @@ -48,7 +48,8 @@ private:\n> > };\n> >\n> > CameraBuffer::Private::Private(CameraBuffer *cameraBuffer,\n> > - buffer_handle_t camera3Buffer, int flags)\n> > + buffer_handle_t camera3Buffer,\n> > + [[maybe_unused]] int flags)\n> > : Extensible::Private(cameraBuffer), handle_(camera3Buffer),\n> > numPlanes_(0), valid_(false), registered_(false)\n> > {\n> > @@ -128,7 +129,7 @@ Span CameraBuffer::Private::plane(unsigned\n> int plane)\n> > bufferManager_->GetPlaneSize(handle_, plane) };\n> > }\n> >\n> > -size_t CameraBuffer::Private::jpegBufferSize(size_t maxJpegBufferSize)\n> const\n> > +size_t CameraBuffer::Private::jpegBufferSize([[maybe_unused]] size_t\n> maxJpegBufferSize) const\n> > {\n> > return bufferManager_->GetPlaneSize(handle_, 0);\n> > }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 98A97C3205\n\tfor ;\n\tTue, 1 Jun 2021 03:54:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6BE868921;\n\tTue, 1 Jun 2021 05:54:25 +0200 (CEST)","from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com\n\t[IPv6:2a00:1450:4864:20::52f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D85A8602A4\n\tfor ;\n\tTue, 1 Jun 2021 05:54:24 +0200 (CEST)","by mail-ed1-x52f.google.com with SMTP id b17so15655867ede.0\n\tfor ;\n\tMon, 31 May 2021 20:54:24 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"C+aPZU9c\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=ssarsgbPLKOVnn76pXJUjUzXqkzR0am1K/UINpgKoTQ=;\n\tb=C+aPZU9cgFeHk2pNoO3rcSmRKTIDxhLURIklm7Sn8IxzLMg6MMJptwpXtoxyAC+Zj1\n\t8hDoyZWIslJePFyP+1fWpE3zs3RfliL1/E3qbL5vyWkIdU/xSdcojtRW4MkHUpMA3Thc\n\tvMG7OaPcuoWVsEW+GJBbqMc95BYtiEfmOq0Lc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=ssarsgbPLKOVnn76pXJUjUzXqkzR0am1K/UINpgKoTQ=;\n\tb=Cl8PF5tCks4DOXeSJhJ456azH96UDQHpK+K0sCm0dotHhZdftrhyZxE1Mjmgb5imZZ\n\tpKkPtgX2cfVQVR2X6S879xd8CIghX1GLK3RABgilT/vEiBCRV35iJ9l675rIiri3QKRI\n\tySeuEPHu2gLGqN2jlBYPMYW6cY9Ile4CSXwP3Be7xY0eq7iBcIjjWT9urZ8z+QpS00X7\n\tU4TjtbkT9CQzCWeq3WEV4CZwwXcrTnS5SifYMXPOlPAxKb2kpogDDS1riG/nPODLU4Y4\n\tv9Ieu2i+CusrXj1hfQEVuri5TakqKKyN3MXAkxtLfNXlf4GR01GN/PvGNa6dm8IaRv9k\n\tjOiw==","X-Gm-Message-State":"AOAM533t5dwGFUAJ+SR+0xOoDi9lnQKZFrdyeuwqDjahUt5xQkA/afwh\n\tS2OZisv6pl+OSAbBW/TX5lYhmGUcNaZOQZDdpd0ls2TW3Mg=","X-Google-Smtp-Source":"ABdhPJwGR7EzIPTg74U+mdhOqYhlL4pJvAfEMRVX32qJ3pQbvc1E0/m7UrPIQjRWSKOGEheuoKmF6ebYP3FrSDGkys0=","X-Received":"by 2002:a50:bec1:: with SMTP id\n\te1mr29385550edk.116.1622519664514; \n\tMon, 31 May 2021 20:54:24 -0700 (PDT)","MIME-Version":"1.0","References":"<20210531225328.7595-1-laurent.pinchart@ideasonboard.com>\n\t<20210601031143.GA1929@pyrite.rasen.tech>","In-Reply-To":"<20210601031143.GA1929@pyrite.rasen.tech>","From":"Hirokazu Honda ","Date":"Tue, 1 Jun 2021 12:54:15 +0900","Message-ID":"","To":"Paul Elder ","Content-Type":"multipart/alternative; boundary=\"0000000000003ea61905c3ac4c15\"","Subject":"Re: [libcamera-devel] [PATCH] android: Fix unused parameter\n\twarnings on Chrome OS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]