{"id":12477,"url":"https://patchwork.libcamera.org/api/patches/12477/?format=json","web_url":"https://patchwork.libcamera.org/patch/12477/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210531225328.7595-1-laurent.pinchart@ideasonboard.com>","date":"2021-05-31T22:53:28","name":"[libcamera-devel] android: Fix unused parameter warnings on Chrome OS","commit_ref":"a931188e1de2c7663ff6c516141eb714c2a5dd8e","pull_url":null,"state":"accepted","archived":false,"hash":"1e0155173c755a0056441c34f58cf80b59bac7c8","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12477/mbox/","series":[{"id":2096,"url":"https://patchwork.libcamera.org/api/series/2096/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2096","date":"2021-05-31T22:53:28","name":"[libcamera-devel] android: Fix unused parameter warnings on Chrome OS","version":1,"mbox":"https://patchwork.libcamera.org/series/2096/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12477/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12477/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96D16C3206\n\tfor ;\n\tMon, 31 May 2021 22:53:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E9A3768921;\n\tTue, 1 Jun 2021 00:53:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 933636891B\n\tfor ;\n\tTue, 1 Jun 2021 00:53:42 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DDA5F88C\n\tfor ;\n\tTue, 1 Jun 2021 00:53:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bOrGFggD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622501622;\n\tbh=ZGfYDqD0FvfmqYoNoxuUbJdjHQU6C3uDogJD9k/4I3Y=;\n\th=From:To:Subject:Date:From;\n\tb=bOrGFggD+tT2F7H1Q4doGxj8vVtcEkDqzD7vnAXs8n5owYemEUTtA1XLC3pgMIXyG\n\txczYY9f3ykP7qVcSPj68KvDqGpN2J/O/jEd/4vJpaUI+4HInrxDTMar4T0pTXImzMP\n\trgllzjAfZPLTcTh/4DVTxWfqd9qvrcx+tBuM7n3w=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 1 Jun 2021 01:53:28 +0300","Message-Id":"<20210531225328.7595-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] android: Fix unused parameter warnings on\n\tChrome OS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The Chrome OS-specific code has multiple function parameters that are\nnot used. This results in compilation warnings. Fix them with\n[[maybe_unused]].\n\nSigned-off-by: Laurent Pinchart \nChange-Id: I4f05ace5c1781b2593e80532553b6a02e399fed6\n---\n src/android/cros/camera3_hal.cpp | 2 +-\n src/android/mm/cros_camera_buffer.cpp | 5 +++--\n 2 files changed, 4 insertions(+), 3 deletions(-)","diff":"diff --git a/src/android/cros/camera3_hal.cpp b/src/android/cros/camera3_hal.cpp\nindex d6fc1d0fca06..fb863b5f9aa9 100644\n--- a/src/android/cros/camera3_hal.cpp\n+++ b/src/android/cros/camera3_hal.cpp\n@@ -9,7 +9,7 @@\n \n #include \"../camera_hal_manager.h\"\n \n-static void set_up(cros::CameraMojoChannelManagerToken *token)\n+static void set_up([[maybe_unused]] cros::CameraMojoChannelManagerToken *token)\n {\n }\n \ndiff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp\nindex 1a4fd5d1dfe3..59e26d1b5972 100644\n--- a/src/android/mm/cros_camera_buffer.cpp\n+++ b/src/android/mm/cros_camera_buffer.cpp\n@@ -48,7 +48,8 @@ private:\n };\n \n CameraBuffer::Private::Private(CameraBuffer *cameraBuffer,\n-\t\t\t buffer_handle_t camera3Buffer, int flags)\n+\t\t\t buffer_handle_t camera3Buffer,\n+\t\t\t [[maybe_unused]] int flags)\n \t: Extensible::Private(cameraBuffer), handle_(camera3Buffer),\n \t numPlanes_(0), valid_(false), registered_(false)\n {\n@@ -128,7 +129,7 @@ Span CameraBuffer::Private::plane(unsigned int plane)\n \t\t bufferManager_->GetPlaneSize(handle_, plane) };\n }\n \n-size_t CameraBuffer::Private::jpegBufferSize(size_t maxJpegBufferSize) const\n+size_t CameraBuffer::Private::jpegBufferSize([[maybe_unused]] size_t maxJpegBufferSize) const\n {\n \treturn bufferManager_->GetPlaneSize(handle_, 0);\n }\n","prefixes":["libcamera-devel"]}