[{"id":17421,"web_url":"https://patchwork.libcamera.org/comment/17421/","msgid":"","date":"2021-06-06T23:52:28","subject":"Re: [libcamera-devel] [PATCH v6 6/6] android: CameraDevice: Report\n\tqueried test pattern modes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the patch.\n\nOn Fri, May 28, 2021 at 12:05:31PM +0900, Hirokazu Honda wrote:\n> Report to the Android camera stack the list of supported test\n> pattern modes constructed by inspecting the values reported\n> by libcamera through the controls::draft::TestPatternMode control.\n> \n> Signed-off-by: Hirokazu Honda \n> Reviewed-by: Jacopo Mondi \n> ---\n> src/android/camera_device.cpp | 46 ++++++++++++++++++++++++++++++++---\n> 1 file changed, 43 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 7fc4ddb0..d29147bc 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1082,11 +1082,51 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \n> \tstaticMetadata_->addEntry(ANDROID_SENSOR_ORIENTATION, orientation_);\n> \n> -\tstd::vector testPatterModes = {\n> -\t\tANDROID_SENSOR_TEST_PATTERN_MODE_OFF,\n> +\tstd::vector testPatternModes = {\n> +\t\tANDROID_SENSOR_TEST_PATTERN_MODE_OFF\n> \t};\n> +\tif (const auto &testPatternsInfo =\n> +\t\t controlsInfo.find(&controls::draft::TestPatternMode);\n> +\t testPatternsInfo != controlsInfo.end()) {\n\nSame comment as for patch 5/6.\n\n> +\t\tconst auto &values = testPatternsInfo->second.values();\n> +\t\tASSERT(!values.empty());\n> +\t\tfor (const auto &value : values) {\n> +\t\t\tswitch (value.get()) {\n> +\t\t\tcase controls::draft::TestPatternModeOff:\n> +\t\t\t\t/*\n> +\t\t\t\t * ANDROID_SENSOR_TEST_PATTERN_MODE_OFF is\n> +\t\t\t\t * already in testPatternModes.\n> +\t\t\t\t */\n> +\t\t\t\tbreak;\n> +\t\t\tcase controls::draft::TestPatternModeSolidColor:\n> +\t\t\t\ttestPatternModes.push_back(\n> +\t\t\t\t\tANDROID_SENSOR_TEST_PATTERN_MODE_SOLID_COLOR);\n> +\t\t\t\tbreak;\n> +\t\t\tcase controls::draft::TestPatternModeColorBars:\n> +\t\t\t\ttestPatternModes.push_back(\n> +\t\t\t\t\tANDROID_SENSOR_TEST_PATTERN_MODE_COLOR_BARS);\n> +\t\t\t\tbreak;\n> +\t\t\tcase controls::draft::TestPatternModeColorBarsFadeToGray:\n> +\t\t\t\ttestPatternModes.push_back(\n> +\t\t\t\t\tANDROID_SENSOR_TEST_PATTERN_MODE_COLOR_BARS_FADE_TO_GRAY);\n> +\t\t\t\tbreak;\n> +\t\t\tcase controls::draft::TestPatternModePn9:\n> +\t\t\t\ttestPatternModes.push_back(\n> +\t\t\t\t\tANDROID_SENSOR_TEST_PATTERN_MODE_PN9);\n> +\t\t\t\tbreak;\n> +\t\t\tcase controls::draft::TestPatternModeCustom1:\n> +\t\t\t\ttestPatternModes.push_back(\n> +\t\t\t\t\tANDROID_SENSOR_TEST_PATTERN_MODE_CUSTOM1);\n> +\t\t\t\tbreak;\n\nGiven that we don't support this yet, I'd drop it for now.\n\nReviewed-by: Laurent Pinchart \n\n> +\t\t\tdefault:\n> +\t\t\t\tLOG(HAL, Error) << \"Unknown test pattern mode: \"\n> +\t\t\t\t\t\t<< value.get();\n> +\t\t\t\tcontinue;\n> +\t\t\t}\n> +\t\t}\n> +\t}\n> \tstaticMetadata_->addEntry(ANDROID_SENSOR_AVAILABLE_TEST_PATTERN_MODES,\n> -\t\t\t\t testPatterModes);\n> +\t\t\t\t testPatternModes);\n> \n> \tuint8_t timestampSource = ANDROID_SENSOR_INFO_TIMESTAMP_SOURCE_UNKNOWN;\n> \tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_TIMESTAMP_SOURCE,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DAD2CC3206\n\tfor ;\n\tSun, 6 Jun 2021 23:52:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E4B568928;\n\tMon, 7 Jun 2021 01:52:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4DC0B68921\n\tfor ;\n\tMon, 7 Jun 2021 01:52:42 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AB0EB80F;\n\tMon, 7 Jun 2021 01:52:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LIZuL6UP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623023561;\n\tbh=9tGWNuqjjReVOMQA6MZKhUqoV8Pg/ElstW7VFrQ3XXU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LIZuL6UPGCKPDmNYFiD4rh+EbSTgmc0mXR7Bs1X8ovME+yrmE1maiOmUIPm+iR3d4\n\t9RCwlrbFy7PXY3Z3T6kjbOKOpXEZt7Ba3Sny1lkZA1CkpqEntxmguy7i+d1xQu2hKl\n\tvUStLJ06cjOhjR1FvOqX84vE04GI2MN9/4jkFu48=","Date":"Mon, 7 Jun 2021 02:52:28 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210528030531.189492-1-hiroh@chromium.org>\n\t<20210528030531.189492-6-hiroh@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210528030531.189492-6-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v6 6/6] android: CameraDevice: Report\n\tqueried test pattern modes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]