[{"id":17420,"web_url":"https://patchwork.libcamera.org/comment/17420/","msgid":"","date":"2021-06-06T23:47:36","subject":"Re: [libcamera-devel] [PATCH v6 5/6] libcamera: pipeline: ipu3:\n\tReport available sensor test pattern mode","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the patch.\n\nOn Fri, May 28, 2021 at 12:05:30PM +0900, Hirokazu Honda wrote:\n> PipelineHandlerIPU3 gets available test pattern modes of the\n> sensor device and reports them to a client.\n> \n> Signed-off-by: Hirokazu Honda \n> Reviewed-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 58923bc7..0e028cff 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -936,6 +936,18 @@ int PipelineHandlerIPU3::initControls(IPU3CameraData *data)\n> \tControlInfoMap::Map controls = IPU3Controls;\n> \tconst ControlInfoMap &sensorControls = sensor->controls();\n> \n> +\tif (const std::vector &testPatternModes =\n> +\t\t sensor->testPatternModes();\n> +\t !testPatternModes.empty()) {\n\nThat's a really weird construct.\n\n\tconst std::vector &testPatternModes = sensor->testPatternModes();\n\tif (!testPatternModes.empty()) {\n\nwould be more readable.\n\n> +\t\tstd::vector values;\n> +\t\tvalues.reserve(testPatternModes.size());\n> +\n> +\t\tfor (uint8_t pattern : testPatternModes)\n> +\t\t\tvalues.emplace_back(static_cast(pattern));\n\nYou will be able to drop the cast if you make the test pattern modes map\nstore int32_t (the CameraSensor::testPatternModes() function will need\nto be updated accordingly).\n\nReviewed-by: Laurent Pinchart \n\n> +\n> +\t\tcontrols[&controls::draft::TestPatternMode] = ControlInfo(values);\n> +\t}\n> +\n> \t/*\n> \t * Compute exposure time limits.\n> \t *","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 25577C320B\n\tfor ;\n\tSun, 6 Jun 2021 23:47:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E07868928;\n\tMon, 7 Jun 2021 01:47:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 21B5768921\n\tfor ;\n\tMon, 7 Jun 2021 01:47:50 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 89F3A80F;\n\tMon, 7 Jun 2021 01:47:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y9EsdxWL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1623023269;\n\tbh=si9F93C7m3HC73v37tr0vo6Z09a27gc8GaPCD7Rra+I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Y9EsdxWLDvXZqTzd5jgyAOAFjIv5oU4VJG+gWwkorG3JbFNsdKoNCPZ4X4pEibY37\n\tRGInoI1VL8yeT1ORQuphZqQsW2vfis+MGhEfLWXRTnh9llehQPS+akrZ2qNx+Rnusy\n\tqpX4V2E2LwdgsNwzxkdJ6XWjB1lIOFcrRJaor65g=","Date":"Mon, 7 Jun 2021 02:47:36 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210528030531.189492-1-hiroh@chromium.org>\n\t<20210528030531.189492-5-hiroh@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210528030531.189492-5-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v6 5/6] libcamera: pipeline: ipu3:\n\tReport available sensor test pattern mode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]