[{"id":17324,"web_url":"https://patchwork.libcamera.org/comment/17324/","msgid":"","date":"2021-05-27T09:14:35","subject":"Re: [libcamera-devel] [PATCH] libcamera: Add IMX258 sensor\n\tproperties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Thu, May 27, 2021 at 12:28:29PM +0530, Umang Jain wrote:\n> Brief specifications available at\n> https://www.sony-semicon.co.jp/products/common/pdf/ProductBrief_IMX258_20151015.pdf\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/camera_sensor_properties.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 2a6e97f7..a2c04009 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -48,6 +48,9 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t{ \"imx219\", {\n> \t\t\t.unitCellSize = { 1120, 1120 },\n> \t\t} },\n> +\t\t{ \"imx258\", {\n> +\t\t\t.unitCellSize = { 1120, 1120 },\n> +\t\t} },\n> \t\t{ \"ov5670\", {\n> \t\t\t.unitCellSize = { 1120, 1120 },\n> \t\t} },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 906DFC3203\n\tfor ;\n\tThu, 27 May 2021 09:14:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A53668923;\n\tThu, 27 May 2021 11:14:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B0633602AA\n\tfor ;\n\tThu, 27 May 2021 11:14:42 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CD1BD124E;\n\tThu, 27 May 2021 11:14:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g32V+PL+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622106882;\n\tbh=y/xPDAuE2yhtQs8uG0Ftr67LJmHL8dj3L7MJzhQ4CwQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=g32V+PL+3gundXEz8JvtiNVR8oaP2kNjy1XJ5F6rjYF4qLwTrfMRtDA8WXb5LrR7c\n\t++6cMSHO8glSq7otEc6qb8YVfV/P5h3IK1JYs5NzsUHYsQMFbN6ccjtvwy4TSmVYTn\n\t6mbDhRbRm8vDbj69ExUHFrTFpxVEHiiI8QtnY9nU=","Date":"Thu, 27 May 2021 12:14:35 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20210527065829.35936-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210527065829.35936-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Add IMX258 sensor\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17402,"web_url":"https://patchwork.libcamera.org/comment/17402/","msgid":"<20210604092812.GF156622@pyrite.rasen.tech>","date":"2021-06-04T09:28:12","subject":"Re: [libcamera-devel] [PATCH] libcamera: Add IMX258 sensor\n\tproperties","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Umang,\n\nOn Thu, May 27, 2021 at 12:28:29PM +0530, Umang Jain wrote:\n> Brief specifications available at\n> https://www.sony-semicon.co.jp/products/common/pdf/ProductBrief_IMX258_20151015.pdf\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/camera_sensor_properties.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 2a6e97f7..a2c04009 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -48,6 +48,9 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t{ \"imx219\", {\n> \t\t\t.unitCellSize = { 1120, 1120 },\n> \t\t} },\n> +\t\t{ \"imx258\", {\n> +\t\t\t.unitCellSize = { 1120, 1120 },\n> +\t\t} },\n> \t\t{ \"ov5670\", {\n> \t\t\t.unitCellSize = { 1120, 1120 },\n> \t\t} },\n> -- \n> 2.29.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F25A1C3206\n\tfor ;\n\tFri, 4 Jun 2021 09:28:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B248068926;\n\tFri, 4 Jun 2021 11:28:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5367468922\n\tfor ;\n\tFri, 4 Jun 2021 11:28:20 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 03DE7EF;\n\tFri, 4 Jun 2021 11:28:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"a2YADcBQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622798900;\n\tbh=RmdVrZPfeqiUbnkYeFY1Lt8cyB2BTWYOcfSO0/WQhe8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=a2YADcBQO9ECGBA7yMs4lrOW0S5lpc0oo0c/J3WC+CWDTUtzNEe6JeClz+Qjis7mK\n\tQELsxexYr3d4t3/dqVCdufCsc8k9F7XTpd3tf3P6r89/YyLvJ+thOa0i9iP81FDqOR\n\tuItOm7bta+c8dfrsbQK9twPUlD9VXv4AAOFiw8M4=","Date":"Fri, 4 Jun 2021 18:28:12 +0900","From":"paul.elder@ideasonboard.com","To":"Umang Jain ","Message-ID":"<20210604092812.GF156622@pyrite.rasen.tech>","References":"<20210527065829.35936-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210527065829.35936-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Add IMX258 sensor\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]