[{"id":17299,"web_url":"https://patchwork.libcamera.org/comment/17299/","msgid":"","date":"2021-05-27T02:49:10","subject":"Re: [libcamera-devel] [PATCH 1/2] android: Don't rely on indirect\n\tinclusion of unistd.h","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent, thank you for the patch.\n\nOn Thu, May 27, 2021 at 10:02 AM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> The standard C library close() and lseek() functions require inclusion\n> of the unistd.h header. Include it explicitly where needed instead of\n> relying on indirect inclusion.\n>\n> Signed-off-by: Laurent Pinchart \n>\n\nDo you know where unistd.h are indirectly included from?\n\nReviewed-by: Hirokazu Honda \n\n> ---\n> src/android/camera_device.cpp | 1 +\n> src/android/camera_worker.cpp | 1 +\n> src/android/mm/generic_camera_buffer.cpp | 2 ++\n> 3 files changed, 4 insertions(+)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 7fc4ddb024c1..81509f57d1b7 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -15,6 +15,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n>\n> #include \n> diff --git a/src/android/camera_worker.cpp b/src/android/camera_worker.cpp\n> index 9f727826e23f..98dddd9eb13b 100644\n> --- a/src/android/camera_worker.cpp\n> +++ b/src/android/camera_worker.cpp\n> @@ -10,6 +10,7 @@\n> #include \n> #include \n> #include \n> +#include \n>\n> #include \"camera_device.h\"\n>\n> diff --git a/src/android/mm/generic_camera_buffer.cpp\n> b/src/android/mm/generic_camera_buffer.cpp\n> index 334498c1867f..cca88cf3632f 100644\n> --- a/src/android/mm/generic_camera_buffer.cpp\n> +++ b/src/android/mm/generic_camera_buffer.cpp\n> @@ -7,6 +7,8 @@\n>\n> #include \"../camera_buffer.h\"\n>\n> +#include \n> +\n> #include \"libcamera/internal/buffer.h\"\n> #include \"libcamera/internal/log.h\"\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 090F6BDB80\n\tfor ;\n\tThu, 27 May 2021 02:49:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5AB1868926;\n\tThu, 27 May 2021 04:49:22 +0200 (CEST)","from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com\n\t[IPv6:2a00:1450:4864:20::52d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CFC8602AA\n\tfor ;\n\tThu, 27 May 2021 04:49:21 +0200 (CEST)","by mail-ed1-x52d.google.com with SMTP id w12so3969919edx.1\n\tfor ;\n\tWed, 26 May 2021 19:49:21 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"FkJnVu3Z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=4e5g/qA5EIBtAAE8+3TzhR8Enc3HS9gJfBMLkUOeSyQ=;\n\tb=FkJnVu3Za0EWi7bAeT190twdDigs/daQQF99pbZvmDomDLR7PDnKgsYBDtzWt6WPLI\n\t3sYH8Ovp7HOCk+s2tgZ0WKiT5UuEM3TSQ0A6PddtA+IazesQlIuBJOk1Jb7EVUupwczV\n\tqZVQy6Ji8q62Y+7ZTkP0ozgM6LoVkdblvmN+Y=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=4e5g/qA5EIBtAAE8+3TzhR8Enc3HS9gJfBMLkUOeSyQ=;\n\tb=DalhpsBzDgjNoXUYQUlMvyhOXqDKWM6I5vZDRJ4i8dnOqXHmkrPta7xOrofg5i7g5S\n\to7nXMHZpVoy8ZbnruosWw6rMXMoAhy6nEPOZaO3JfvJY6PExtL6izVAshX/Gc0zUQDHS\n\tABJMXwBVrHVPQB5hwMZUjbsEVocPjN6VCvx1ql6etxvRgSF7GWyj15TmKJ2pKlsS2wVI\n\tz/kAodASsFI0aJePazvEi5Al/826TSPFzjOAYupvV4+GWzvhPYw6o+kcr03C0/cSqB7n\n\tQZ0iipdCyropHaB/M0VInxBoVUjhkmxB888H1r5Qq4Oin4rvpDuLlHttxcLKEvdu63Yk\n\tteQA==","X-Gm-Message-State":"AOAM531j4f5dpod638ZDGHoetnI7HA1tMkk6sRdOGo3lILevHypt6IO4\n\tiqqnQO5CHibrDBcP3U5qRFZtkbOSf9udB20mgJNHQg==","X-Google-Smtp-Source":"ABdhPJymwiA94PHLLQCIvUJYNkQWCHyBadiFiAWqz7PTlIyNEBvALwqCVdTpfxrNx8tVzmWBLHdt4pQyZSnjopD9XCY=","X-Received":"by 2002:a05:6402:95d:: with SMTP id\n\th29mr1490329edz.233.1622083760649; \n\tWed, 26 May 2021 19:49:20 -0700 (PDT)","MIME-Version":"1.0","References":"<20210527010149.30601-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20210527010149.30601-1-laurent.pinchart@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Thu, 27 May 2021 11:49:10 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"0000000000005986af05c346ce70\"","Subject":"Re: [libcamera-devel] [PATCH 1/2] android: Don't rely on indirect\n\tinclusion of unistd.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17301,"web_url":"https://patchwork.libcamera.org/comment/17301/","msgid":"","date":"2021-05-27T02:52:38","subject":"Re: [libcamera-devel] [PATCH 1/2] android: Don't rely on indirect\n\tinclusion of unistd.h","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nOn Thu, May 27, 2021 at 11:49:10AM +0900, Hirokazu Honda wrote:\n> On Thu, May 27, 2021 at 10:02 AM Laurent Pinchart wrote:\n> \n> > The standard C library close() and lseek() functions require inclusion\n> > of the unistd.h header. Include it explicitly where needed instead of\n> > relying on indirect inclusion.\n> >\n> > Signed-off-by: Laurent Pinchart \n> \n> Do you know where unistd.h are indirectly included from?\n\nAndroid headers, as I noticed a compilation breakage when updating them\n:-)\n\n> Reviewed-by: Hirokazu Honda \n> \n> > ---\n> > src/android/camera_device.cpp | 1 +\n> > src/android/camera_worker.cpp | 1 +\n> > src/android/mm/generic_camera_buffer.cpp | 2 ++\n> > 3 files changed, 4 insertions(+)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 7fc4ddb024c1..81509f57d1b7 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -15,6 +15,7 @@\n> > #include \n> > #include \n> > #include \n> > +#include \n> > #include \n> >\n> > #include \n> > diff --git a/src/android/camera_worker.cpp b/src/android/camera_worker.cpp\n> > index 9f727826e23f..98dddd9eb13b 100644\n> > --- a/src/android/camera_worker.cpp\n> > +++ b/src/android/camera_worker.cpp\n> > @@ -10,6 +10,7 @@\n> > #include \n> > #include \n> > #include \n> > +#include \n> >\n> > #include \"camera_device.h\"\n> >\n> > diff --git a/src/android/mm/generic_camera_buffer.cpp\n> > b/src/android/mm/generic_camera_buffer.cpp\n> > index 334498c1867f..cca88cf3632f 100644\n> > --- a/src/android/mm/generic_camera_buffer.cpp\n> > +++ b/src/android/mm/generic_camera_buffer.cpp\n> > @@ -7,6 +7,8 @@\n> >\n> > #include \"../camera_buffer.h\"\n> >\n> > +#include \n> > +\n> > #include \"libcamera/internal/buffer.h\"\n> > #include \"libcamera/internal/log.h\"\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 571DDBDB80\n\tfor ;\n\tThu, 27 May 2021 02:52:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B8F3468923;\n\tThu, 27 May 2021 04:52:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E446A602AA\n\tfor ;\n\tThu, 27 May 2021 04:52:44 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 693CA515;\n\tThu, 27 May 2021 04:52:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"B8aM7H+c\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622083964;\n\tbh=gOv7zryduFHHwIeyKI6rp1o8FK40tQBOf7YFtjNUxl4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=B8aM7H+cXzJ7nuktQk9/ydqAz+1ZBZZLW+5BJIHMINZ/heHUFEvJN6d/sghVZQFne\n\ty+9rWvufeoa8Rlszwtx7JR1fzP201Y5Nt9gF/qJ5bKSQpTOdvJG615EACb3NgBHoLQ\n\tjDMthC+D6lEenAcvwmGxDpn6Xn9vgQ0NZC888ehQ=","Date":"Thu, 27 May 2021 05:52:38 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210527010149.30601-1-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 1/2] android: Don't rely on indirect\n\tinclusion of unistd.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17303,"web_url":"https://patchwork.libcamera.org/comment/17303/","msgid":"","date":"2021-05-27T03:08:04","subject":"Re: [libcamera-devel] [PATCH 1/2] android: Don't rely on indirect\n\tinclusion of unistd.h","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent,\n\nOn Thu, May 27, 2021 at 11:52 AM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Hiro,\n>\n> On Thu, May 27, 2021 at 11:49:10AM +0900, Hirokazu Honda wrote:\n> > On Thu, May 27, 2021 at 10:02 AM Laurent Pinchart wrote:\n> >\n> > > The standard C library close() and lseek() functions require inclusion\n> > > of the unistd.h header. Include it explicitly where needed instead of\n> > > relying on indirect inclusion.\n> > >\n> > > Signed-off-by: Laurent Pinchart \n> >\n> > Do you know where unistd.h are indirectly included from?\n>\n> Android headers, as I noticed a compilation breakage when updating them\n> :-)\n>\n>\nAcked. Thanks for fixing.\n\n\n> > Reviewed-by: Hirokazu Honda \n> >\n> > > ---\n> > > src/android/camera_device.cpp | 1 +\n> > > src/android/camera_worker.cpp | 1 +\n> > > src/android/mm/generic_camera_buffer.cpp | 2 ++\n> > > 3 files changed, 4 insertions(+)\n> > >\n> > > diff --git a/src/android/camera_device.cpp\n> b/src/android/camera_device.cpp\n> > > index 7fc4ddb024c1..81509f57d1b7 100644\n> > > --- a/src/android/camera_device.cpp\n> > > +++ b/src/android/camera_device.cpp\n> > > @@ -15,6 +15,7 @@\n> > > #include \n> > > #include \n> > > #include \n> > > +#include \n> > > #include \n> > >\n> > > #include \n> > > diff --git a/src/android/camera_worker.cpp\n> b/src/android/camera_worker.cpp\n> > > index 9f727826e23f..98dddd9eb13b 100644\n> > > --- a/src/android/camera_worker.cpp\n> > > +++ b/src/android/camera_worker.cpp\n> > > @@ -10,6 +10,7 @@\n> > > #include \n> > > #include \n> > > #include \n> > > +#include \n> > >\n> > > #include \"camera_device.h\"\n> > >\n> > > diff --git a/src/android/mm/generic_camera_buffer.cpp\n> > > b/src/android/mm/generic_camera_buffer.cpp\n> > > index 334498c1867f..cca88cf3632f 100644\n> > > --- a/src/android/mm/generic_camera_buffer.cpp\n> > > +++ b/src/android/mm/generic_camera_buffer.cpp\n> > > @@ -7,6 +7,8 @@\n> > >\n> > > #include \"../camera_buffer.h\"\n> > >\n> > > +#include \n> > > +\n> > > #include \"libcamera/internal/buffer.h\"\n> > > #include \"libcamera/internal/log.h\"\n> > >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C473C3203\n\tfor ;\n\tThu, 27 May 2021 03:08:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4C52602AA;\n\tThu, 27 May 2021 05:08:15 +0200 (CEST)","from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com\n\t[IPv6:2a00:1450:4864:20::52c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33A75602AA\n\tfor ;\n\tThu, 27 May 2021 05:08:14 +0200 (CEST)","by mail-ed1-x52c.google.com with SMTP id r11so3923142edt.13\n\tfor ;\n\tWed, 26 May 2021 20:08:14 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"N0dyA2K1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=bjFjDgt87wLwKillkUOn69W61tI4+zR7caQLWFVR5ko=;\n\tb=N0dyA2K1cmo9R+SaAPD5fV82VkLNUdhGhNhZSHvtEok6npLmK9j1NxG2w1+LUdZdyU\n\tGVCG7xqSSICkv065FIG0kEOAHcPOpSoEfRex/iUndMDCT0wUFi7G7pAzGdAKcY5pxLqw\n\tek5qIGreFv8AnnElkPrn0+wdSvKnKfULgHvkI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=bjFjDgt87wLwKillkUOn69W61tI4+zR7caQLWFVR5ko=;\n\tb=La9XjERrBX6DyosqYCpWbjRRMqvN77p9p/kpz1y9IqQ7eegntGXSd96Ax49PYFtUwS\n\txi+5gqq5U3+av8md3z1IAbFBesI/sTC1CkWrgfRG7d8uw/uPA0wQYrbRV5NkbxBoGWBc\n\tHoWvvaS2MVsJsgsB5MAKqJgigBb5yeAKtZI76wVppcC3SKGMk9WEI2uLdJKABNfZsF9g\n\tKhnk76c3w0zR3m2+XqpxHP2Giw2YCnEXmQxpxLRTQN3mCPgflhP58b6aw7C8FFeLlePO\n\t+azlUnZpTyOFtWAkonB+ZqVnK0H2dwSHSwOEXHV2Tb9yAuS0YeUwMJD+ybmxqNkM7s+U\n\tyG2w==","X-Gm-Message-State":"AOAM533ywkBA2AlGHaTJBSBzO3ARnmX3rujZjNPFrpsyF7i3JFjwZ/5t\n\txIzQJHO5ZOMwJ2QY1D6l0fJN/atGkFRKvKSQL336ST+IHWE=","X-Google-Smtp-Source":"ABdhPJzF2KA64s9OH9bxE4YkEJDxcrgknVtwrRUZeJCI/5fCUDpT/mLnRWHSeNGicOzaQu6VDVJ64x0yxnsSBml5398=","X-Received":"by 2002:a50:afa3:: with SMTP id\n\th32mr1604253edd.202.1622084893871; \n\tWed, 26 May 2021 20:08:13 -0700 (PDT)","MIME-Version":"1.0","References":"<20210527010149.30601-1-laurent.pinchart@ideasonboard.com>\n\t\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Thu, 27 May 2021 12:08:04 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"000000000000e522f305c347119e\"","Subject":"Re: [libcamera-devel] [PATCH 1/2] android: Don't rely on indirect\n\tinclusion of unistd.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17355,"web_url":"https://patchwork.libcamera.org/comment/17355/","msgid":"<20210531085042.GN1274010@pyrite.rasen.tech>","date":"2021-05-31T08:50:42","subject":"Re: [libcamera-devel] [PATCH 1/2] android: Don't rely on indirect\n\tinclusion of unistd.h","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Thu, May 27, 2021 at 04:01:48AM +0300, Laurent Pinchart wrote:\n> The standard C library close() and lseek() functions require inclusion\n> of the unistd.h header. Include it explicitly where needed instead of\n> relying on indirect inclusion.\n> \n> Signed-off-by: Laurent Pinchart \n\nDoesn't regress CTS :)\n\nTested-by: Paul Elder \n\n> ---\n> src/android/camera_device.cpp | 1 +\n> src/android/camera_worker.cpp | 1 +\n> src/android/mm/generic_camera_buffer.cpp | 2 ++\n> 3 files changed, 4 insertions(+)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 7fc4ddb024c1..81509f57d1b7 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -15,6 +15,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> \n> #include \n> diff --git a/src/android/camera_worker.cpp b/src/android/camera_worker.cpp\n> index 9f727826e23f..98dddd9eb13b 100644\n> --- a/src/android/camera_worker.cpp\n> +++ b/src/android/camera_worker.cpp\n> @@ -10,6 +10,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> #include \"camera_device.h\"\n> \n> diff --git a/src/android/mm/generic_camera_buffer.cpp b/src/android/mm/generic_camera_buffer.cpp\n> index 334498c1867f..cca88cf3632f 100644\n> --- a/src/android/mm/generic_camera_buffer.cpp\n> +++ b/src/android/mm/generic_camera_buffer.cpp\n> @@ -7,6 +7,8 @@\n> \n> #include \"../camera_buffer.h\"\n> \n> +#include \n> +\n> #include \"libcamera/internal/buffer.h\"\n> #include \"libcamera/internal/log.h\"\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B17F7C3205\n\tfor ;\n\tMon, 31 May 2021 08:50:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3054868923;\n\tMon, 31 May 2021 10:50:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8AA126891F\n\tfor ;\n\tMon, 31 May 2021 10:50:49 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0F42E1254;\n\tMon, 31 May 2021 10:50:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J0kAYu/6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622451049;\n\tbh=8BfLxn6rcbALe9W0G3qdlk7588+GqT4xEqtHgmjBTVo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=J0kAYu/6U6JDY3w10TL1qnNV71FQB/3gc/vzTNkREFPxqx666LQW2cxAiH2mX5ND8\n\t4ZSvoecuu6nZOxMdy+7BMgVh9F3Fjn/FUoVGyA+XSgk9svGtRw+cXWQfN1mMKo2wNs\n\tuFGZfByO7p20CabW64IiykJgnBRFZT2eEfugKwYY=","Date":"Mon, 31 May 2021 17:50:42 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210531085042.GN1274010@pyrite.rasen.tech>","References":"<20210527010149.30601-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210527010149.30601-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] android: Don't rely on indirect\n\tinclusion of unistd.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]