[{"id":17278,"web_url":"https://patchwork.libcamera.org/comment/17278/","msgid":"","date":"2021-05-26T13:40:02","subject":"Re: [libcamera-devel] [PATCH v2 1/2] pipeline: ipu3: Fix\n\tmis-aligned comment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Wed, May 26, 2021 at 06:40:24PM +0530, Umang Jain wrote:\n> Fixes: 2fac95b400b7 (\"libcamera: pipeline: ipu3: Ensure that IPU3Frames::info is not used after delete\")\n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 25203256..750880ed 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -1361,9 +1361,9 @@ void IPU3CameraData::statBufferReady(FrameBuffer *buffer)\n> \t\tinfo->metadataProcessed = true;\n> \n> \t\t/*\n> -\t\t* tryComplete() will delete info if it completes the IPU3Frame.\n> -\t\t* In that event, we must have obtained the Request before hand.\n> -\t\t*/\n> +\t\t * tryComplete() will delete info if it completes the IPU3Frame.\n> +\t\t * In that event, we must have obtained the Request before hand.\n> +\t\t */\n> \t\tRequest *request = info->request;\n> \n> \t\tif (frameInfos_.tryComplete(info))","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC7CFBDB80\n\tfor ;\n\tWed, 26 May 2021 13:40:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 16264602B1;\n\tWed, 26 May 2021 15:40:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 444F8602AE\n\tfor ;\n\tWed, 26 May 2021 15:40:08 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B900E908;\n\tWed, 26 May 2021 15:40:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"weOyq7qE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622036407;\n\tbh=CfmUBIHKuHNhyQreA1PPqwkp6oYpTAzo5Hh6vkRJUA0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=weOyq7qECvKJa5XAKAV8fw7WEz7QoXNhRjuwhG9CXpSfbhF08blatJkn6mu8jwPLA\n\t14kgI/vjVHXMOO3irlZhKUMJhrnJSXuw1quem10GOASzhov9Fr6mnWF/JzUFAMdJ7g\n\tHzc8VeHz9dBDJGG6jRM69XM/xvh6p2DQfO9k9GGw=","Date":"Wed, 26 May 2021 16:40:02 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20210526131025.675024-1-umang.jain@ideasonboard.com>\n\t<20210526131025.675024-2-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210526131025.675024-2-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] pipeline: ipu3: Fix\n\tmis-aligned comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17279,"web_url":"https://patchwork.libcamera.org/comment/17279/","msgid":"","date":"2021-05-26T13:48:20","subject":"Re: [libcamera-devel] [PATCH v2 1/2] pipeline: ipu3: Fix\n\tmis-aligned comment","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Umang, thank you for reviewing.\n\nOn Wed, May 26, 2021 at 10:40 PM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Umang,\n>\n> Thank you for the patch.\n>\n> On Wed, May 26, 2021 at 06:40:24PM +0530, Umang Jain wrote:\n> > Fixes: 2fac95b400b7 (\"libcamera: pipeline: ipu3: Ensure that\n> IPU3Frames::info is not used after delete\")\n> > Signed-off-by: Umang Jain \n>\n> Reviewed-by: Laurent Pinchart \n>\n>\nReviewed-by: Hirokazu Honda \n\n\n> > ---\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 6 +++---\n> > 1 file changed, 3 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index 25203256..750880ed 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -1361,9 +1361,9 @@ void IPU3CameraData::statBufferReady(FrameBuffer\n> *buffer)\n> > info->metadataProcessed = true;\n> >\n> > /*\n> > - * tryComplete() will delete info if it completes the\n> IPU3Frame.\n> > - * In that event, we must have obtained the Request before\n> hand.\n> > - */\n> > + * tryComplete() will delete info if it completes the\n> IPU3Frame.\n> > + * In that event, we must have obtained the Request before\n> hand.\n> > + */\n> > Request *request = info->request;\n> >\n> > if (frameInfos_.tryComplete(info))\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90BB3C3203\n\tfor ;\n\tWed, 26 May 2021 13:48:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10D5068925;\n\tWed, 26 May 2021 15:48:32 +0200 (CEST)","from mail-ej1-x632.google.com (mail-ej1-x632.google.com\n\t[IPv6:2a00:1450:4864:20::632])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 585A6602AE\n\tfor ;\n\tWed, 26 May 2021 15:48:31 +0200 (CEST)","by mail-ej1-x632.google.com with SMTP id lg14so2552422ejb.9\n\tfor ;\n\tWed, 26 May 2021 06:48:31 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"heLvFR+1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=bESjrl0KJDap8+fhJ1VV/46fXmstALHdvog9fVe2Jwk=;\n\tb=heLvFR+1dvhh2nCjqOTWj97NBMlTewRfSaGKpjQITXg/ClwuooQ0JCsGyBP30CxsO+\n\tsaIGJf23VIKc4NDqg6g7RcWYj+D60TFC1jhpMtDkC/NEl11UPmrDfGOPuoW+NglQQvS2\n\tYiQvsRNDvLwRoVlfjYflY1RX/zSRow8tE9Pgo=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=bESjrl0KJDap8+fhJ1VV/46fXmstALHdvog9fVe2Jwk=;\n\tb=POOXCEEBuB9gF5SXLLw7f0K4aLMhMEPpEVHtwIlfcTfP2vk+62xa/T/cYn2qNzJTnF\n\tAJ/X3BhheQ/gt6f5mxI7cR3GQYXVvuOsNbhpD0R78sjisdcGdRord9JQW7IQpHomDqlQ\n\tGdZAbZTsjRWZ0E5qKrkz+4QDrtPj7he+2chRFfUP2XuIyncCCqWZ+4ERn92m5Qx/FlxX\n\tDcVXPf0EXrUd6W8Wnkhn9mpGi+xq7x4eDoaTJikxOKssJmJME/kVVdmyRhK+o43YqXNV\n\tY/Fz7G83xUlEe7budbwEVW7482P7POkLP89D2y5cfxxSOVLq805BaXpYHwpTrgbD2NGk\n\tDusA==","X-Gm-Message-State":"AOAM530JYGshLYSYUao+bkzaOv3PZ3FjV23V4QEAz87qmMlJxipV8lqC\n\tFzbLSh0sn6zGeURkNYKq4Hh/eR+QQ1ogM3ZHVA0Xdg==","X-Google-Smtp-Source":"ABdhPJzVAlFuzJ7xxZhlJ6eiGtcfAlctV2Ph15POW4ll9/IpO/Jfp3r6WtYV8QcFDvT+5PVl1xkQPDgsYoirwx8UYb8=","X-Received":"by 2002:a17:906:3a04:: with SMTP id\n\tz4mr33512086eje.221.1622036910934; \n\tWed, 26 May 2021 06:48:30 -0700 (PDT)","MIME-Version":"1.0","References":"<20210526131025.675024-1-umang.jain@ideasonboard.com>\n\t<20210526131025.675024-2-umang.jain@ideasonboard.com>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Wed, 26 May 2021 22:48:20 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"000000000000e3a03d05c33be598\"","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] pipeline: ipu3: Fix\n\tmis-aligned comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]