{"id":12428,"url":"https://patchwork.libcamera.org/api/patches/12428/?format=json","web_url":"https://patchwork.libcamera.org/patch/12428/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210526130129.673747-3-umang.jain@ideasonboard.com>","date":"2021-05-26T13:01:29","name":"[libcamera-devel,2/2] ipa: ipu3: Provide frame timestamps through IPU3Event","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e02b9072628bd6fa50e7558634a0fa18d3f06bbc","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12428/mbox/","series":[{"id":2074,"url":"https://patchwork.libcamera.org/api/series/2074/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2074","date":"2021-05-26T13:01:27","name":"ipa: ipu3: Provide frame timestamps through IPU3Event","version":1,"mbox":"https://patchwork.libcamera.org/series/2074/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12428/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12428/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4FE6FBDB80\n\tfor ;\n\tWed, 26 May 2021 13:01:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18AC868926;\n\tWed, 26 May 2021 15:01:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC390602AB\n\tfor ;\n\tWed, 26 May 2021 15:01:56 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.203])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 72BC9908;\n\tWed, 26 May 2021 15:01:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"milX/2so\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622034116;\n\tbh=npvSDX2wAzK4ci0yCR5y+iXpsy/7YM9vM0+s8C160n4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=milX/2sou6YfV5Sd2w8+InoTRX3WQ1E6ZA9aMavJK38eNJMBNWXjJL2Ny/cSddFJg\n\tET8NqFh5Lqn/Is8/256VPNwxLeh1tAMzHVS8+pSAEOGQIyQuZykMdd3c7/+9ceDjIr\n\tFgcPUVijp2k6RrnfcC8+l9yResp/88yESYsboTQo=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 26 May 2021 18:31:29 +0530","Message-Id":"<20210526130129.673747-3-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.26.2","In-Reply-To":"<20210526130129.673747-1-umang.jain@ideasonboard.com>","References":"<20210526130129.673747-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] ipa: ipu3: Provide frame timestamps\n\tthrough IPU3Event","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Pass in frame timestamps from IPU3 pipeline handler to IPU3 IPA via\nIPU3Event. Frame timestamps are helpful to IPA algorithms to\nconvergence, by setting them via IPA stats.\n\nSigned-off-by: Umang Jain \nChange-Id: Ide5ce34d27533e90e8826ec31e2ca18f5d5f3f19\n---\n include/libcamera/ipa/ipu3.mojom | 1 +\n src/ipa/ipu3/ipu3.cpp | 4 +++-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +++--\n 3 files changed, 7 insertions(+), 3 deletions(-)","diff":"diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\nindex 32c046ad..29b4c805 100644\n--- a/include/libcamera/ipa/ipu3.mojom\n+++ b/include/libcamera/ipa/ipu3.mojom\n@@ -21,6 +21,7 @@ enum IPU3Operations {\n struct IPU3Event {\n \tIPU3Operations op;\n \tuint32 frame;\n+\tint64 frameTimestamp;\n \tuint32 bufferId;\n \tlibcamera.ControlList controls;\n };\ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 769c24d3..581297be 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -53,6 +53,7 @@ private:\n \tvoid processControls(unsigned int frame, const ControlList &controls);\n \tvoid fillParams(unsigned int frame, ipu3_uapi_params *params);\n \tvoid parseStatistics(unsigned int frame,\n+\t\t\t int64_t frameTimestamp,\n \t\t\t const ipu3_uapi_stats_3a *stats);\n \n \tvoid setControls(unsigned int frame);\n@@ -214,7 +215,7 @@ void IPAIPU3::processEvent(const IPU3Event &event)\n \t\tconst ipu3_uapi_stats_3a *stats =\n \t\t\treinterpret_cast(mem.data());\n \n-\t\tparseStatistics(event.frame, stats);\n+\t\tparseStatistics(event.frame, event.frameTimestamp, stats);\n \t\tbreak;\n \t}\n \tcase EventFillParams: {\n@@ -257,6 +258,7 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)\n }\n \n void IPAIPU3::parseStatistics(unsigned int frame,\n+\t\t\t [[maybe_unused]] int64_t frameTimestamp,\n \t\t\t [[maybe_unused]] const ipu3_uapi_stats_3a *stats)\n {\n \tControlList ctrls(controls::controls);\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 750880ed..58923bc7 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -1357,6 +1357,8 @@ void IPU3CameraData::statBufferReady(FrameBuffer *buffer)\n \tif (!info)\n \t\treturn;\n \n+\tRequest *request = info->request;\n+\n \tif (buffer->metadata().status == FrameMetadata::FrameCancelled) {\n \t\tinfo->metadataProcessed = true;\n \n@@ -1364,8 +1366,6 @@ void IPU3CameraData::statBufferReady(FrameBuffer *buffer)\n \t\t * tryComplete() will delete info if it completes the IPU3Frame.\n \t\t * In that event, we must have obtained the Request before hand.\n \t\t */\n-\t\tRequest *request = info->request;\n-\n \t\tif (frameInfos_.tryComplete(info))\n \t\t\tpipe_->completeRequest(request);\n \n@@ -1376,6 +1376,7 @@ void IPU3CameraData::statBufferReady(FrameBuffer *buffer)\n \tev.op = ipa::ipu3::EventStatReady;\n \tev.frame = info->id;\n \tev.bufferId = info->statBuffer->cookie();\n+\tev.frameTimestamp = request->metadata().get(controls::SensorTimestamp);\n \tipa_->processEvent(ev);\n }\n \n","prefixes":["libcamera-devel","2/2"]}