[{"id":17250,"web_url":"https://patchwork.libcamera.org/comment/17250/","msgid":"","date":"2021-05-26T06:44:56","subject":"Re: [libcamera-devel] [PATCH 1/2] android: camera_hal_config: Move\n\tinclude to .cpp file","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent, thank you for the patch.\n\nOn Wed, May 26, 2021 at 9:09 AM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> The header isn't needed in camera_hal_config.h, move its\n> inclusion to camera_hal_config.cpp.\n>\n> Signed-off-by: Laurent Pinchart \n>\n\nReviewed-by: Hirokazu Honda \n\n\n> ---\n> src/android/camera_hal_config.cpp | 1 +\n> src/android/camera_hal_config.h | 1 -\n> 2 files changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_hal_config.cpp\n> b/src/android/camera_hal_config.cpp\n> index 12d69a3f5f3c..d15df2e30c2c 100644\n> --- a/src/android/camera_hal_config.cpp\n> +++ b/src/android/camera_hal_config.cpp\n> @@ -6,6 +6,7 @@\n> */\n> #include \"camera_hal_config.h\"\n>\n> +#include \n> #include \n> #include \n> #include \n> diff --git a/src/android/camera_hal_config.h\n> b/src/android/camera_hal_config.h\n> index 0555c6da2c20..97dc69c1def5 100644\n> --- a/src/android/camera_hal_config.h\n> +++ b/src/android/camera_hal_config.h\n> @@ -7,7 +7,6 @@\n> #ifndef __ANDROID_CAMERA_HAL_CONFIG_H__\n> #define __ANDROID_CAMERA_HAL_CONFIG_H__\n>\n> -#include \n> #include \n> #include \n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 549E7C3200\n\tfor ;\n\tWed, 26 May 2021 06:45:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A485868922;\n\tWed, 26 May 2021 08:45:09 +0200 (CEST)","from mail-ed1-x534.google.com (mail-ed1-x534.google.com\n\t[IPv6:2a00:1450:4864:20::534])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 780FD6891B\n\tfor ;\n\tWed, 26 May 2021 08:45:07 +0200 (CEST)","by mail-ed1-x534.google.com with SMTP id j10so21597182edw.8\n\tfor ;\n\tTue, 25 May 2021 23:45:07 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"njk2BAYb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=SKltcmKWGp+c/l1t86uXSzxYreqVzBKELSeiENQaGJ8=;\n\tb=njk2BAYbXJl22DsQUeCTj44+8dL83j8dozgfLUP9sQ1kAeTAdihXR+cuP1/2dDM7Mj\n\t8pmbP26jTm6QJx0AKUKjZ/U1gOed9ZSsSBpopmmsN4jAiW/16m7sOXQWf0fU7U6zrnre\n\tmJBQiRWmv912nyFedEv7S9v0e83eXNcxz6tDg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=SKltcmKWGp+c/l1t86uXSzxYreqVzBKELSeiENQaGJ8=;\n\tb=Hj3LPXtHj4pYVm5cNUWyU2v2vm/3/6hA7tmpo5ryUXMQhuFGW1wdD0wOcoup2UyoP8\n\tes3tflwtr5YDjaViktpBZn+N/HYv94QPCjnXC1hWjuxj1V2Q/+x82KjmbguwaXmvkcry\n\tEuZPD4auXl2D21p9u//gH8e/tEh/cXwZsD0rttk+Aj918RPkPqK7jsb8UZc1PSp59MeR\n\tP5tI4tpapAy8DLkkw2DS6p9OLCtY3/yXZ/sSq/zKCifEz/Qo8KIZHNoG6AhjXH5YPcpC\n\tyCZmb41Pl7oRRzI4xTt+v0oksVPZq+4RyefH8vmJLP6bDfap9AS5XIn2oc3qdwrJTp8B\n\tiJnQ==","X-Gm-Message-State":"AOAM531pXr7Q8Ec2gh+FF8hsoiSnmMn2KqVd/+wzyEpTiXFPdmtzUiDq\n\t5IRWk8vwdPWkqJfpiHqTJMVZO8sqdFqemt7VWarVnWniNKI=","X-Google-Smtp-Source":"ABdhPJyXLCYeoFXXe6vYb4yVbwr9JUrI+vMIO7ubwpjhl4is5r4SuwDisWgaP18JEDOC4tFjpsVvnKh6ZgJcYL33TUg=","X-Received":"by 2002:a50:8e44:: with SMTP id 4mr36116874edx.244.1622011507209;\n\tTue, 25 May 2021 23:45:07 -0700 (PDT)","MIME-Version":"1.0","References":"<20210526000855.17501-1-laurent.pinchart@ideasonboard.com>\n\t<20210526000855.17501-2-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20210526000855.17501-2-laurent.pinchart@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Wed, 26 May 2021 15:44:56 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"000000000000b585cd05c335fbec\"","Subject":"Re: [libcamera-devel] [PATCH 1/2] android: camera_hal_config: Move\n\tinclude to .cpp file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17256,"web_url":"https://patchwork.libcamera.org/comment/17256/","msgid":"<20210526075313.5qhsviq2rbjpxi3r@uno.localdomain>","date":"2021-05-26T07:53:13","subject":"Re: [libcamera-devel] [PATCH 1/2] android: camera_hal_config: Move\n\tinclude to .cpp file","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Wed, May 26, 2021 at 03:08:54AM +0300, Laurent Pinchart wrote:\n> The header isn't needed in camera_hal_config.h, move its\n> inclusion to camera_hal_config.cpp.\n>\n> Signed-off-by: Laurent Pinchart \n\nAcked-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/android/camera_hal_config.cpp | 1 +\n> src/android/camera_hal_config.h | 1 -\n> 2 files changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\n> index 12d69a3f5f3c..d15df2e30c2c 100644\n> --- a/src/android/camera_hal_config.cpp\n> +++ b/src/android/camera_hal_config.cpp\n> @@ -6,6 +6,7 @@\n> */\n> #include \"camera_hal_config.h\"\n>\n> +#include \n> #include \n> #include \n> #include \n> diff --git a/src/android/camera_hal_config.h b/src/android/camera_hal_config.h\n> index 0555c6da2c20..97dc69c1def5 100644\n> --- a/src/android/camera_hal_config.h\n> +++ b/src/android/camera_hal_config.h\n> @@ -7,7 +7,6 @@\n> #ifndef __ANDROID_CAMERA_HAL_CONFIG_H__\n> #define __ANDROID_CAMERA_HAL_CONFIG_H__\n>\n> -#include \n> #include \n> #include \n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E757EC3203\n\tfor ;\n\tWed, 26 May 2021 07:52:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AAF7468922;\n\tWed, 26 May 2021 09:52:29 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 06D996891E\n\tfor ;\n\tWed, 26 May 2021 09:52:28 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 8FDCA20001A;\n\tWed, 26 May 2021 07:52:27 +0000 (UTC)"],"Date":"Wed, 26 May 2021 09:53:13 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210526075313.5qhsviq2rbjpxi3r@uno.localdomain>","References":"<20210526000855.17501-1-laurent.pinchart@ideasonboard.com>\n\t<20210526000855.17501-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210526000855.17501-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] android: camera_hal_config: Move\n\tinclude to .cpp file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17261,"web_url":"https://patchwork.libcamera.org/comment/17261/","msgid":"","date":"2021-05-26T08:15:55","subject":"Re: [libcamera-devel] [PATCH 1/2] android: camera_hal_config: Move\n\tinclude to .cpp file","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2021-05-26 03:08:54 +0300, Laurent Pinchart wrote:\n> The header isn't needed in camera_hal_config.h, move its\n> inclusion to camera_hal_config.cpp.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_hal_config.cpp | 1 +\n> src/android/camera_hal_config.h | 1 -\n> 2 files changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\n> index 12d69a3f5f3c..d15df2e30c2c 100644\n> --- a/src/android/camera_hal_config.cpp\n> +++ b/src/android/camera_hal_config.cpp\n> @@ -6,6 +6,7 @@\n> */\n> #include \"camera_hal_config.h\"\n> \n> +#include \n> #include \n> #include \n> #include \n> diff --git a/src/android/camera_hal_config.h b/src/android/camera_hal_config.h\n> index 0555c6da2c20..97dc69c1def5 100644\n> --- a/src/android/camera_hal_config.h\n> +++ b/src/android/camera_hal_config.h\n> @@ -7,7 +7,6 @@\n> #ifndef __ANDROID_CAMERA_HAL_CONFIG_H__\n> #define __ANDROID_CAMERA_HAL_CONFIG_H__\n> \n> -#include \n> #include \n> #include \n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 060B9C3203\n\tfor ;\n\tWed, 26 May 2021 08:15:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7C7CB6891F;\n\tWed, 26 May 2021 10:15:58 +0200 (CEST)","from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com\n\t[IPv6:2a00:1450:4864:20::12c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1AE06891E\n\tfor ;\n\tWed, 26 May 2021 10:15:56 +0200 (CEST)","by mail-lf1-x12c.google.com with SMTP id r5so1239363lfr.5\n\tfor ;\n\tWed, 26 May 2021 01:15:56 -0700 (PDT)","from localhost (h-62-63-236-217.A463.priv.bahnhof.se.\n\t[62.63.236.217]) by smtp.gmail.com with ESMTPSA id\n\th16sm2339890ljb.128.2021.05.26.01.15.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 May 2021 01:15:55 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"B1CY4cYV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=DAIs3cCB4Xs5D9V9CU5AltCy47qfo0vBPUxmWTk4/8Q=;\n\tb=B1CY4cYVLJn1vIOcA28iVf/dVUp5fVo/corYBtCcUJiDuA8CLxhBWVnR4Nc+rD4T5P\n\tnVlNXWy3C6d6Qet/4+TQav1QiBJaqeTm1PAVpgEWu3fJ4mfQNmC1qCCi6+byDB3rFfZr\n\tyQLo0FtHG0LXwduN9+v/t+aJYgIx1uOMhBcq4tOJadWw06S14V1pGGFJMuSEruSMmGZk\n\tupVBsH86DG4D0biCJgfEGTlJlbfKAiX7Q9B42UZ6nmH5FsCr01CAgOGqjUlmPMxaQZSg\n\t5UHlg7lQHazTxtk87r7QEosE0B0lR/8ziR/FjufsvErm2WXk0/Yl0wAvqkeW7jEzDUOO\n\tpg/Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=DAIs3cCB4Xs5D9V9CU5AltCy47qfo0vBPUxmWTk4/8Q=;\n\tb=t8xs4ZZG/Qh/5P1E1OqDvMVmwHgcgmfOn1Z4I3+cylIfDi9gV1B+DX8vn/PPSXNolh\n\t/QBd6288SRwPLZAhrrP7fp262x4mTPeJqPpYq6RwXsCn1+ptz/FSRFaREqeKEbz5c/rA\n\tYl04XpfgluaVDbqma1hP4PswUHMvLw65/QN+qc07vcsPzjYQ7gHdk/K5t4o3k6+3KUPg\n\t5g+tK3UYkL9GRtV5WH1owsuiDB0c8qXCNy63k8aHQrQu4IWnL90q1y3MUFjIQuBcMmnV\n\ta3SotzmhcbektDdEH+PiomXIxdYLkeKZ3r9jtIhLvCHjUAVtiYNSAC8VH3Q5gWyCo6WO\n\tSW9Q==","X-Gm-Message-State":"AOAM530+MxauFsbZBezhqzyNPN/K4I/YInGB1f1/zKiGSiawSGJI9W90\n\tLd+6MDpqvlZckzL1cUvfUoMB27nYBtHjYg==","X-Google-Smtp-Source":"ABdhPJwUQSB9D1WWjeoe9k+lLL3wJ8Ahhu98/jgjNR1f7M2i/cyh7z7ELg3T/mbNJHWknbEhqOMySw==","X-Received":"by 2002:a05:6512:28e:: with SMTP id\n\tj14mr1309251lfp.360.1622016956231; \n\tWed, 26 May 2021 01:15:56 -0700 (PDT)","Date":"Wed, 26 May 2021 10:15:55 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20210526000855.17501-1-laurent.pinchart@ideasonboard.com>\n\t<20210526000855.17501-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20210526000855.17501-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] android: camera_hal_config: Move\n\tinclude to .cpp file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]