[{"id":17241,"web_url":"https://patchwork.libcamera.org/comment/17241/","msgid":"<20210525102407.x5fr2ugkqy42jssv@uno.localdomain>","date":"2021-05-25T10:24:07","subject":"Re: [libcamera-devel] [PATCH v3 2/3] android: camera_device: Fix\n\tsensor frame duration","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Tue, May 25, 2021 at 06:18:11PM +0900, Paul Elder wrote:\n> The sensor frame duration should be set by IPA. Get the information for\n> the result metadata from libcamera.\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/android/camera_device.cpp | 6 ++++++\n> 1 file changed, 6 insertions(+)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 0eea2b95..70173424 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -2252,6 +2252,12 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons\n> \t\tresultMetadata->addEntry(ANDROID_SENSOR_EXPOSURE_TIME, exposure);\n> \t}\n>\n> +\tif (metadata.contains(controls::FrameDuration)) {\n> +\t\tint64_t duration = metadata.get(controls::FrameDuration) * 1000;\n> +\t\tresultMetadata->addEntry(ANDROID_SENSOR_FRAME_DURATION,\n> +\t\t\t\t\t duration);\n> +\t}\n> +\n> \tif (metadata.contains(controls::ScalerCrop)) {\n> \t\tRectangle crop = metadata.get(controls::ScalerCrop);\n> \t\tint32_t cropRect[] = {\n> --\n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 189C1C3200\n\tfor ;\n\tTue, 25 May 2021 10:23:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DFC206891F;\n\tTue, 25 May 2021 12:23:22 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B8C3F6050E\n\tfor ;\n\tTue, 25 May 2021 12:23:21 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 509F260011;\n\tTue, 25 May 2021 10:23:21 +0000 (UTC)"],"Date":"Tue, 25 May 2021 12:24:07 +0200","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20210525102407.x5fr2ugkqy42jssv@uno.localdomain>","References":"<20210525091812.1225580-1-paul.elder@ideasonboard.com>\n\t<20210525091812.1225580-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210525091812.1225580-2-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 2/3] android: camera_device: Fix\n\tsensor frame duration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17252,"web_url":"https://patchwork.libcamera.org/comment/17252/","msgid":"","date":"2021-05-26T06:51:36","subject":"Re: [libcamera-devel] [PATCH v3 2/3] android: camera_device: Fix\n\tsensor frame duration","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Paul, thank you for the patch.\n\nOn Tue, May 25, 2021 at 7:23 PM Jacopo Mondi wrote:\n\n> Hi Paul,\n>\n> On Tue, May 25, 2021 at 06:18:11PM +0900, Paul Elder wrote:\n> > The sensor frame duration should be set by IPA. Get the information for\n> > the result metadata from libcamera.\n> >\n> > Signed-off-by: Paul Elder \n> > Reviewed-by: Laurent Pinchart \n>\n> Reviewed-by: Jacopo Mondi \n>\n>\nReviewed-by: Hirokazu Honda \n\n\n> Thanks\n> j\n>\n> > ---\n> > src/android/camera_device.cpp | 6 ++++++\n> > 1 file changed, 6 insertions(+)\n> >\n> > diff --git a/src/android/camera_device.cpp\n> b/src/android/camera_device.cpp\n> > index 0eea2b95..70173424 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -2252,6 +2252,12 @@ CameraDevice::getResultMetadata(const\n> Camera3RequestDescriptor &descriptor) cons\n> > resultMetadata->addEntry(ANDROID_SENSOR_EXPOSURE_TIME,\n> exposure);\n> > }\n> >\n> > + if (metadata.contains(controls::FrameDuration)) {\n> > + int64_t duration = metadata.get(controls::FrameDuration) *\n> 1000;\n> > + resultMetadata->addEntry(ANDROID_SENSOR_FRAME_DURATION,\n> > + duration);\n> > + }\n> > +\n> > if (metadata.contains(controls::ScalerCrop)) {\n> > Rectangle crop = metadata.get(controls::ScalerCrop);\n> > int32_t cropRect[] = {\n> > --\n> > 2.27.0\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA842C3203\n\tfor ;\n\tWed, 26 May 2021 06:51:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9080D68922;\n\tWed, 26 May 2021 08:51:49 +0200 (CEST)","from mail-ej1-x636.google.com (mail-ej1-x636.google.com\n\t[IPv6:2a00:1450:4864:20::636])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 138336891B\n\tfor ;\n\tWed, 26 May 2021 08:51:48 +0200 (CEST)","by mail-ej1-x636.google.com with SMTP id gb17so675821ejc.8\n\tfor ;\n\tTue, 25 May 2021 23:51:48 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"D+WUqcyH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=Yh4UIs3Dtyx3+L+ZZbMbOfc5PE5JNqm/01AAVba6FEc=;\n\tb=D+WUqcyHw/+yyX7aHRbqEpO1Jn7bd41jkmiR8tDv+8DMdhCbSzIUtgjuziQ6PxOqUZ\n\tLrQqNRlh/gswAhIDox+WYNAB7U1YfPoKHX4sv62FwHWLrD9zKXoGRKOTyfnScGC/cNg8\n\t3tIYNc+dHsGVMOYp2nVGfuVYVmaUu3zZaT0Yo=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Yh4UIs3Dtyx3+L+ZZbMbOfc5PE5JNqm/01AAVba6FEc=;\n\tb=FOp+jTDL0oHJl4EkLOU6QrphLFGE6K3RV8NzEEC16hLC+XGAayzIvsHI4U6akvMLMJ\n\t1MMzMxJ0HEBebd0n/NsA7sQQ3mBQBcS/BoiyI5KY9A8mv5uHm+icWSNyYyhN9BQzz0WR\n\tviJMAfEjarNXLdD8RiXnl7zqP4eA9KCcmWvg8Do5pFxyyxGbAx1G20tVSKJ9Ig1axKIM\n\tM44vmjZ0isU399/RBUOkjzQpsMcvQMeKwdbiegAjciQkVsiZxkXD8ldJvOyJjdmcjdLv\n\t1MdTGat5qr2naEU313AMdH7iCx+mLueLppLwogfQMx2x5twFYX7+A/lTqo/rSzIwTJBx\n\tyiVw==","X-Gm-Message-State":"AOAM530vMwSiOuTzY7fVYS6JRJe4RJF2N4vSftdIGShJFObHN23jC7R7\n\tLuQByD0uqs+4MUkH/1uei944JvGe8SbiCDIRr33wrm9oaI8=","X-Google-Smtp-Source":"ABdhPJxCJPRjw8qi6j8+iFcbp8IdgKSnQrnQ4K9tJNGn02qbSHrzccZ8v6XlySx+M2BsSRbKmeGTf/79qtt0OEAuPv0=","X-Received":"by 2002:a17:906:b84b:: with SMTP id\n\tga11mr19815782ejb.243.1622011907825; \n\tTue, 25 May 2021 23:51:47 -0700 (PDT)","MIME-Version":"1.0","References":"<20210525091812.1225580-1-paul.elder@ideasonboard.com>\n\t<20210525091812.1225580-2-paul.elder@ideasonboard.com>\n\t<20210525102407.x5fr2ugkqy42jssv@uno.localdomain>","In-Reply-To":"<20210525102407.x5fr2ugkqy42jssv@uno.localdomain>","From":"Hirokazu Honda ","Date":"Wed, 26 May 2021 15:51:36 +0900","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"multipart/alternative; boundary=\"00000000000096712305c336139f\"","Subject":"Re: [libcamera-devel] [PATCH v3 2/3] android: camera_device: Fix\n\tsensor frame duration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]