[{"id":167,"web_url":"https://patchwork.libcamera.org/comment/167/","msgid":"<8891347.gWyzlTL7CM@avalon>","date":"2019-01-02T09:15:24","subject":"Re: [libcamera-devel] [PATCH 3/5] test: Move include definitions to\n\tlibtest","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tuesday, 1 January 2019 23:29:45 EET Kieran Bingham wrote:\n> With the libtest functionality moved to it's own library folder, the\n\ns/it's/its/\n\n> definitions for test inlcludes should reasonably live there too.\n\ns/inlcludes/includes/\n\n> \n> The libtest subdir should always remain the first entry in the\n> test/meson.build file.\n> \n> Signed-off-by: Kieran Bingham \n\nWith this fixed, for 1-3,\n\nReviewed-by: Laurent Pinchart \n\nand pushed.\n\n> ---\n> test/libtest/meson.build | 12 ++++++++++++\n> test/meson.build | 12 ------------\n> 2 files changed, 12 insertions(+), 12 deletions(-)\n> \n> diff --git a/test/libtest/meson.build b/test/libtest/meson.build\n> index b998154dd8d3..e0893b70c3d4 100644\n> --- a/test/libtest/meson.build\n> +++ b/test/libtest/meson.build\n> @@ -5,3 +5,15 @@ libtest_sources = files([\n> libtest = static_library('libtest', libtest_sources)\n> \n> libtest_includes = include_directories('.')\n> +\n> +test_libraries = [libcamera, libtest]\n> +\n> +test_includes_public = [\n> + libtest_includes,\n> + libcamera_includes,\n> +]\n> +\n> +test_includes_internal = [\n> + test_includes_public,\n> + libcamera_internal_includes,\n> +]\n> diff --git a/test/meson.build b/test/meson.build\n> index bf8232f32787..9270a55e052a 100644\n> --- a/test/meson.build\n> +++ b/test/meson.build\n> @@ -1,17 +1,5 @@\n> subdir('libtest')\n> \n> -test_libraries = [libcamera, libtest]\n> -\n> -test_includes_public = [\n> - libtest_includes,\n> - libcamera_includes,\n> -]\n> -\n> -test_includes_internal = [\n> - test_includes_public,\n> - libcamera_internal_includes,\n> -]\n> -\n> subdir('media_device')\n> \n> public_tests = [","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BCF0B60B30\n\tfor ;\n\tWed, 2 Jan 2019 10:14:24 +0100 (CET)","from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 31EBF505;\n\tWed, 2 Jan 2019 10:14:24 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546420464;\n\tbh=oWowAiCFzEQCf8bdPcBa/yyKj0ZSsnYcGEPXP22EBvk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=e94PHXI79mSTUHYmTKjZeVi+2C5TGv4t4nLlFmhQGsCs6DOH9GNvDdY5nvV5cscT5\n\tl0Qahfy4ApBbvRRu3APsMt9b5HD3xuBha8+YnB9YrW0UJhe5hmR+SsoT5jHYMPk9og\n\tGWuqmKdifIu0J9K54Oo97JCkndgdSMHta1VmJmb4=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 02 Jan 2019 11:15:24 +0200","Message-ID":"<8891347.gWyzlTL7CM@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"<20190101212947.28098-4-kieran.bingham@ideasonboard.com>","References":"<20190101212947.28098-1-kieran.bingham@ideasonboard.com>\n\t<20190101212947.28098-4-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Subject":"Re: [libcamera-devel] [PATCH 3/5] test: Move include definitions to\n\tlibtest","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 02 Jan 2019 09:14:25 -0000"}}]