[{"id":17227,"web_url":"https://patchwork.libcamera.org/comment/17227/","msgid":"","date":"2021-05-25T09:03:20","subject":"Re: [libcamera-devel] [PATCH] libcamera: add OV5693 sensor\n\tproperties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Tue, May 25, 2021 at 07:56:14AM +0200, jeanmichel.hautbois@ideasonboard.com wrote:\n> From: Jean-Michel Hautbois \n> \n> The new sensor database has introduced several sensors, but ov5693 is\n> missing.\n> It is used on most MS Surface tablets, add it to the database.\n> \n> Signed-off-by: Jean-Michel Hautbois \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/camera_sensor_properties.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 6ded31dc..2a6e97f7 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -54,6 +54,9 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t{ \"ov13858\", {\n> \t\t\t.unitCellSize = { 1120, 1120 },\n> \t\t} },\n> +\t\t{ \"ov5693\", {\n> +\t\t\t.unitCellSize = { 1400, 1400 },\n> +\t\t} },\n> \t};\n> \n> \tconst auto it = sensorProps.find(sensor);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 38E31C3200\n\tfor ;\n\tTue, 25 May 2021 09:03:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9CBAB68921;\n\tTue, 25 May 2021 11:03:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37C1A602AF\n\tfor ;\n\tTue, 25 May 2021 11:03:26 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4CA1F344;\n\tTue, 25 May 2021 11:03:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J7fohb08\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621933405;\n\tbh=uEXRldYoSPnPMO5fcZHcy8sx1h/SyuaLEXISvD678us=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=J7fohb08odXJwHBCu5AiuoL80VTjZagtIpJWKieHynE/q1laO7Av70QBS5pe3/rbM\n\tgNmDhgbRs8dLFPDFuitHsqR4g9hBpYBBa+cjwXFHkneVZo0Vr0fnD8TeSIF9Qx5Wi2\n\txYRca1tEBeWZHY6s7EMlckenxWzn8IaRBJY3PQgA=","Date":"Tue, 25 May 2021 12:03:20 +0300","From":"Laurent Pinchart ","To":"jeanmichel.hautbois@ideasonboard.com","Message-ID":"","References":"<20210525055614.13417-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210525055614.13417-1-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: add OV5693 sensor\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17235,"web_url":"https://patchwork.libcamera.org/comment/17235/","msgid":"<55cd31bb-0d7c-d050-646e-5ed4b56bae08@ideasonboard.com>","date":"2021-05-25T09:16:00","subject":"Re: [libcamera-devel] [PATCH] libcamera: add OV5693 sensor\n\tproperties","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi JM\n\nThanks for the patch\n\nOn 5/25/21 11:26 AM, jeanmichel.hautbois@ideasonboard.com wrote:\n> From: Jean-Michel Hautbois \n>\n> The new sensor database has introduced several sensors, but ov5693 is\n> missing.\n> It is used on most MS Surface tablets, add it to the database.\n>\n> Signed-off-by: Jean-Michel Hautbois \nReviewed-by: Umang Jain \n> ---\n> src/libcamera/camera_sensor_properties.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n>\n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 6ded31dc..2a6e97f7 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -54,6 +54,9 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t{ \"ov13858\", {\n> \t\t\t.unitCellSize = { 1120, 1120 },\n> \t\t} },\n> +\t\t{ \"ov5693\", {\n> +\t\t\t.unitCellSize = { 1400, 1400 },\n> +\t\t} },\n> \t};\n> \n> \tconst auto it = sensorProps.find(sensor);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20B32C3200\n\tfor ;\n\tTue, 25 May 2021 09:16:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8169D68921;\n\tTue, 25 May 2021 11:16:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D0525602AF\n\tfor ;\n\tTue, 25 May 2021 11:16:07 +0200 (CEST)","from localhost.localdomain (unknown [103.251.226.203])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 99B7B344;\n\tTue, 25 May 2021 11:16:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"W1h1NbfK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621934167;\n\tbh=wD+yQQtso5h6qNlqewkF535GxbMq5rUZ2U2NaqHze5U=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=W1h1NbfKnaNeJquJcX6j67/TXheVrWUwR9+y/O+VUzyeglVzfnpRCUmA/iVL6Jei8\n\tfN+PR/xYJu6eiDVi64f/21GIMVxGoBMER+ZT77fZojHDbRFyxjRuq1H3iH6TWlaqCz\n\tSVc1TIgSYY0VugVFjQpKox0JB8lutuysXETAszwE=","To":"jeanmichel.hautbois@ideasonboard.com, libcamera-devel@lists.libcamera.org","References":"<20210525055614.13417-1-jeanmichel.hautbois@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<55cd31bb-0d7c-d050-646e-5ed4b56bae08@ideasonboard.com>","Date":"Tue, 25 May 2021 14:46:00 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.11.0","MIME-Version":"1.0","In-Reply-To":"<20210525055614.13417-1-jeanmichel.hautbois@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: add OV5693 sensor\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17243,"web_url":"https://patchwork.libcamera.org/comment/17243/","msgid":"<20210525103802.ungy2k4coe7bebg3@uno.localdomain>","date":"2021-05-25T10:38:02","subject":"Re: [libcamera-devel] [PATCH] libcamera: add OV5693 sensor\n\tproperties","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Jm\n\nOn Tue, May 25, 2021 at 07:56:14AM +0200, jeanmichel.hautbois@ideasonboard.com wrote:\n> From: Jean-Michel Hautbois \n>\n> The new sensor database has introduced several sensors, but ov5693 is\n> missing.\n> It is used on most MS Surface tablets, add it to the database.\n>\n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/libcamera/camera_sensor_properties.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n>\n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 6ded31dc..2a6e97f7 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -54,6 +54,9 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t{ \"ov13858\", {\n> \t\t\t.unitCellSize = { 1120, 1120 },\n> \t\t} },\n> +\t\t{ \"ov5693\", {\n> +\t\t\t.unitCellSize = { 1400, 1400 },\n\nDon't have a datasheet to very, so I assume that's correct!\n\nReviewed-by: Jacopo Mondi \n\nthanks\n j\n\n> +\t\t} },\n> \t};\n>\n> \tconst auto it = sensorProps.find(sensor);\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EEA92C3202\n\tfor ;\n\tTue, 25 May 2021 10:37:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BEB9568918;\n\tTue, 25 May 2021 12:37:18 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8B216050E\n\tfor ;\n\tTue, 25 May 2021 12:37:16 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 643211C0004;\n\tTue, 25 May 2021 10:37:16 +0000 (UTC)"],"Date":"Tue, 25 May 2021 12:38:02 +0200","From":"Jacopo Mondi ","To":"jeanmichel.hautbois@ideasonboard.com","Message-ID":"<20210525103802.ungy2k4coe7bebg3@uno.localdomain>","References":"<20210525055614.13417-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210525055614.13417-1-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: add OV5693 sensor\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17310,"web_url":"https://patchwork.libcamera.org/comment/17310/","msgid":"","date":"2021-05-27T07:02:06","subject":"Re: [libcamera-devel] [PATCH] libcamera: add OV5693 sensor\n\tproperties","submitter":{"id":9,"url":"https://patchwork.libcamera.org/api/people/9/","name":"Tomasz Figa","email":"tfiga@chromium.org"},"content":"On Tue, May 25, 2021 at 7:37 PM Jacopo Mondi wrote:\n>\n> Hi Jm\n>\n> On Tue, May 25, 2021 at 07:56:14AM +0200, jeanmichel.hautbois@ideasonboard.com wrote:\n> > From: Jean-Michel Hautbois \n> >\n> > The new sensor database has introduced several sensors, but ov5693 is\n> > missing.\n> > It is used on most MS Surface tablets, add it to the database.\n> >\n> > Signed-off-by: Jean-Michel Hautbois \n> > ---\n> > src/libcamera/camera_sensor_properties.cpp | 3 +++\n> > 1 file changed, 3 insertions(+)\n> >\n> > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> > index 6ded31dc..2a6e97f7 100644\n> > --- a/src/libcamera/camera_sensor_properties.cpp\n> > +++ b/src/libcamera/camera_sensor_properties.cpp\n> > @@ -54,6 +54,9 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > { \"ov13858\", {\n> > .unitCellSize = { 1120, 1120 },\n> > } },\n> > + { \"ov5693\", {\n> > + .unitCellSize = { 1400, 1400 },\n>\n> Don't have a datasheet to very, so I assume that's correct!\n>\n> Reviewed-by: Jacopo Mondi \n\nI don't see a driver for this sensor in the kernel tree yet. I assume\nthat this patch will wait until the driver is merged?\n\nBest regards,\nTomasz","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 89489BDB80\n\tfor ;\n\tThu, 27 May 2021 07:02:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D871F68924;\n\tThu, 27 May 2021 09:02:23 +0200 (CEST)","from mail-ed1-x532.google.com (mail-ed1-x532.google.com\n\t[IPv6:2a00:1450:4864:20::532])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 927E468920\n\tfor ;\n\tThu, 27 May 2021 09:02:22 +0200 (CEST)","by mail-ed1-x532.google.com with SMTP id o5so4490385edc.5\n\tfor ;\n\tThu, 27 May 2021 00:02:22 -0700 (PDT)","from mail-wr1-f53.google.com (mail-wr1-f53.google.com.\n\t[209.85.221.53]) by smtp.gmail.com with ESMTPSA id\n\tjt11sm509569ejb.83.2021.05.27.00.02.20\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 27 May 2021 00:02:21 -0700 (PDT)","by mail-wr1-f53.google.com with SMTP id n4so3568686wrw.3\n\tfor ;\n\tThu, 27 May 2021 00:02:20 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"UOydUlz1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=UeNSQAxE3WAEkAKD8uvMAIxvoPBsq+7ubBjDsVPAeN8=;\n\tb=UOydUlz1ZdQGX8thXo8jqiufPOcmIFKeLrt8xTXhWLjlHyye+WGNGuqQhF/H+rnZUN\n\tmdEPZRR90/pZS/AQGlRIRLInsjJwQhSomI/ORWSjfQY5xV7qARHHaIBBemZQu2AP6qkZ\n\tjHAwmeSq1mRhSYRHMXu8dAQ39bTsBYK5W3heY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=UeNSQAxE3WAEkAKD8uvMAIxvoPBsq+7ubBjDsVPAeN8=;\n\tb=do2TquhRbHyTLMTLVRTlZzvfK7AXQT0gP4Ii9FkGRezBkT8aeF5Lj+BFQH09arQE8P\n\tcPvVjAjDOWjXSISTvq/VK6keXxCtZByb6CNKH7zYgzTIe2vzntzBGr57UhMbVBOjAkJg\n\telbgiTG40OhUI34mqmbTO3LyVTG7wLKNv9x8cUBRBkWatWV9DZldrAymhnXa+qusHOI1\n\tNRQ915wI2IQJJQLT6XNPZLPVqkMeuKWeXdRU2Htqh1G6XCi56TtdaR15lywao1ALv2Z3\n\todbJBEz0SqKpbCXqdrSPHh2MveWB+lcI0KOUnR7p6SEtdqX8aW1ZaewQM2SfQEfsQtPq\n\tTbPA==","X-Gm-Message-State":"AOAM532P9K110sa7ilSAO8RfrMTwcmzH20MyQDH9pu0ytgkzc8eUDKE/\n\tM2H+lqnfDNNBZ3K3AuWoLP9nG6WpYWiXJg==","X-Google-Smtp-Source":"ABdhPJwlnVyBNgNwLChzPKxO4ZqBRbITNKM5VebAyUMgMjSw3UelhJEjqtXO9aa4+2mEVg9VpKgyOw==","X-Received":["by 2002:aa7:db95:: with SMTP id\n\tu21mr2540673edt.152.1622098941912; \n\tThu, 27 May 2021 00:02:21 -0700 (PDT)","by 2002:a5d:44cb:: with SMTP id\n\tz11mr1729442wrr.159.1622098939834; \n\tThu, 27 May 2021 00:02:19 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20210525055614.13417-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210525103802.ungy2k4coe7bebg3@uno.localdomain>","In-Reply-To":"<20210525103802.ungy2k4coe7bebg3@uno.localdomain>","From":"Tomasz Figa ","Date":"Thu, 27 May 2021 16:02:06 +0900","X-Gmail-Original-Message-ID":"","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: add OV5693 sensor\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17317,"web_url":"https://patchwork.libcamera.org/comment/17317/","msgid":"","date":"2021-05-27T08:23:32","subject":"Re: [libcamera-devel] [PATCH] libcamera: add OV5693 sensor\n\tproperties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomasz,\n\nOn Thu, May 27, 2021 at 04:02:06PM +0900, Tomasz Figa wrote:\n> On Tue, May 25, 2021 at 7:37 PM Jacopo Mondi wrote:\n> > On Tue, May 25, 2021 at 07:56:14AM +0200, jeanmichel.hautbois@ideasonboard.com wrote:\n> > > From: Jean-Michel Hautbois \n> > >\n> > > The new sensor database has introduced several sensors, but ov5693 is\n> > > missing.\n> > > It is used on most MS Surface tablets, add it to the database.\n> > >\n> > > Signed-off-by: Jean-Michel Hautbois \n> > > ---\n> > > src/libcamera/camera_sensor_properties.cpp | 3 +++\n> > > 1 file changed, 3 insertions(+)\n> > >\n> > > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> > > index 6ded31dc..2a6e97f7 100644\n> > > --- a/src/libcamera/camera_sensor_properties.cpp\n> > > +++ b/src/libcamera/camera_sensor_properties.cpp\n> > > @@ -54,6 +54,9 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > > { \"ov13858\", {\n> > > .unitCellSize = { 1120, 1120 },\n> > > } },\n> > > + { \"ov5693\", {\n> > > + .unitCellSize = { 1400, 1400 },\n> >\n> > Don't have a datasheet to very, so I assume that's correct!\n> >\n> > Reviewed-by: Jacopo Mondi \n> \n> I don't see a driver for this sensor in the kernel tree yet. I assume\n> that this patch will wait until the driver is merged?\n\nThe driver has been developed by the linux-surface community\n(https://github.com/linux-surface) and is on its way to upstream, so I'm\nfine with supporting it in libcamera already. Overall, if there's no\nreason to distrust the upstreaming effort, I don't see a reason to wait\nuntil the patches have been merged upstream.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A043CC3203\n\tfor ;\n\tThu, 27 May 2021 08:23:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2B9BE68923;\n\tThu, 27 May 2021 10:23:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C2D2602AA\n\tfor ;\n\tThu, 27 May 2021 10:23:39 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 959C6B2C;\n\tThu, 27 May 2021 10:23:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"e8uk6syA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622103818;\n\tbh=z4qX1GzLh27tKLBljdjvSU/Q3fEwwlPoVAn6xVCqR1s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=e8uk6syAkBFy7tRwkUz48izJYKdiWkeKo4i+Y/RUVnj+gXOeV73JRLZg2J8aUtmJa\n\t8O0mZaXBp1u08OsAG5ZVTqLjaN3pgOP++9M/5PAjIT37T3TU8G1StJVPo+pcM8pzfF\n\t+je6j26lFWwCf0bI7MjKa27+vhfGUG5cUjRSb5Ns=","Date":"Thu, 27 May 2021 11:23:32 +0300","From":"Laurent Pinchart ","To":"Tomasz Figa ","Message-ID":"","References":"<20210525055614.13417-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210525103802.ungy2k4coe7bebg3@uno.localdomain>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: add OV5693 sensor\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17318,"web_url":"https://patchwork.libcamera.org/comment/17318/","msgid":"","date":"2021-05-27T08:46:11","subject":"Re: [libcamera-devel] [PATCH] libcamera: add OV5693 sensor\n\tproperties","submitter":{"id":9,"url":"https://patchwork.libcamera.org/api/people/9/","name":"Tomasz Figa","email":"tfiga@chromium.org"},"content":"On Thu, May 27, 2021 at 5:23 PM Laurent Pinchart\n wrote:\n>\n> Hi Tomasz,\n>\n> On Thu, May 27, 2021 at 04:02:06PM +0900, Tomasz Figa wrote:\n> > On Tue, May 25, 2021 at 7:37 PM Jacopo Mondi wrote:\n> > > On Tue, May 25, 2021 at 07:56:14AM +0200, jeanmichel.hautbois@ideasonboard.com wrote:\n> > > > From: Jean-Michel Hautbois \n> > > >\n> > > > The new sensor database has introduced several sensors, but ov5693 is\n> > > > missing.\n> > > > It is used on most MS Surface tablets, add it to the database.\n> > > >\n> > > > Signed-off-by: Jean-Michel Hautbois \n> > > > ---\n> > > > src/libcamera/camera_sensor_properties.cpp | 3 +++\n> > > > 1 file changed, 3 insertions(+)\n> > > >\n> > > > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> > > > index 6ded31dc..2a6e97f7 100644\n> > > > --- a/src/libcamera/camera_sensor_properties.cpp\n> > > > +++ b/src/libcamera/camera_sensor_properties.cpp\n> > > > @@ -54,6 +54,9 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > > > { \"ov13858\", {\n> > > > .unitCellSize = { 1120, 1120 },\n> > > > } },\n> > > > + { \"ov5693\", {\n> > > > + .unitCellSize = { 1400, 1400 },\n> > >\n> > > Don't have a datasheet to very, so I assume that's correct!\n> > >\n> > > Reviewed-by: Jacopo Mondi \n> >\n> > I don't see a driver for this sensor in the kernel tree yet. I assume\n> > that this patch will wait until the driver is merged?\n>\n> The driver has been developed by the linux-surface community\n> (https://github.com/linux-surface) and is on its way to upstream, so I'm\n> fine with supporting it in libcamera already. Overall, if there's no\n> reason to distrust the upstreaming effort, I don't see a reason to wait\n> until the patches have been merged upstream.\n>\n\nThere is a problem with this. We can't rely on stable UAPI guarantees\nuntil the driver lands upstream. Perhaps we should have something like\nstaging in libcamera?\n\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 29D60BDB80\n\tfor ;\n\tThu, 27 May 2021 08:46:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DFE4968923;\n\tThu, 27 May 2021 10:46:38 +0200 (CEST)","from mail-ej1-x630.google.com (mail-ej1-x630.google.com\n\t[IPv6:2a00:1450:4864:20::630])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 98041602AA\n\tfor ;\n\tThu, 27 May 2021 10:46:36 +0200 (CEST)","by mail-ej1-x630.google.com with SMTP id z12so6843950ejw.0\n\tfor ;\n\tThu, 27 May 2021 01:46:36 -0700 (PDT)","from mail-wm1-f42.google.com (mail-wm1-f42.google.com.\n\t[209.85.128.42]) by smtp.gmail.com with ESMTPSA id\n\ti19sm706837eds.65.2021.05.27.01.46.35\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 27 May 2021 01:46:35 -0700 (PDT)","by mail-wm1-f42.google.com with SMTP id\n\ts5-20020a7bc0c50000b0290147d0c21c51so1998185wmh.4\n\tfor ;\n\tThu, 27 May 2021 01:46:35 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"RPFvKHrX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=QD0PfJa8oBKzHkZQvlErQF16rdHiNJtUVHpnlpLf5Ok=;\n\tb=RPFvKHrX1L2bPi+GwSSErQN3Z6nOGe4gYGGczm6TuZy5YtnPqXFHjAIHRPkCSI84K+\n\t5QAtgBS4QA0eAFmruHe28LGWQlaTZXYfHiKCxvXkaCI/DPmoGHnaUUhWoY502l793ayg\n\tIOEfW0XGEkCQK6pQG3IRBS1G4q32IcpKiL3Mk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=QD0PfJa8oBKzHkZQvlErQF16rdHiNJtUVHpnlpLf5Ok=;\n\tb=Aznp0ggtrwr7ryRGkkFHM0ZgDM3WS5ZtYtNM6c4JBll8repfTt92mW3/Q6EFoT6QdZ\n\tq5C9JEZ/C5e77zRdtr5ycJySD6k1YuBm9+sn9XT5vVKCwfdBMyyvz8DIsQJ8+kcNSkmp\n\tU10ZO1dtmFk14IpvlULf5txgeofaajlKpNS0Lxm3SvrWolBjVAwgqUGpSy5Z5hwj74h5\n\tiS4I2c047JdzmzQIPXO2MzxJYUAb5vBjR21M7KoiilZEKLLxbMqSpEMRb7CJBBvkIENp\n\tUxhwBTx47K9GEB2/ewSyM6egF5gO1Bur9SXQjlIKYl8Me9xIeWiigecH+NeEwfXPJ5js\n\tYXQw==","X-Gm-Message-State":"AOAM531Kz/jpqZx+gXyQBEd7Jbj7o+TTu07tTh4t0m/Mw/B/ORdGFfkR\n\tIG9cWAlrIQ/P+wo9oUhZyWWA6QK5tjCHky26","X-Google-Smtp-Source":"ABdhPJz0qeI7AdtwHhVHY4MOLgTXiQZnjRUv1hnd4GqrNJrTk2EGpd7Pewm8zOH6wDsng7AKYxpdoA==","X-Received":["by 2002:a17:906:e210:: with SMTP id\n\tgf16mr2701692ejb.472.1622105195994; \n\tThu, 27 May 2021 01:46:35 -0700 (PDT)","by 2002:a7b:cd0e:: with SMTP id f14mr7299083wmj.22.1622105194630;\n\tThu, 27 May 2021 01:46:34 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20210525055614.13417-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210525103802.ungy2k4coe7bebg3@uno.localdomain>\n\t\n\t","In-Reply-To":"","From":"Tomasz Figa ","Date":"Thu, 27 May 2021 17:46:11 +0900","X-Gmail-Original-Message-ID":"","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: add OV5693 sensor\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17319,"web_url":"https://patchwork.libcamera.org/comment/17319/","msgid":"","date":"2021-05-27T08:51:15","subject":"Re: [libcamera-devel] [PATCH] libcamera: add OV5693 sensor\n\tproperties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomasz,\n\nOn Thu, May 27, 2021 at 05:46:11PM +0900, Tomasz Figa wrote:\n> On Thu, May 27, 2021 at 5:23 PM Laurent Pinchart wrote:\n> > On Thu, May 27, 2021 at 04:02:06PM +0900, Tomasz Figa wrote:\n> > > On Tue, May 25, 2021 at 7:37 PM Jacopo Mondi wrote:\n> > > > On Tue, May 25, 2021 at 07:56:14AM +0200, jeanmichel.hautbois@ideasonboard.com wrote:\n> > > > > From: Jean-Michel Hautbois \n> > > > >\n> > > > > The new sensor database has introduced several sensors, but ov5693 is\n> > > > > missing.\n> > > > > It is used on most MS Surface tablets, add it to the database.\n> > > > >\n> > > > > Signed-off-by: Jean-Michel Hautbois \n> > > > > ---\n> > > > > src/libcamera/camera_sensor_properties.cpp | 3 +++\n> > > > > 1 file changed, 3 insertions(+)\n> > > > >\n> > > > > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> > > > > index 6ded31dc..2a6e97f7 100644\n> > > > > --- a/src/libcamera/camera_sensor_properties.cpp\n> > > > > +++ b/src/libcamera/camera_sensor_properties.cpp\n> > > > > @@ -54,6 +54,9 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > > > > { \"ov13858\", {\n> > > > > .unitCellSize = { 1120, 1120 },\n> > > > > } },\n> > > > > + { \"ov5693\", {\n> > > > > + .unitCellSize = { 1400, 1400 },\n> > > >\n> > > > Don't have a datasheet to very, so I assume that's correct!\n> > > >\n> > > > Reviewed-by: Jacopo Mondi \n> > >\n> > > I don't see a driver for this sensor in the kernel tree yet. I assume\n> > > that this patch will wait until the driver is merged?\n> >\n> > The driver has been developed by the linux-surface community\n> > (https://github.com/linux-surface) and is on its way to upstream, so I'm\n> > fine with supporting it in libcamera already. Overall, if there's no\n> > reason to distrust the upstreaming effort, I don't see a reason to wait\n> > until the patches have been merged upstream.\n> \n> There is a problem with this. We can't rely on stable UAPI guarantees\n> until the driver lands upstream. Perhaps we should have something like\n> staging in libcamera?\n\nWe've had ABI breakages with rkisp1 when it was getting destaged. It's\nnot nice, but given that we haven't frozen any ABI for libcamera yet, I\ndon't think it's a blocker at the moment.\n\nHow do you handle this issue in Chrome OS ? :-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE416C3203\n\tfor ;\n\tThu, 27 May 2021 08:51:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DF02768923;\n\tThu, 27 May 2021 10:51:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B762C602AA\n\tfor ;\n\tThu, 27 May 2021 10:51:21 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2DBFDB2C;\n\tThu, 27 May 2021 10:51:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"G59YhTqZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622105481;\n\tbh=8Nx9NGovAygufT2Ha0SLEWX4Fx7Bstt2gS6ZqzyWMhI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=G59YhTqZeceJH5Wyt85krhomore2CpUvApWe5OUZL4PceyZ43+U4Hb1XBPydy+4Ir\n\tKL107CU2Rn6JVffhJNIvwErH/7kQaE9jmZwsyWVX9ymylNzFaaXsVa0c0oeorEUPoU\n\tJX6dhS9vYoJS95wOsCHAFOyUBfd9EruryNLnWrzo=","Date":"Thu, 27 May 2021 11:51:15 +0300","From":"Laurent Pinchart ","To":"Tomasz Figa ","Message-ID":"","References":"<20210525055614.13417-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210525103802.ungy2k4coe7bebg3@uno.localdomain>\n\t\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: add OV5693 sensor\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17320,"web_url":"https://patchwork.libcamera.org/comment/17320/","msgid":"","date":"2021-05-27T08:52:34","subject":"Re: [libcamera-devel] [PATCH] libcamera: add OV5693 sensor\n\tproperties","submitter":{"id":9,"url":"https://patchwork.libcamera.org/api/people/9/","name":"Tomasz Figa","email":"tfiga@chromium.org"},"content":"On Thu, May 27, 2021 at 5:51 PM Laurent Pinchart\n wrote:\n>\n> Hi Tomasz,\n>\n> On Thu, May 27, 2021 at 05:46:11PM +0900, Tomasz Figa wrote:\n> > On Thu, May 27, 2021 at 5:23 PM Laurent Pinchart wrote:\n> > > On Thu, May 27, 2021 at 04:02:06PM +0900, Tomasz Figa wrote:\n> > > > On Tue, May 25, 2021 at 7:37 PM Jacopo Mondi wrote:\n> > > > > On Tue, May 25, 2021 at 07:56:14AM +0200, jeanmichel.hautbois@ideasonboard.com wrote:\n> > > > > > From: Jean-Michel Hautbois \n> > > > > >\n> > > > > > The new sensor database has introduced several sensors, but ov5693 is\n> > > > > > missing.\n> > > > > > It is used on most MS Surface tablets, add it to the database.\n> > > > > >\n> > > > > > Signed-off-by: Jean-Michel Hautbois \n> > > > > > ---\n> > > > > > src/libcamera/camera_sensor_properties.cpp | 3 +++\n> > > > > > 1 file changed, 3 insertions(+)\n> > > > > >\n> > > > > > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> > > > > > index 6ded31dc..2a6e97f7 100644\n> > > > > > --- a/src/libcamera/camera_sensor_properties.cpp\n> > > > > > +++ b/src/libcamera/camera_sensor_properties.cpp\n> > > > > > @@ -54,6 +54,9 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > > > > > { \"ov13858\", {\n> > > > > > .unitCellSize = { 1120, 1120 },\n> > > > > > } },\n> > > > > > + { \"ov5693\", {\n> > > > > > + .unitCellSize = { 1400, 1400 },\n> > > > >\n> > > > > Don't have a datasheet to very, so I assume that's correct!\n> > > > >\n> > > > > Reviewed-by: Jacopo Mondi \n> > > >\n> > > > I don't see a driver for this sensor in the kernel tree yet. I assume\n> > > > that this patch will wait until the driver is merged?\n> > >\n> > > The driver has been developed by the linux-surface community\n> > > (https://github.com/linux-surface) and is on its way to upstream, so I'm\n> > > fine with supporting it in libcamera already. Overall, if there's no\n> > > reason to distrust the upstreaming effort, I don't see a reason to wait\n> > > until the patches have been merged upstream.\n> >\n> > There is a problem with this. We can't rely on stable UAPI guarantees\n> > until the driver lands upstream. Perhaps we should have something like\n> > staging in libcamera?\n>\n> We've had ABI breakages with rkisp1 when it was getting destaged. It's\n> not nice, but given that we haven't frozen any ABI for libcamera yet, I\n> don't think it's a blocker at the moment.\n>\n> How do you handle this issue in Chrome OS ? :-)\n\nWe carry downstream patches. :)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB08CC3203\n\tfor ;\n\tThu, 27 May 2021 08:52:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8CC6F68923;\n\tThu, 27 May 2021 10:52:51 +0200 (CEST)","from mail-ed1-x535.google.com (mail-ed1-x535.google.com\n\t[IPv6:2a00:1450:4864:20::535])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E9E2D602AA\n\tfor ;\n\tThu, 27 May 2021 10:52:49 +0200 (CEST)","by mail-ed1-x535.google.com with SMTP id t15so4827487edr.11\n\tfor ;\n\tThu, 27 May 2021 01:52:49 -0700 (PDT)","from mail-wr1-f50.google.com (mail-wr1-f50.google.com.\n\t[209.85.221.50]) by smtp.gmail.com with ESMTPSA id\n\td25sm646913ejd.59.2021.05.27.01.52.47\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 27 May 2021 01:52:48 -0700 (PDT)","by mail-wr1-f50.google.com with SMTP id r10so3848939wrj.11\n\tfor ;\n\tThu, 27 May 2021 01:52:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"cRqWIkhy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=ej1eQTbCnnUAeEPNZ6z6ckDl7puPoDxIxgqnqGmTxNk=;\n\tb=cRqWIkhyrJRR22zsSy7Utsd3UA0xrglZwZdGW+5mbuCG/107XJEIgB0iWsF+O1+Dhs\n\tWBrP8zcwy3DhTLzQDBmf/+si4NCO/scttR+xzDgTqFUjSNED/SH0kvAaPyZhNcZE8CBZ\n\tAB0E+TotzapgnEJsPaYoOnIcQgx3dNNQEa3Tk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=ej1eQTbCnnUAeEPNZ6z6ckDl7puPoDxIxgqnqGmTxNk=;\n\tb=VQ+3w+E1C1NJOpbZlzXzwhbqWne04cDMYwOTvhxjbcxhYdw+XSavUY5Wmf7NiJ3BZs\n\tsGJIupvLJDRfX0WIZeNJpRrnCqwQdW4mQp1RzBtjMm2lUzOBIp1JVxEvBE119ERienf9\n\t8iUl259pyxU/OhuVEhF0/nkhf0SpQKFBHZxNQW+f6bG+OCPoCwzj20rSh9F6uCVOK1MO\n\t5NYyQI3FTu8SdE/LZy6CZc3O57scl914HFEFmj7bz+mwhdZdQWS0SGkCHD111FiZG4gk\n\tj8NYReetde9WBNbUfbZ9S9grrbKFgLLKVVrm5XJNPtUDfby7iH/iOaro+Mi2JLpFdUWm\n\t5kvQ==","X-Gm-Message-State":"AOAM532OVnhfkQGyZFAWuJj5QGmBb/Dgm98Z7QAVtCGLmAC5u3vOP21d\n\tghMgQYysBfa3rTuvqO7gX8EqeJFqpAhki5V6","X-Google-Smtp-Source":"ABdhPJywQyCJ+ViE55LXVWcxYBy7WuDbdJlQqOf0XU1gUc3RAiTHl94zv0whGt9wxFEJCNuNQzBVpw==","X-Received":["by 2002:aa7:da8e:: with SMTP id q14mr2953516eds.13.1622105569330;\n\tThu, 27 May 2021 01:52:49 -0700 (PDT)","by 2002:a5d:4385:: with SMTP id i5mr2175263wrq.192.1622105567228;\n\tThu, 27 May 2021 01:52:47 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20210525055614.13417-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210525103802.ungy2k4coe7bebg3@uno.localdomain>\n\t\n\t\n\t\n\t","In-Reply-To":"","From":"Tomasz Figa ","Date":"Thu, 27 May 2021 17:52:34 +0900","X-Gmail-Original-Message-ID":"","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: add OV5693 sensor\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17321,"web_url":"https://patchwork.libcamera.org/comment/17321/","msgid":"","date":"2021-05-27T08:59:30","subject":"Re: [libcamera-devel] [PATCH] libcamera: add OV5693 sensor\n\tproperties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomasz,\n\nOn Thu, May 27, 2021 at 05:52:34PM +0900, Tomasz Figa wrote:\n> On Thu, May 27, 2021 at 5:51 PM Laurent Pinchart wrote:\n> > On Thu, May 27, 2021 at 05:46:11PM +0900, Tomasz Figa wrote:\n> > > On Thu, May 27, 2021 at 5:23 PM Laurent Pinchart wrote:\n> > > > On Thu, May 27, 2021 at 04:02:06PM +0900, Tomasz Figa wrote:\n> > > > > On Tue, May 25, 2021 at 7:37 PM Jacopo Mondi wrote:\n> > > > > > On Tue, May 25, 2021 at 07:56:14AM +0200, jeanmichel.hautbois@ideasonboard.com wrote:\n> > > > > > > From: Jean-Michel Hautbois \n> > > > > > >\n> > > > > > > The new sensor database has introduced several sensors, but ov5693 is\n> > > > > > > missing.\n> > > > > > > It is used on most MS Surface tablets, add it to the database.\n> > > > > > >\n> > > > > > > Signed-off-by: Jean-Michel Hautbois \n> > > > > > > ---\n> > > > > > > src/libcamera/camera_sensor_properties.cpp | 3 +++\n> > > > > > > 1 file changed, 3 insertions(+)\n> > > > > > >\n> > > > > > > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> > > > > > > index 6ded31dc..2a6e97f7 100644\n> > > > > > > --- a/src/libcamera/camera_sensor_properties.cpp\n> > > > > > > +++ b/src/libcamera/camera_sensor_properties.cpp\n> > > > > > > @@ -54,6 +54,9 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > > > > > > { \"ov13858\", {\n> > > > > > > .unitCellSize = { 1120, 1120 },\n> > > > > > > } },\n> > > > > > > + { \"ov5693\", {\n> > > > > > > + .unitCellSize = { 1400, 1400 },\n> > > > > >\n> > > > > > Don't have a datasheet to very, so I assume that's correct!\n> > > > > >\n> > > > > > Reviewed-by: Jacopo Mondi \n> > > > >\n> > > > > I don't see a driver for this sensor in the kernel tree yet. I assume\n> > > > > that this patch will wait until the driver is merged?\n> > > >\n> > > > The driver has been developed by the linux-surface community\n> > > > (https://github.com/linux-surface) and is on its way to upstream, so I'm\n> > > > fine with supporting it in libcamera already. Overall, if there's no\n> > > > reason to distrust the upstreaming effort, I don't see a reason to wait\n> > > > until the patches have been merged upstream.\n> > >\n> > > There is a problem with this. We can't rely on stable UAPI guarantees\n> > > until the driver lands upstream. Perhaps we should have something like\n> > > staging in libcamera?\n> >\n> > We've had ABI breakages with rkisp1 when it was getting destaged. It's\n> > not nice, but given that we haven't frozen any ABI for libcamera yet, I\n> > don't think it's a blocker at the moment.\n> >\n> > How do you handle this issue in Chrome OS ? :-)\n> \n> We carry downstream patches. :)\n\nI dread to think of the day we'll have to handle downstream libcamera\nversions :-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF0C8BDB80\n\tfor ;\n\tThu, 27 May 2021 08:59:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7B27F68924;\n\tThu, 27 May 2021 10:59:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C607768920\n\tfor ;\n\tThu, 27 May 2021 10:59:36 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 35314B2C;\n\tThu, 27 May 2021 10:59:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Dsb2IZ3M\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622105976;\n\tbh=y2SkflIPX8MJMc9AIXfVnfIUBn+XH2mHG1hoo6i5Acg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Dsb2IZ3MQJRg5amEC94Fbw9MhEbm25cXZ8deU/AoLu/45I+qcIDzY8tixp1Cp8Ru+\n\tardEijQMJYSm5QXngTOSg9RG/1jBx8G5HXQqgsP/Z2gCqG/+rwFKXUlTXDexZr38Ju\n\te8mNwZOA0x1V4TVn82erON8ntSk1ehJBV3AQc9IE=","Date":"Thu, 27 May 2021 11:59:30 +0300","From":"Laurent Pinchart ","To":"Tomasz Figa ","Message-ID":"","References":"<20210525055614.13417-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210525103802.ungy2k4coe7bebg3@uno.localdomain>\n\t\n\t\n\t\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: add OV5693 sensor\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]