{"id":1239,"url":"https://patchwork.libcamera.org/api/patches/1239/?format=json","web_url":"https://patchwork.libcamera.org/patch/1239/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190521004059.7750-2-paul.elder@ideasonboard.com>","date":"2019-05-21T00:40:59","name":"[libcamera-devel,v3,2/2] tests: ipa: add tests to test IPAModule","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6b7e35d12100b82602dae45885b22a0ee1163c22","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1239/mbox/","series":[{"id":310,"url":"https://patchwork.libcamera.org/api/series/310/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=310","date":"2019-05-21T00:40:58","name":"[libcamera-devel,v3,1/2] libcamera: ipa_module: add IPA shared library module","version":3,"mbox":"https://patchwork.libcamera.org/series/310/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1239/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1239/checks/","tags":{},"headers":{"Return-Path":"<paul.elder@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB90260BC9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 May 2019 02:41:12 +0200 (CEST)","from localhost.localdomain (unknown [96.44.9.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 025A552C;\n\tTue, 21 May 2019 02:41:11 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1558399272;\n\tbh=n8OXlYPeaN59IoiJKTzdeg8PPNhTb1Mv4xYRLpLH4b8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=VB6lxymLbSJFTu4wgRk8Z6t1pbWPnttSAnsSTTHHPRaAJbSMHnTr6lgR018A6er5E\n\tyDYHEb6d2kc7J+urG3gUSO3EVP6DcSoYFcEWyBOK4dMUqyatJ/TD/l0J0xeW8EwB4A\n\thY+WTxMg9NTKfWujuP7Gp6SlSjNyFVK9tVAMo+kE=","From":"Paul Elder <paul.elder@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 20 May 2019 20:40:59 -0400","Message-Id":"<20190521004059.7750-2-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190521004059.7750-1-paul.elder@ideasonboard.com>","References":"<20190521004059.7750-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 2/2] tests: ipa: add tests to test\n\tIPAModule","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 21 May 2019 00:41:12 -0000"},"content":"Add tests to test the the IPAModule class, for loading the IPA module\ninfo from IPA module .so shared objects, with modules written in both C\nand C++.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\nChanges in v3:\n- remove tests for incorrect bitness\n- make the test IPA module .so a C one and a C++ one\n\nChanges in v2:\n- added source for test .so\n- updated tests to work with new (v2, see 1/2) IPAModule API\n\n test/ipa/ipa_test.cpp    | 65 ++++++++++++++++++++++++++++++++++++++++\n test/ipa/meson.build     | 29 ++++++++++++++++++\n test/ipa/shared_test.c   |  6 ++++\n test/ipa/shared_test.cpp | 12 ++++++++\n test/meson.build         |  1 +\n 5 files changed, 113 insertions(+)\n create mode 100644 test/ipa/ipa_test.cpp\n create mode 100644 test/ipa/meson.build\n create mode 100644 test/ipa/shared_test.c\n create mode 100644 test/ipa/shared_test.cpp","diff":"diff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_test.cpp\nnew file mode 100644\nindex 0000000..74854df\n--- /dev/null\n+++ b/test/ipa/ipa_test.cpp\n@@ -0,0 +1,65 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * load-so.cpp - loading .so tests\n+ */\n+\n+#include <iostream>\n+\n+#include \"ipa_module.h\"\n+\n+#include \"test.h\"\n+\n+using namespace std;\n+using namespace libcamera;\n+\n+class IPAModuleTest : public Test\n+{\n+protected:\n+\tint init()\n+\t{\n+\t\treturn 0;\n+\t}\n+\n+\tint run_test(const string path)\n+\t{\n+\t\tcout << \"running lib loader test\" << endl;\n+\n+\t\tIPAModule *ll = new IPAModule(path);\n+\n+\t\tif (!ll->isValid()) {\n+\t\t\tcout << \"failed to load\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tstruct IPAModuleInfo info = ll->info();\n+\t\tcout << \"loaded!\" << endl;\n+\t\tcout << \"name = \" << info.name << \", version = \" << info.version << endl;\n+\n+\t\tdelete ll;\n+\t\treturn TestPass;\n+\t}\n+\n+\tint run()\n+\t{\n+\t\tint count = 0;\n+\n+\t\tcout << \"testing C IPAModule\" << endl;\n+\t\tcount += run_test(\"test/ipa/ipa-dummy.so\");\n+\n+\t\tcout << \"testing C++ IPAModule\" << endl;\n+\t\tcount += run_test(\"test/ipa/ipa-dummy-cpp.so\");\n+\n+\t\tif (count < 0)\n+\t\t\treturn TestFail;\n+\n+\t\treturn TestPass;\n+\t}\n+\n+\tvoid cleanup()\n+\t{\n+\t}\n+};\n+\n+TEST_REGISTER(IPAModuleTest)\ndiff --git a/test/ipa/meson.build b/test/ipa/meson.build\nnew file mode 100644\nindex 0000000..dc8fbdd\n--- /dev/null\n+++ b/test/ipa/meson.build\n@@ -0,0 +1,29 @@\n+ipa_test = [\n+    ['ipa_test',\t      'ipa_test.cpp'],\n+]\n+\n+foreach t : ipa_test\n+    exe = executable(t[0], t[1],\n+                     link_with : test_libraries,\n+                     include_directories : test_includes_internal)\n+\n+    test(t[0], exe, suite: 'ipa', is_parallel: false)\n+endforeach\n+\n+ipa_dummy_sources = files([\n+    'shared_test.c'\n+])\n+\n+ipa_dummy_sources_cpp = files([\n+    'shared_test.cpp'\n+])\n+\n+ipa_dummy = shared_library('ipa-dummy',\n+\t\t\t   ipa_dummy_sources,\n+\t\t\t   name_prefix: '',\n+\t\t\t   include_directories: test_includes_public)\n+\n+ipa_dummy_cpp = shared_library('ipa-dummy-cpp',\n+\t\t\t       ipa_dummy_sources_cpp,\n+\t\t\t       name_prefix: '',\n+\t\t\t       include_directories: test_includes_public)\ndiff --git a/test/ipa/shared_test.c b/test/ipa/shared_test.c\nnew file mode 100644\nindex 0000000..4959a03\n--- /dev/null\n+++ b/test/ipa/shared_test.c\n@@ -0,0 +1,6 @@\n+#include <libcamera/ipa/ipa_module_info.h>\n+\n+const struct IPAModuleInfo ipaModuleInfo = {\n+\t.name = \"Answer to the Ultimate Question of Life, the Universe, and Everything\",\n+\t.version = 42,\n+};\ndiff --git a/test/ipa/shared_test.cpp b/test/ipa/shared_test.cpp\nnew file mode 100644\nindex 0000000..4e5c976\n--- /dev/null\n+++ b/test/ipa/shared_test.cpp\n@@ -0,0 +1,12 @@\n+#include <libcamera/ipa/ipa_module_info.h>\n+\n+namespace libcamera {\n+\n+extern \"C\" {\n+const struct libcamera::IPAModuleInfo ipaModuleInfo = {\n+\t\"It's over nine thousand!\",\n+\t9001,\n+};\n+};\n+\n+}; /* namespace libcamera */\ndiff --git a/test/meson.build b/test/meson.build\nindex d501f2b..ef41367 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -1,6 +1,7 @@\n subdir('libtest')\n \n subdir('camera')\n+subdir('ipa')\n subdir('media_device')\n subdir('pipeline')\n subdir('v4l2_device')\n","prefixes":["libcamera-devel","v3","2/2"]}