[{"id":17193,"web_url":"https://patchwork.libcamera.org/comment/17193/","msgid":"","date":"2021-05-24T12:14:34","subject":"Re: [libcamera-devel] [PATCH v2 2/3] android: camera_device: Fix\n\tsensor frame duration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Mon, May 24, 2021 at 06:41:22PM +0900, Paul Elder wrote:\n> The sensor frame duration should be set by IPA. Get the information for\n> the result metadata from libcamera.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 0eea2b95..70173424 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -2252,6 +2252,12 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons\n> \t\tresultMetadata->addEntry(ANDROID_SENSOR_EXPOSURE_TIME, exposure);\n> \t}\n> \n> +\tif (metadata.contains(controls::FrameDuration)) {\n> +\t\tint64_t duration = metadata.get(controls::FrameDuration) * 1000;\n> +\t\tresultMetadata->addEntry(ANDROID_SENSOR_FRAME_DURATION,\n> +\t\t\t\t\t duration);\n> +\t}\n> +\n> \tif (metadata.contains(controls::ScalerCrop)) {\n> \t\tRectangle crop = metadata.get(controls::ScalerCrop);\n> \t\tint32_t cropRect[] = {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32FD8C3200\n\tfor ;\n\tMon, 24 May 2021 12:14:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E207F6891A;\n\tMon, 24 May 2021 14:14:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 09F2E601AA\n\tfor ;\n\tMon, 24 May 2021 14:14:39 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 98C4EED;\n\tMon, 24 May 2021 14:14:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"istttNL4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621858478;\n\tbh=iXyK6YybI8bt0n5toNdvfgdU9YTuCQgrz8isYzSoEwo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=istttNL4WJnIcYxtKeJObR7juG7wA0C2lkLjWEz7d6wnp4ErNqIN+SQnpOAjXCBLk\n\tvZ5ViYUNJL8bu9IgMAv/ys3D3v735es/u8AuREMAIPVKGw1Arcd3YKHlk9RntlO27j\n\t5cygE4ga3VPLPWtGsOSisNpx22YqWgjfpimWcx2c=","Date":"Mon, 24 May 2021 15:14:34 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210524094123.1187354-1-paul.elder@ideasonboard.com>\n\t<20210524094123.1187354-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210524094123.1187354-2-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] android: camera_device: Fix\n\tsensor frame duration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]