[{"id":17128,"web_url":"https://patchwork.libcamera.org/comment/17128/","msgid":"","date":"2021-05-23T06:44:21","subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: thread: Drop doc of\n\tasynchronous signals delivery to applications","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2021-05-23 05:31:54 +0300, Laurent Pinchart wrote:\n> The asynchronous signal delivery mechanism can't be used by application,\n> as it requires libcamera to be aware of the application event loop,\n> which has been dropped a long time ago. Drop the corresponding\n> documentation paragraph.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/thread.cpp | 8 --------\n> 1 file changed, 8 deletions(-)\n> \n> diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n> index bc1dcedea0d1..d59e43966d26 100644\n> --- a/src/libcamera/thread.cpp\n> +++ b/src/libcamera/thread.cpp\n> @@ -64,14 +64,6 @@\n> * be overridden by selecting a different connection type when calling\n> * Signal::connect().\n> *\n> - * Asynchronous signal delivery is used internally in libcamera, but is also\n> - * available to applications if desired. To use this feature, applications\n> - * shall create receiver classes that inherit from the Object class, and\n> - * provide an event loop to the CameraManager as explained above. Note that\n> - * Object instances created by the application are limited to living in the\n> - * application's main thread. Creating Object instances from another thread of\n> - * an application causes undefined behaviour.\n> - *\n> * \\section thread-reentrancy Reentrancy and Thread-Safety\n> *\n> * Through the documentation, several terms are used to define how classes and\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6350C3200\n\tfor ;\n\tSun, 23 May 2021 06:44:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 216B26891A;\n\tSun, 23 May 2021 08:44:24 +0200 (CEST)","from mail-lj1-x232.google.com (mail-lj1-x232.google.com\n\t[IPv6:2a00:1450:4864:20::232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1799E602AE\n\tfor ;\n\tSun, 23 May 2021 08:44:23 +0200 (CEST)","by mail-lj1-x232.google.com with SMTP id f12so29242351ljp.2\n\tfor ;\n\tSat, 22 May 2021 23:44:23 -0700 (PDT)","from localhost (h-155-4-209-203.A463.priv.bahnhof.se.\n\t[155.4.209.203]) by smtp.gmail.com with ESMTPSA id\n\tx203sm1088596lff.262.2021.05.22.23.44.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 22 May 2021 23:44:22 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"rn+wsXxs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=EVcIV6t0yxDgAFCiiAWDTp3wWFxPCSahBzDm7iswPWY=;\n\tb=rn+wsXxsLHqlcSw4/yyLJ1BfakDvquMdpb5394U8Mbhj7GNUiHg1PuNN4QiHzHHsK6\n\td1FvtG+7gNtNKR6Zr0Elw278pq+p79vSXT+rsG72VWUt3sfqjK0VpSpFLkp7ayEpp2fN\n\tl9t6oW6SHn+YTmH9H1OFHX0JSqSt5RNOUA5StkBpml9/4mXZl0qHoYFHZkBdeRk5rJLA\n\t6kPzL7H0VXZNgwTEpIELaW13tSgrREi1xd9ucbNzaEb0dZE3BSRetr8/6bloAl7m1V28\n\t6i3qOlflRpBDfJLsdMyvLqaQiQA57xwUm9x1BUz8kEh+KtvCxNaF7zEF36Qy5cWJa2QF\n\t9oFw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=EVcIV6t0yxDgAFCiiAWDTp3wWFxPCSahBzDm7iswPWY=;\n\tb=nqTt3UMX1bDhanB/X8T4oLPy+c0PuXvGN1q3WNpAnusWjZn0e44bEADVAZQEPrY0c8\n\tcxl8GXc9j8O3jvE19+7UhdRiHqe731A7eWBgZxuVNcG8c7rYhg/Ej1j+o5nh8dN4cPGQ\n\tViSpzg6CzwLBXDhUoGUsFjN9Fu4WHBzS0U+gu6t3LpKd+K2mbG5RSFoIq2eGF06Ge6MH\n\tGd+M2f/ePIzk47ToCVxH4ThLjPBGPQpisAkPa3hxZ4TZH6VY/mBv21MTMMcXkZ56I1bk\n\tse+f23X4Gcbr7ncoTrsUZcmYv+6yHV7iplaQmevKBem98FB/gYazPKzgbCDW/G3v7kjt\n\tIK+w==","X-Gm-Message-State":"AOAM530vfE6Zjqf+jzt1Lk3MM8b+lRJVWg8QNFzLkyV6EDg/h1G7ROMj\n\tk3p6eQGSNlvnCbvCKcBBfLZjhqiCbuOmWlXO","X-Google-Smtp-Source":"ABdhPJyGvDdiHQPgxuUArPL7RirZ/Cy1jBofXMubeAwsrcFa5yr+tJlXP/dc77d4DI+nRPvt9GqVxg==","X-Received":"by 2002:a2e:9d59:: with SMTP id\n\ty25mr12333695ljj.399.1621752262554; \n\tSat, 22 May 2021 23:44:22 -0700 (PDT)","Date":"Sun, 23 May 2021 08:44:21 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20210523023155.20268-1-laurent.pinchart@ideasonboard.com>\n\t<20210523023155.20268-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20210523023155.20268-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: thread: Drop doc of\n\tasynchronous signals delivery to applications","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17155,"web_url":"https://patchwork.libcamera.org/comment/17155/","msgid":"","date":"2021-05-24T02:44:24","subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: thread: Drop doc of\n\tasynchronous signals delivery to applications","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 5/23/21 8:01 AM, Laurent Pinchart wrote:\n> The asynchronous signal delivery mechanism can't be used by application,\n> as it requires libcamera to be aware of the application event loop,\n> which has been dropped a long time ago. Drop the corresponding\n> documentation paragraph.\n>\n> Signed-off-by: Laurent Pinchart \nReviewed-by: Umang Jain \n> ---\n> src/libcamera/thread.cpp | 8 --------\n> 1 file changed, 8 deletions(-)\n>\n> diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n> index bc1dcedea0d1..d59e43966d26 100644\n> --- a/src/libcamera/thread.cpp\n> +++ b/src/libcamera/thread.cpp\n> @@ -64,14 +64,6 @@\n> * be overridden by selecting a different connection type when calling\n> * Signal::connect().\n> *\n> - * Asynchronous signal delivery is used internally in libcamera, but is also\n> - * available to applications if desired. To use this feature, applications\n> - * shall create receiver classes that inherit from the Object class, and\n> - * provide an event loop to the CameraManager as explained above. Note that\n> - * Object instances created by the application are limited to living in the\n> - * application's main thread. Creating Object instances from another thread of\n> - * an application causes undefined behaviour.\n> - *\n> * \\section thread-reentrancy Reentrancy and Thread-Safety\n> *\n> * Through the documentation, several terms are used to define how classes and","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 206CCC3200\n\tfor ;\n\tMon, 24 May 2021 02:44:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D40D86891B;\n\tMon, 24 May 2021 04:44:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 860BF6050F\n\tfor ;\n\tMon, 24 May 2021 04:44:30 +0200 (CEST)","from localhost.localdomain (unknown [103.251.226.203])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 67BEA476;\n\tMon, 24 May 2021 04:44:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"izhSnTZr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621824270;\n\tbh=ZcbjbKLm0vjEHRkUMKap2SrFRUntGkiXFe0IgS21nWk=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=izhSnTZry6i+NWuNYgi7c7sr/BzCQ50VSmi93tz6R8LCj+iBVRcuUxqzFQXwkuL9J\n\tsc8Vqeqjsl72rfosFyN5ufg1IocAtXwTdGB/8bDUrlvq7HMtyApRPVSxvgDIdpi6E1\n\tsHwSIcAUXIspmkyVuM5lSVc/t4DYRRgEF8zsPVSM=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210523023155.20268-1-laurent.pinchart@ideasonboard.com>\n\t<20210523023155.20268-4-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"","Date":"Mon, 24 May 2021 08:14:24 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.11.0","MIME-Version":"1.0","In-Reply-To":"<20210523023155.20268-4-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: thread: Drop doc of\n\tasynchronous signals delivery to applications","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17171,"web_url":"https://patchwork.libcamera.org/comment/17171/","msgid":"","date":"2021-05-24T05:41:41","subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: thread: Drop doc of\n\tasynchronous signals delivery to applications","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent, thank you for the patch,\n\nOn Mon, May 24, 2021 at 11:44 AM Umang Jain \nwrote:\n\n> Hi Laurent,\n>\n> On 5/23/21 8:01 AM, Laurent Pinchart wrote:\n> > The asynchronous signal delivery mechanism can't be used by application,\n> > as it requires libcamera to be aware of the application event loop,\n> > which has been dropped a long time ago. Drop the corresponding\n> > documentation paragraph.\n> >\n> > Signed-off-by: Laurent Pinchart \n> Reviewed-by: Umang Jain \n>\n\nReviewed-by: Hirokazu Honda \n\n\n> > ---\n> > src/libcamera/thread.cpp | 8 --------\n> > 1 file changed, 8 deletions(-)\n> >\n> > diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n> > index bc1dcedea0d1..d59e43966d26 100644\n> > --- a/src/libcamera/thread.cpp\n> > +++ b/src/libcamera/thread.cpp\n> > @@ -64,14 +64,6 @@\n> > * be overridden by selecting a different connection type when calling\n> > * Signal::connect().\n> > *\n> > - * Asynchronous signal delivery is used internally in libcamera, but is\n> also\n> > - * available to applications if desired. To use this feature,\n> applications\n> > - * shall create receiver classes that inherit from the Object class, and\n> > - * provide an event loop to the CameraManager as explained above. Note\n> that\n> > - * Object instances created by the application are limited to living in\n> the\n> > - * application's main thread. Creating Object instances from another\n> thread of\n> > - * an application causes undefined behaviour.\n> > - *\n> > * \\section thread-reentrancy Reentrancy and Thread-Safety\n> > *\n> > * Through the documentation, several terms are used to define how\n> classes and\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E17DC3200\n\tfor ;\n\tMon, 24 May 2021 05:41:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 00C5F602AD;\n\tMon, 24 May 2021 07:41:55 +0200 (CEST)","from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com\n\t[IPv6:2a00:1450:4864:20::62a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C3C5E602AD\n\tfor ;\n\tMon, 24 May 2021 07:41:52 +0200 (CEST)","by mail-ej1-x62a.google.com with SMTP id f18so9670918ejq.10\n\tfor ;\n\tSun, 23 May 2021 22:41:52 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"d0p4WNOI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=Gzc7rNe533fOldMe0+5D43xtRBvf6mxFmOKqsnk6pdM=;\n\tb=d0p4WNOI8qRG0zmGrRicfmkAhYWUxpj7wL8qhat9wLu8Tn2LoB3XNJuUCnCFLxhbuS\n\tSUFebKlQCApSKVfGQ3jpVWgR1tiEfOuk8Jhs2reifTtHbIe0DGR1FXQtheUC1rioExHp\n\t3p1U6pGKl3MkDDG/ROVqD936Vmn/TP4HCvZhQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Gzc7rNe533fOldMe0+5D43xtRBvf6mxFmOKqsnk6pdM=;\n\tb=dEB59xDfuuV7WTs53PKx+A6s7vb3PROZz53aBRIqSNvTcsV9yW9VvhyAqGqrFNvw8p\n\tO1NkFjKiKwvbnw+mlCYSOPdKrupfkqNPP6PjqV1rQJ3WBxzE7xIDeC7kkGIwmsRSKhVv\n\tRu4brhndIjNUuhUkC2FdZ04c5uH5m3OS3IktHEeX7zJan6KmcklXJJxfTp0CkCZQufTe\n\t/rc07lEvlExykpbzRUtcW6b3UnCGbqCfFC38rbA+nO4qMrhLG4Sw3YOdTkBUsTA2LcF0\n\tydjlpWWUTcTFbQUUz96Cs3+yHwq+iKqaybsamalDa5pSzqfXpgLTEFr9o2yRuz7vOtHz\n\tG8lg==","X-Gm-Message-State":"AOAM531kd/zmUGp2KZEEdUmeb9OBXwmMFoEo2M2+CIzkYTX3St1Owgf7\n\t5NCfc5VaUB3wJwqwbdE1MJR8nAEt3vwCHdsBzxFa+qaeubc=","X-Google-Smtp-Source":"ABdhPJwt8oF3HoiJ7krKnBy8mVB8SL6eLszU9i6llWrrXjE8OtKzOa/Qyug+CAhkIYDoOOZcpuxQziHZNfcJEhslXvM=","X-Received":"by 2002:a17:906:3a04:: with SMTP id\n\tz4mr21449465eje.221.1621834912467; \n\tSun, 23 May 2021 22:41:52 -0700 (PDT)","MIME-Version":"1.0","References":"<20210523023155.20268-1-laurent.pinchart@ideasonboard.com>\n\t<20210523023155.20268-4-laurent.pinchart@ideasonboard.com>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Mon, 24 May 2021 14:41:41 +0900","Message-ID":"","To":"Umang Jain ","Content-Type":"multipart/alternative; boundary=\"000000000000d7a1f705c30cddad\"","Subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: thread: Drop doc of\n\tasynchronous signals delivery to applications","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17177,"web_url":"https://patchwork.libcamera.org/comment/17177/","msgid":"<20210524085535.mf7eesbdbzpllll7@uno.localdomain>","date":"2021-05-24T08:55:35","subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: thread: Drop doc of\n\tasynchronous signals delivery to applications","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sun, May 23, 2021 at 05:31:54AM +0300, Laurent Pinchart wrote:\n> The asynchronous signal delivery mechanism can't be used by application,\n> as it requires libcamera to be aware of the application event loop,\n> which has been dropped a long time ago. Drop the corresponding\n> documentation paragraph.\n\nAre they still available internally to libcamera, don't they ?\n\nWould you like to drop the whole paragraph or only the 'available to\napplications.. ' part ?\n\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/thread.cpp | 8 --------\n> 1 file changed, 8 deletions(-)\n>\n> diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n> index bc1dcedea0d1..d59e43966d26 100644\n> --- a/src/libcamera/thread.cpp\n> +++ b/src/libcamera/thread.cpp\n> @@ -64,14 +64,6 @@\n> * be overridden by selecting a different connection type when calling\n> * Signal::connect().\n> *\n> - * Asynchronous signal delivery is used internally in libcamera, but is also\n> - * available to applications if desired. To use this feature, applications\n> - * shall create receiver classes that inherit from the Object class, and\n> - * provide an event loop to the CameraManager as explained above. Note that\n> - * Object instances created by the application are limited to living in the\n> - * application's main thread. Creating Object instances from another thread of\n> - * an application causes undefined behaviour.\n> - *\n> * \\section thread-reentrancy Reentrancy and Thread-Safety\n> *\n> * Through the documentation, several terms are used to define how classes and\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C27D1C3200\n\tfor ;\n\tMon, 24 May 2021 08:54:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B12568919;\n\tMon, 24 May 2021 10:54:51 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D65A1602B1\n\tfor ;\n\tMon, 24 May 2021 10:54:49 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 43E3F40006;\n\tMon, 24 May 2021 08:54:49 +0000 (UTC)"],"Date":"Mon, 24 May 2021 10:55:35 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210524085535.mf7eesbdbzpllll7@uno.localdomain>","References":"<20210523023155.20268-1-laurent.pinchart@ideasonboard.com>\n\t<20210523023155.20268-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210523023155.20268-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: thread: Drop doc of\n\tasynchronous signals delivery to applications","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17178,"web_url":"https://patchwork.libcamera.org/comment/17178/","msgid":"","date":"2021-05-24T08:57:51","subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: thread: Drop doc of\n\tasynchronous signals delivery to applications","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, May 24, 2021 at 10:55:35AM +0200, Jacopo Mondi wrote:\n> On Sun, May 23, 2021 at 05:31:54AM +0300, Laurent Pinchart wrote:\n> > The asynchronous signal delivery mechanism can't be used by application,\n> > as it requires libcamera to be aware of the application event loop,\n> > which has been dropped a long time ago. Drop the corresponding\n> > documentation paragraph.\n> \n> Are they still available internally to libcamera, don't they ?\n> \n> Would you like to drop the whole paragraph or only the 'available to\n> applications.. ' part ?\n\nIf I remove the parts related to applications, the only remaining text\nwould be\n\n * Asynchronous signal delivery is used internally in libcamera.\n\nIit should be expected that libcamera's features are used by libcamera\n:-) I don't think this sentence would be very useful.\n\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/thread.cpp | 8 --------\n> > 1 file changed, 8 deletions(-)\n> >\n> > diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n> > index bc1dcedea0d1..d59e43966d26 100644\n> > --- a/src/libcamera/thread.cpp\n> > +++ b/src/libcamera/thread.cpp\n> > @@ -64,14 +64,6 @@\n> > * be overridden by selecting a different connection type when calling\n> > * Signal::connect().\n> > *\n> > - * Asynchronous signal delivery is used internally in libcamera, but is also\n> > - * available to applications if desired. To use this feature, applications\n> > - * shall create receiver classes that inherit from the Object class, and\n> > - * provide an event loop to the CameraManager as explained above. Note that\n> > - * Object instances created by the application are limited to living in the\n> > - * application's main thread. Creating Object instances from another thread of\n> > - * an application causes undefined behaviour.\n> > - *\n> > * \\section thread-reentrancy Reentrancy and Thread-Safety\n> > *\n> > * Through the documentation, several terms are used to define how classes and","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B637C3200\n\tfor ;\n\tMon, 24 May 2021 08:57:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 055A368919;\n\tMon, 24 May 2021 10:57:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 769AC602B1\n\tfor ;\n\tMon, 24 May 2021 10:57:55 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DA3101315;\n\tMon, 24 May 2021 10:57:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZWuAUKN+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621846675;\n\tbh=w/LpRM99uRKdflVrH9jCL4SA+tUj46NtQxpXNmDNTDE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZWuAUKN++9md07vuejGWvVS/OToQYWjoQGi8yZMdUBP3TnoUaeEXqd7H8ZOQMsmxb\n\tfeCvTn8peUpbVxFACcJ8/8KSKaVIJdoLITMeXJSjfeWXfTPssJSAQt3GR15oNGGp9P\n\tWqSA/mbODenBTWuM6IsfBCq8EDy/r6NsE0MNaIHg=","Date":"Mon, 24 May 2021 11:57:51 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210523023155.20268-1-laurent.pinchart@ideasonboard.com>\n\t<20210523023155.20268-4-laurent.pinchart@ideasonboard.com>\n\t<20210524085535.mf7eesbdbzpllll7@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210524085535.mf7eesbdbzpllll7@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: thread: Drop doc of\n\tasynchronous signals delivery to applications","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]