[{"id":17127,"web_url":"https://patchwork.libcamera.org/comment/17127/","msgid":"","date":"2021-05-23T06:41:02","subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: thread: Enforce\n\tdispatchMessages() call context with assert","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2021-05-23 05:31:53 +0300, Laurent Pinchart wrote:\n> The Thread::dispatchMessages() function is meant to be called from\n> within the thread only. Catch incorrect usage with an ASSERT().\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/thread.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n> index 285b808332e8..bc1dcedea0d1 100644\n> --- a/src/libcamera/thread.cpp\n> +++ b/src/libcamera/thread.cpp\n> @@ -560,6 +560,8 @@ void Thread::removeMessages(Object *receiver)\n> */\n> void Thread::dispatchMessages(Message::Type type)\n> {\n> +\tASSERT(data_ == ThreadData::current());\n> +\n> \tMutexLocker locker(data_->messages_.mutex_);\n> \n> \tstd::list> &messages = data_->messages_.list_;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C6EAC3201\n\tfor ;\n\tSun, 23 May 2021 06:41:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 20AF26891E;\n\tSun, 23 May 2021 08:41:05 +0200 (CEST)","from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com\n\t[IPv6:2a00:1450:4864:20::12e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1CF8D602AE\n\tfor ;\n\tSun, 23 May 2021 08:41:04 +0200 (CEST)","by mail-lf1-x12e.google.com with SMTP id b26so19883130lfq.4\n\tfor ;\n\tSat, 22 May 2021 23:41:04 -0700 (PDT)","from localhost (h-155-4-209-203.A463.priv.bahnhof.se.\n\t[155.4.209.203]) by smtp.gmail.com with ESMTPSA id\n\te26sm1326858ljl.81.2021.05.22.23.41.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 22 May 2021 23:41:03 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"kgjXarKn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=mNURxRj2uUpmYvSNgisDtyxJvuDrd1pwO/aTlHjf8eU=;\n\tb=kgjXarKnjKeuCk8dt/Pn/ypAMDs/IWHkdQsLZXKCEPK/s7PIqGCQaA+QeKQXMUXW3a\n\tIs0Zi1EmC0lMKe88PiPyIH1Mx04Eiamg3Za4SnybqEPOvcMcbkfntvaTN+68vC8nH54w\n\t9UfY1WF4e1CLs/Oa9OQ2IHeuDZShnCPxkGFWqshaJY7JJb8yYw1gVLofZDDyA2th0lcF\n\tNhG0JHa4LTHDHcAqCv99PHZjyQYD0vY+C9B6aKv6T+BrW0EAWYq5DkEEP4monQ0zCdXm\n\tuXeOqmwOpHZ0kLw2S3ILJNbPhV4V+J9eoSoCJL6laQhO8YmTykiS7AKmRIqWgL6XHmga\n\t5nQw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=mNURxRj2uUpmYvSNgisDtyxJvuDrd1pwO/aTlHjf8eU=;\n\tb=jjWy+ciiScq5XCnuTZj0EMFZAvbMrFv8mSABSbMlRaAsvHdWmnq3PkwyJqKtFmtD0a\n\tphLuEAjgJ1T8J6v7D+1XTyaI6EVMU8E3xxQPqMjgPlE/AD9HWHA0nrsouKzUj3NHVsKe\n\twb9pDyytz4MeTLciRRoNG9EFSXauLOHwimXRuz7dH4zqxXNP+OOH/FwuvHWdSHWbFGgh\n\txu17DA2dJzTmYZs984D5CxkeBgpFdQOJsOgQrRU6un1FQKWLFDHwyc9LOTA0VAejbDMs\n\tx3E8+ga9u6W8ziZ/zvdDefQL14tO7Uuwv2l44hj/b13ReiiDqLE3M6uHfQ8fQgZiaLAr\n\ti+2Q==","X-Gm-Message-State":"AOAM531vQdXtYq5167ac7LbLya0sP+31MC287Qs5P8DuJQXwXaerO+S/\n\twLa2wnNu+VPnb/4u3HGxviWwSQ==","X-Google-Smtp-Source":"ABdhPJzgtneieljIxa8dleZG44jbffO3W93zNovulMEucZ3PjRv5pViVxxNU/oSZ/NMbVH90Pt268w==","X-Received":"by 2002:a19:4083:: with SMTP id\n\tn125mr6983097lfa.585.1621752063394; \n\tSat, 22 May 2021 23:41:03 -0700 (PDT)","Date":"Sun, 23 May 2021 08:41:02 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20210523023155.20268-1-laurent.pinchart@ideasonboard.com>\n\t<20210523023155.20268-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20210523023155.20268-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: thread: Enforce\n\tdispatchMessages() call context with assert","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17154,"web_url":"https://patchwork.libcamera.org/comment/17154/","msgid":"<96a2831d-4d45-9843-c21b-dbe03be99c29@ideasonboard.com>","date":"2021-05-24T02:43:23","subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: thread: Enforce\n\tdispatchMessages() call context with assert","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThanks for the patch\n\nOn 5/23/21 8:01 AM, Laurent Pinchart wrote:\n> The Thread::dispatchMessages() function is meant to be called from\n> within the thread only. Catch incorrect usage with an ASSERT().\n>\n> Signed-off-by: Laurent Pinchart \nReviewed-by: Umang Jain \n> ---\n> src/libcamera/thread.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n> index 285b808332e8..bc1dcedea0d1 100644\n> --- a/src/libcamera/thread.cpp\n> +++ b/src/libcamera/thread.cpp\n> @@ -560,6 +560,8 @@ void Thread::removeMessages(Object *receiver)\n> */\n> void Thread::dispatchMessages(Message::Type type)\n> {\n> +\tASSERT(data_ == ThreadData::current());\n> +\n> \tMutexLocker locker(data_->messages_.mutex_);\n> \n> \tstd::list> &messages = data_->messages_.list_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9C84C3200\n\tfor ;\n\tMon, 24 May 2021 02:43:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49AC468918;\n\tMon, 24 May 2021 04:43:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FD2C6050F\n\tfor ;\n\tMon, 24 May 2021 04:43:30 +0200 (CEST)","from localhost.localdomain (unknown [103.251.226.203])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E33A6476;\n\tMon, 24 May 2021 04:43:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J59yr5hs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621824209;\n\tbh=94RjHJT/BI1pol0wTRvipumTSQuSI1gZYIMaDSVhxVY=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=J59yr5hs6EQtdSlizvq4eZDWCjqMl67E4LTBP3Ky6BztUcY9GWokYoUXBr8Z53+bS\n\tnNz3UhEjYQ496VWanKKFVefVtdPx4K5j5O09mrcy82rXtOxxMf+WWztj4gvF231Gdn\n\tB3YQRCgbGcRklmlwHJnJegVXpVmY4SrTJbCBvaUI=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210523023155.20268-1-laurent.pinchart@ideasonboard.com>\n\t<20210523023155.20268-3-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<96a2831d-4d45-9843-c21b-dbe03be99c29@ideasonboard.com>","Date":"Mon, 24 May 2021 08:13:23 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.11.0","MIME-Version":"1.0","In-Reply-To":"<20210523023155.20268-3-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: thread: Enforce\n\tdispatchMessages() call context with assert","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17170,"web_url":"https://patchwork.libcamera.org/comment/17170/","msgid":"","date":"2021-05-24T05:39:20","subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: thread: Enforce\n\tdispatchMessages() call context with assert","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent, thank you for the patch.\n\nOn Mon, May 24, 2021 at 11:43 AM Umang Jain \nwrote:\n\n> Hi Laurent,\n>\n> Thanks for the patch\n>\n> On 5/23/21 8:01 AM, Laurent Pinchart wrote:\n> > The Thread::dispatchMessages() function is meant to be called from\n> > within the thread only. Catch incorrect usage with an ASSERT().\n> >\n> > Signed-off-by: Laurent Pinchart \n> Reviewed-by: Umang Jain \n>\n\nReviewed-by: Hirokazu Honda \n\n\n> > ---\n> > src/libcamera/thread.cpp | 2 ++\n> > 1 file changed, 2 insertions(+)\n> >\n> > diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\n> > index 285b808332e8..bc1dcedea0d1 100644\n> > --- a/src/libcamera/thread.cpp\n> > +++ b/src/libcamera/thread.cpp\n> > @@ -560,6 +560,8 @@ void Thread::removeMessages(Object *receiver)\n> > */\n> > void Thread::dispatchMessages(Message::Type type)\n> > {\n> > + ASSERT(data_ == ThreadData::current());\n> > +\n> > MutexLocker locker(data_->messages_.mutex_);\n> >\n> > std::list> &messages =\n> data_->messages_.list_;\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6899C3200\n\tfor ;\n\tMon, 24 May 2021 05:39:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 442826891B;\n\tMon, 24 May 2021 07:39:33 +0200 (CEST)","from mail-ej1-x635.google.com (mail-ej1-x635.google.com\n\t[IPv6:2a00:1450:4864:20::635])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 215D0602AD\n\tfor ;\n\tMon, 24 May 2021 07:39:32 +0200 (CEST)","by mail-ej1-x635.google.com with SMTP id z12so38383887ejw.0\n\tfor ;\n\tSun, 23 May 2021 22:39:32 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"VkVvJMvV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=chzMd05CgEJUwjT4WZ6+IWQxAn6U6INRsRfj/d5xh9A=;\n\tb=VkVvJMvVwFruRkbSaQgmJ7loK+Y7ak6BSFzaJl3RNyk97FV/dAvB4QuAJA4ZYWq1El\n\tOCTaHM6232KE6yo611WhpBwRicdYI9A3oTzNHLvfgNkFjxUDfXLY/wfQH3NCeqVvuL63\n\tpuK2BydxJmjEHoBytEPaFY2kInAagdtFEGd5Y=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=chzMd05CgEJUwjT4WZ6+IWQxAn6U6INRsRfj/d5xh9A=;\n\tb=ZxEbB4CK6NhOlFGS91MAesQaTdq1x+avaDHA84bt2jb7QQBB6UR+9xYfzCiwKBZ5ly\n\tmXPsLbtZjpid5Qh4mNbhPx7RTt5CaLYWrjot3n6XJuu83kHKgMIyKiAzG1lM4J1WKdf1\n\tr9RLeuh54P5wu2ZiiTkmjpcDtqMeDElvZS36kNBCTDzIKmb0b1petWEkj17R9pT8iCp9\n\thgtPiNNhIyytglW+HVWGgyhGq1NnXMOEklhAfsGxShRrAJ1iqSXMGpK7CpyApIHENDvj\n\tEVZumebv/5BQXoFaV8fFuxKHvzrwPJuFMVvtDJgcQSoIbuKYswgFRVSiIvryDoSkpeL0\n\t4QgA==","X-Gm-Message-State":"AOAM531P29tND+CvF25yN8WnPZ1JW+XUmtKs6F7wPctGbajDu/8YbovR\n\tRqgHh6jUMZGuZt/uFxPLdUA9F2QCbdDPhOB23Dy/gw==","X-Google-Smtp-Source":"ABdhPJzJiIIOphHP0QSnVoAudZhPNoDsNd9WoNS3ZzaM7WGnMUhzNF94lB7rUkWrokTml5sfWvHqHq5SuvyFCugCiMA=","X-Received":"by 2002:a17:907:d1a:: with SMTP id\n\tgn26mr19081340ejc.42.1621834771788; \n\tSun, 23 May 2021 22:39:31 -0700 (PDT)","MIME-Version":"1.0","References":"<20210523023155.20268-1-laurent.pinchart@ideasonboard.com>\n\t<20210523023155.20268-3-laurent.pinchart@ideasonboard.com>\n\t<96a2831d-4d45-9843-c21b-dbe03be99c29@ideasonboard.com>","In-Reply-To":"<96a2831d-4d45-9843-c21b-dbe03be99c29@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Mon, 24 May 2021 14:39:20 +0900","Message-ID":"","To":"Umang Jain ","Content-Type":"multipart/alternative; boundary=\"000000000000750a0405c30cd5cd\"","Subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: thread: Enforce\n\tdispatchMessages() call context with assert","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]