[{"id":17109,"web_url":"https://patchwork.libcamera.org/comment/17109/","msgid":"<20210522061553.5nvihzd4zhlpc4gz@basti-TUXEDO-Book-XA1510>","date":"2021-05-22T06:15:53","subject":"Re: [libcamera-devel] [PATCH] libcamera: log: Hide value of the\n\tASSERT() macro","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"content":"Hey Laurent,\n\nThank you for the patch.\n\nOn 22.05.2021 03:23, Laurent Pinchart wrote:\n>ASSERT() is a function-like macro that expands to internal code. Hide\n>the expansion from the generated documentation, as it would only confuse\n>the reader.\n\nSounds good.\n\n>\n>Signed-off-by: Laurent Pinchart \nReviewed-by: Sebastian Fricke \n\n>---\n> src/libcamera/log.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n>diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n>index 985952249289..dd991647b9bc 100644\n>--- a/src/libcamera/log.cpp\n>+++ b/src/libcamera/log.cpp\n>@@ -990,6 +990,7 @@ LogMessage _log(const LogCategory *category, LogSeverity severity,\n>\n> /**\n> * \\def ASSERT(condition)\n>+ * \\hideinitializer\n> * \\brief Abort program execution if assertion fails\n> *\n> * If \\a condition is false, ASSERT() logs an error message with the Fatal log\n>-- \n>Regards,\n>\n>Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67FA7C3201\n\tfor ;\n\tSat, 22 May 2021 06:15:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BF7146891E;\n\tSat, 22 May 2021 08:15:56 +0200 (CEST)","from mout02.posteo.de (mout02.posteo.de [185.67.36.66])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C2FA602AF\n\tfor ;\n\tSat, 22 May 2021 08:15:55 +0200 (CEST)","from submission (posteo.de [89.146.220.130]) \n\tby mout02.posteo.de (Postfix) with ESMTPS id 809A82400E5\n\tfor ;\n\tSat, 22 May 2021 08:15:54 +0200 (CEST)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4FnCs56sxdz6tm9;\n\tSat, 22 May 2021 08:15:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"fbb/pO95\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1621664154; bh=Nhetq0xAO75zja0qSSP4lB8wPO+D+hpdrOAN/wny8Eg=;\n\th=Date:From:To:Cc:Subject:From;\n\tb=fbb/pO95eua+Axizb6XDxRCXyjEHr78cA83C7RWz9J4bmP4uU9gy2ZL69niSyyLB8\n\txgLz612xQKJ7LAaKisqXXFo6SPKKd4glzd6LA4QO+A6nM7Sazmoai9yM+wvsLbL4HH\n\tJUeeLYTHl2Ed2sXj9rfnHwCbt8enIMfGF+osNSUiK3T2QjsaNC+198s5JeKFfCZeAT\n\teCgNI82y+GXiP8Y0PIFj7gVirDzqEKU+9FyXt+h/TW8lIHyJOHiMMcniJ0h6044HD1\n\ty3MRnSRxOTQgn7i54qt3n33mEVCvfxbZd/N6vAGVIoDlbsx87SmEUECiMVPjTjWuUe\n\tsQ/5camep9+7g==","Date":"Sat, 22 May 2021 06:15:53 +0000","From":"Sebastian Fricke ","To":"Laurent Pinchart ","Message-ID":"<20210522061553.5nvihzd4zhlpc4gz@basti-TUXEDO-Book-XA1510>","References":"<20210522002309.26083-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Disposition":"inline","In-Reply-To":"<20210522002309.26083-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: log: Hide value of the\n\tASSERT() macro","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17118,"web_url":"https://patchwork.libcamera.org/comment/17118/","msgid":"<8f99676b-3b7a-991d-d2ee-99a3282123fe@ideasonboard.com>","date":"2021-05-22T10:59:17","subject":"Re: [libcamera-devel] [PATCH] libcamera: log: Hide value of the\n\tASSERT() macro","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch\n\nOn 5/22/21 5:53 AM, Laurent Pinchart wrote:\n> ASSERT() is a function-like macro that expands to internal code. Hide\n> the expansion from the generated documentation, as it would only confuse\n> the reader.\n>\n> Signed-off-by: Laurent Pinchart \nReviewed-by: Umang Jain \n> ---\n> src/libcamera/log.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n> index 985952249289..dd991647b9bc 100644\n> --- a/src/libcamera/log.cpp\n> +++ b/src/libcamera/log.cpp\n> @@ -990,6 +990,7 @@ LogMessage _log(const LogCategory *category, LogSeverity severity,\n> \n> /**\n> * \\def ASSERT(condition)\n> + * \\hideinitializer\n> * \\brief Abort program execution if assertion fails\n> *\n> * If \\a condition is false, ASSERT() logs an error message with the Fatal log","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 57B3DC3200\n\tfor ;\n\tSat, 22 May 2021 10:59:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92CFF68918;\n\tSat, 22 May 2021 12:59:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24CC0601A9\n\tfor ;\n\tSat, 22 May 2021 12:59:23 +0200 (CEST)","from localhost.localdomain (unknown [103.251.226.203])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E9B2E3F1;\n\tSat, 22 May 2021 12:59:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"azvGPR3q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621681162;\n\tbh=3+ZRjq0lJkMeuT+aLimyPUoP44UNI5Zg/yJ5+PEyZ6M=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=azvGPR3qzjWEqo1Fs5aqW5w+9yoe6GXmximBHR3YsrZDozDvjYi5j7P2mLb5d8k2l\n\t1G1fJIoBikW35xDf7n4Kya94/DQJ9PsmrLb6a76O/Vi3qbIJVe7sZi3qWIgwvnHz7u\n\t2vVjAkJav4UG43jchDaaSsRlUSdTaOIi33h8fXkY=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210522002309.26083-1-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<8f99676b-3b7a-991d-d2ee-99a3282123fe@ideasonboard.com>","Date":"Sat, 22 May 2021 16:29:17 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.11.0","MIME-Version":"1.0","In-Reply-To":"<20210522002309.26083-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: log: Hide value of the\n\tASSERT() macro","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]