[{"id":17094,"web_url":"https://patchwork.libcamera.org/comment/17094/","msgid":"<20210521115514.g7ebo24ouhjkumb2@uno.localdomain>","date":"2021-05-21T11:55:14","subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: ipu3: Set output frame\n\tduration metadata","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Fri, May 21, 2021 at 07:55:34PM +0900, Paul Elder wrote:\n> The sensor frame duration should be set by the IPA. Hardcode it for now.\n>\n> Signed-off-by: Paul Elder \n\nWith a \\todo\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/ipu3/ipu3.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index f5343547..35c24052 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -269,6 +269,10 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n> \tif (agcAlgo_->updateControls())\n> \t\tsetControls(frame);\n>\n> +\tctrls.set(controls::FrameDurations,\n> +\t\t { static_cast(33334),\n> +\t\t static_cast(33334) });\n> +\n> \tIPU3Action op;\n> \top.op = ActionMetadataReady;\n> \top.controls = ctrls;\n> --\n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C153C3200\n\tfor ;\n\tFri, 21 May 2021 11:54:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C97666891E;\n\tFri, 21 May 2021 13:54:29 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A0B068911\n\tfor ;\n\tFri, 21 May 2021 13:54:28 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 242AC240003;\n\tFri, 21 May 2021 11:54:27 +0000 (UTC)"],"Date":"Fri, 21 May 2021 13:55:14 +0200","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20210521115514.g7ebo24ouhjkumb2@uno.localdomain>","References":"<20210521105534.1125303-1-paul.elder@ideasonboard.com>\n\t<20210521105534.1125303-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210521105534.1125303-2-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: ipu3: Set output frame\n\tduration metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17123,"web_url":"https://patchwork.libcamera.org/comment/17123/","msgid":"","date":"2021-05-23T00:17:12","subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: ipu3: Set output frame\n\tduration metadata","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, May 21, 2021 at 01:55:14PM +0200, Jacopo Mondi wrote:\n> On Fri, May 21, 2021 at 07:55:34PM +0900, Paul Elder wrote:\n> > The sensor frame duration should be set by the IPA. Hardcode it for now.\n> >\n> > Signed-off-by: Paul Elder \n> \n> With a \\todo\n> \n> Reviewed-by: Jacopo Mondi \n\nDitto, the todo is important.\n\nReviewed-by: Laurent Pinchart \n\n> > ---\n> > src/ipa/ipu3/ipu3.cpp | 4 ++++\n> > 1 file changed, 4 insertions(+)\n> >\n> > diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> > index f5343547..35c24052 100644\n> > --- a/src/ipa/ipu3/ipu3.cpp\n> > +++ b/src/ipa/ipu3/ipu3.cpp\n> > @@ -269,6 +269,10 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n> > \tif (agcAlgo_->updateControls())\n> > \t\tsetControls(frame);\n> >\n> > +\tctrls.set(controls::FrameDurations,\n> > +\t\t { static_cast(33334),\n> > +\t\t static_cast(33334) });\n> > +\n> > \tIPU3Action op;\n> > \top.op = ActionMetadataReady;\n> > \top.controls = ctrls;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FCDBC3200\n\tfor ;\n\tSun, 23 May 2021 00:17:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1DB696891A;\n\tSun, 23 May 2021 02:17:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E7E6C60510\n\tfor ;\n\tSun, 23 May 2021 02:17:15 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 485162A8;\n\tSun, 23 May 2021 02:17:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hDrY1xh9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621729035;\n\tbh=zwP2JGoXcxPjzW/UnT4ArLcUoH49SFYiB6P5AjZkp70=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hDrY1xh99fmP8gyZCM+CaXxjWzbIty3/5dFjTv/ku4c6Zo9KAyV2AmUXj9BVpBC4x\n\tyee3bSvRhM4eTTFlNZrlIKRcseKVeOtm+jjJHO7mqVMrCruEUQyNlbmr/d6RWf1F/D\n\t98OlV7XBd1GMf/OH7dRLfvmElCrzmF5Nu/WSOX9s=","Date":"Sun, 23 May 2021 03:17:12 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210521105534.1125303-1-paul.elder@ideasonboard.com>\n\t<20210521105534.1125303-2-paul.elder@ideasonboard.com>\n\t<20210521115514.g7ebo24ouhjkumb2@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210521115514.g7ebo24ouhjkumb2@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: ipu3: Set output frame\n\tduration metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":17167,"web_url":"https://patchwork.libcamera.org/comment/17167/","msgid":"","date":"2021-05-24T05:00:03","subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: ipu3: Set output frame\n\tduration metadata","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Paul, thank you for the patch.\n\nOn Sun, May 23, 2021 at 9:17 AM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> On Fri, May 21, 2021 at 01:55:14PM +0200, Jacopo Mondi wrote:\n> > On Fri, May 21, 2021 at 07:55:34PM +0900, Paul Elder wrote:\n> > > The sensor frame duration should be set by the IPA. Hardcode it for\n> now.\n> > >\n> > > Signed-off-by: Paul Elder \n> >\n> > With a \\todo\n> >\n> > Reviewed-by: Jacopo Mondi \n>\n> Ditto, the todo is important.\n>\n> Reviewed-by: Laurent Pinchart \n>\n>\nReviewed-by: Hirokazu Honda \n\n\n> > > ---\n> > > src/ipa/ipu3/ipu3.cpp | 4 ++++\n> > > 1 file changed, 4 insertions(+)\n> > >\n> > > diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> > > index f5343547..35c24052 100644\n> > > --- a/src/ipa/ipu3/ipu3.cpp\n> > > +++ b/src/ipa/ipu3/ipu3.cpp\n> > > @@ -269,6 +269,10 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n> > > if (agcAlgo_->updateControls())\n> > > setControls(frame);\n> > >\n> > > + ctrls.set(controls::FrameDurations,\n> > > + { static_cast(33334),\n> > > + static_cast(33334) });\n> > > +\n> > > IPU3Action op;\n> > > op.op = ActionMetadataReady;\n> > > op.controls = ctrls;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34592C3201\n\tfor ;\n\tMon, 24 May 2021 05:00:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AB3F86891B;\n\tMon, 24 May 2021 07:00:15 +0200 (CEST)","from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com\n\t[IPv6:2a00:1450:4864:20::52e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E07E7602AD\n\tfor ;\n\tMon, 24 May 2021 07:00:14 +0200 (CEST)","by mail-ed1-x52e.google.com with SMTP id j10so12825429edw.8\n\tfor ;\n\tSun, 23 May 2021 22:00:14 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"LVq/GoXp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=1agZPw7xFrbv3vC6EkQrtylQp3rGomdT6rRHowYddO8=;\n\tb=LVq/GoXpXrReTtdRSNEfJUCDRAufEhP7IFYqdd35+yog5hW03Rj0/N9UgrpDdVnk+3\n\t5P1zqL766Fh2+/fenASDPLejGJrScgd2Mc8oGBvAxwlFzoXY9fraDPzAQccKXjuB4D8C\n\tEVZBuUMyzYYDzJR64NQOioTV1d1pKK7xkG4CM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=1agZPw7xFrbv3vC6EkQrtylQp3rGomdT6rRHowYddO8=;\n\tb=opbkCLZpPer6kDyQPgiZjQNDNKpcN3GgPz1aIWvGuH6FUnUc49oFv2cd/ukwDdYi5i\n\t1qxcfeVGJNyJ/XfaJkW1wSin6DGaSeUFzqLb6N4xp26tnWtOgWV5yGA/6iI2xVJVumNj\n\t0dP1WU8s0CYaTRg+1xC5yTzW4oYdPZS83n9F9TNMekBCGXpMwbfXPgnohRmKhxrADzre\n\tU1MXtB6mxHeAafLjyd8JGUW0vbaWWVuMh03f7qvJ4rpBrfe7OuX6GRwrPsBtL8AWSisC\n\tbOU672vroByE8FkU8r7gYnszDn66UmiKfTue5NzpZvib+WQ+RFsFCUMiKk6UY3fATcMK\n\tTscg==","X-Gm-Message-State":"AOAM5331RXJa3kruGlef/jugbHbfd+Afx+ieyJ7MvE1U6LJfi6xO6RFX\n\tULR3pg/kMRFXVqGbJRHi3xUt9mn+Pxy6TwFMckoasQ==","X-Google-Smtp-Source":"ABdhPJwqbQtuIewhTBBVu1Vqu+8fA8BLAs3eu3GTNHlbF6RdQAZ+6A50Ers8h8ueNhpAdFlpyMBRui3iahtjwJuuxrU=","X-Received":"by 2002:a05:6402:50c6:: with SMTP id\n\th6mr23770361edb.327.1621832414559; \n\tSun, 23 May 2021 22:00:14 -0700 (PDT)","MIME-Version":"1.0","References":"<20210521105534.1125303-1-paul.elder@ideasonboard.com>\n\t<20210521105534.1125303-2-paul.elder@ideasonboard.com>\n\t<20210521115514.g7ebo24ouhjkumb2@uno.localdomain>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Mon, 24 May 2021 14:00:03 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"000000000000f48f3205c30c48b5\"","Subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: ipu3: Set output frame\n\tduration metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]