[{"id":17224,"web_url":"https://patchwork.libcamera.org/comment/17224/","msgid":"","date":"2021-05-25T04:38:01","subject":"Re: [libcamera-devel] [PATCH v5 1/6] libcamera: controls: Add\n\tsensor test pattern mode","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Gentle ping for reviewing this patch series. Thanks in advance.\n\nOn Wed, May 19, 2021 at 4:59 PM Hirokazu Honda wrote:\n\n> The control is used to report available sensor test pattern modes\n> and also specify the mode to sensor.\n>\n> Signed-off-by: Hirokazu Honda \n> Reviewed-by: Jacopo Mondi \n> ---\n> src/libcamera/control_ids.yaml | 58 ++++++++++++++++++++++++++++++++++\n> 1 file changed, 58 insertions(+)\n>\n> diff --git a/src/libcamera/control_ids.yaml\n> b/src/libcamera/control_ids.yaml\n> index 88d81ac4..b1fe1dc6 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -615,4 +615,62 @@ controls:\n> detection, additional format conversions etc) count as an\n> additional\n> pipeline stage.\n>\n> + - TestPatternMode:\n> + type: int32_t\n> + draft: true\n> + description: |\n> + Control to select the test pattern mode. Currently identical to\n> + ANDROID_SENSOR_TEST_PATTERN_MODE.\n> + enum:\n> + - name: TestPatternModeOff\n> + value: 0\n> + description: |\n> + No test pattern mode is used. The camera device returns\n> frames from\n> + the image sensor.\n> + - name: TestPatternModeSolidColor\n> + value: 1\n> + description: |\n> + Each pixel in [R, G_even, G_odd, B] is replaced by its\n> respective\n> + color channel provided in test pattern data.\n> + \\todo Add control for test pattern data.\n> + - name: TestPatternModeColorBars\n> + value: 2\n> + description: |\n> + All pixel data is replaced with an 8-bar color pattern. The\n> vertical\n> + bars (left-to-right) are as follows; white, yellow, cyan,\n> green,\n> + magenta, red, blue and black. Each bar should take up 1/8 of\n> the\n> + sensor pixel array width. When this is not possible, the bar\n> size\n> + should be rounded down to the nearest integer and the pattern\n> can\n> + repeat on the right side. Each bar's height must always take\n> up the\n> + full sensor pixel array height.\n> + - name: TestPatternModeColorBarsFadeToGray\n> + value: 3\n> + description: |\n> + The test pattern is similar to TestPatternModeColorBars,\n> + except that each bar should start at its specified color at\n> the top\n> + and fade to gray at the bottom. Furthermore each bar is\n> further\n> + subdevided into a left and right half. The left half should\n> have a\n> + smooth gradient, and the right half should have a quantized\n> + gradient. In particular, the right half's should consist of\n> blocks\n> + of the same color for 1/16th active sensor pixel array width.\n> The\n> + least significant bits in the quantized gradient should be\n> copied\n> + from the most significant bits of the smooth gradient. The\n> height of\n> + each bar should always be a multiple of 128. When this is not\n> the\n> + case, the pattern should repeat at the bottom of the image.\n> + - name: TestPatternModePn9\n> + value: 4\n> + description: |\n> + All pixel data is replaced by a pseudo-random sequence\n> generated\n> + from a PN9 512-bit sequence (typically implemented in\n> hardware with\n> + a linear feedback shift register). The generator should be\n> reset at\n> + the beginning of each frame, and thus each subsequent raw\n> frame with\n> + this test pattern should be exactly the same as the last.\n> + - name: TestPatternModeCustom1\n> + value: 5\n> + description: |\n> + The first custom test pattern. All custom patterns that are\n> + available only on this camera device are at least this numeric\n> + value. All of the custom test patterns will be static (that\n> is the\n> + raw image must not vary from frame to frame).\n> +\n> ...\n> --\n> 2.31.1.751.gd2f1c929bd-goog\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52CBEC3200\n\tfor ;\n\tTue, 25 May 2021 04:38:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 874A968921;\n\tTue, 25 May 2021 06:38:14 +0200 (CEST)","from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com\n\t[IPv6:2a00:1450:4864:20::62a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A2EA602AC\n\tfor ;\n\tTue, 25 May 2021 06:38:13 +0200 (CEST)","by mail-ej1-x62a.google.com with SMTP id f18so14970914ejq.10\n\tfor ;\n\tMon, 24 May 2021 21:38:13 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"XDFaNzT4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=BYoPDcMrLd2J8LiYrSKnFDdFX+ceoLVAQEbT99UvFmA=;\n\tb=XDFaNzT4yIIG2b9489sxIo2BeockUzjxTe1ADmK4BNK8dZOmlH7p8jPz770KGA45hF\n\tXJJSFms4A8d9P0fZhwINZtbWlzjOAOfouMmRvKmSQL1JdbJkpoEKxa+PKTAspaP0zkvL\n\t3KjzeX48OnQmAXOspdoQwe/jwcE77iCO7vHMI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=BYoPDcMrLd2J8LiYrSKnFDdFX+ceoLVAQEbT99UvFmA=;\n\tb=NmRKwRXNVZMBLVuYs0GCaE9X+p1V0Kah7q4d8WuwJwkL0A7tBRqUYtl/WWzKhI0oMD\n\tVBVXp42476nqmDzBY3cJlOCFGN73/5g9HgA98Z+YHXaQnlZ6FD5VzTjHN+tr2XT8Wif7\n\t0oHmETklz/4e1FMVwKEm7aqWZHGkASeELmtpSx7rcO/G6VYtdz4z1HtbWF3ImScoBSLw\n\t97L+vXpw4P+j6CFZZh909vfr2JBVCzFsVmeWIvCvsazXWTpAG/8Jb5jgMV/hGpOKxmMf\n\t3FVUdiGsF63vy6LC8XpZ/M4uNXRG/w653yKyczReK4tcXfbPSOhLcZXKxFbfft5QwbSB\n\tbjVw==","X-Gm-Message-State":"AOAM531IvDO60Mcwx4BFMii2glFd9jZI/7Xlgl+pFwR8pv2VxkGx0B+a\n\tIvWljiy03f9emtvJXzwmWR1ctZadkLxuymsoEFiGiAn4sDs=","X-Google-Smtp-Source":"ABdhPJwau+oCc8OwTE1T0e3GpPH7juYDSVKBOY/unnW7Zc5Eh5TmGYxBliWmx8krdLYMNMrVv7d/ukhsa+/wkKHblMQ=","X-Received":"by 2002:a17:906:4d44:: with SMTP id\n\tb4mr26083362ejv.306.1621917492791; \n\tMon, 24 May 2021 21:38:12 -0700 (PDT)","MIME-Version":"1.0","References":"<20210519075941.1337388-1-hiroh@chromium.org>","In-Reply-To":"<20210519075941.1337388-1-hiroh@chromium.org>","From":"Hirokazu Honda ","Date":"Tue, 25 May 2021 13:38:01 +0900","Message-ID":"","To":"libcamera devel ","Content-Type":"multipart/alternative; boundary=\"000000000000035c4805c32018b8\"","Subject":"Re: [libcamera-devel] [PATCH v5 1/6] libcamera: controls: Add\n\tsensor test pattern mode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]