[{"id":16967,"web_url":"https://patchwork.libcamera.org/comment/16967/","msgid":"","date":"2021-05-17T03:41:16","subject":"Re: [libcamera-devel] [PATCH 3/4] android: camera_metadata: Make\n\tinternal functions private","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent,\n\nOn Sun, May 16, 2021 at 3:38 AM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> The resize() function and the addEntry() override that takes a void\n> pointer are not meant to be called by the user of the CameraMetadata\n> class. Make them private.\n>\n> Signed-off-by: Laurent Pinchart \n>\n\nReviewed-by: Hirokazu Honda \n\n\n> ---\n> src/android/camera_metadata.h | 7 ++++---\n> 1 file changed, 4 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> index f95c34581fe4..d7c8d9df689f 100644\n> --- a/src/android/camera_metadata.h\n> +++ b/src/android/camera_metadata.h\n> @@ -24,7 +24,6 @@ public:\n> CameraMetadata &operator=(const CameraMetadata &other);\n>\n> bool isValid() const { return valid_; }\n> - bool resize(size_t count, size_t size);\n> bool getEntry(uint32_t tag, camera_metadata_ro_entry_t *entry)\n> const;\n>\n> template @@ -72,14 +71,16 @@ public:\n> return updateEntry(tag, data.data(), data.size());\n> }\n>\n> - bool addEntry(uint32_t tag, const void *data, size_t count,\n> - size_t elementSize);\n> bool updateEntry(uint32_t tag, const void *data, size_t count);\n>\n> camera_metadata_t *get();\n> const camera_metadata_t *get() const;\n>\n> private:\n> + bool resize(size_t count, size_t size);\n> + bool addEntry(uint32_t tag, const void *data, size_t count,\n> + size_t elementSize);\n> +\n> camera_metadata_t *metadata_;\n> bool valid_;\n> };\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA12DC31FC\n\tfor ;\n\tMon, 17 May 2021 03:41:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89EFE6891E;\n\tMon, 17 May 2021 05:41:28 +0200 (CEST)","from mail-ej1-x630.google.com (mail-ej1-x630.google.com\n\t[IPv6:2a00:1450:4864:20::630])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 71E67602B1\n\tfor ;\n\tMon, 17 May 2021 05:41:27 +0200 (CEST)","by mail-ej1-x630.google.com with SMTP id k14so3489828eji.2\n\tfor ;\n\tSun, 16 May 2021 20:41:27 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"H0a+3cWj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=Z8H2KcasBrtHITEW+xLR8KUKI5vIbolbAOD7ZrBfjSA=;\n\tb=H0a+3cWjaj40z7Ejbe7m+0aEhOko3VIsxvPvGVK8GMN77dfaQR1jriWAgjsXFIlT3p\n\tn678Jn5oeWBlJ5S50pKmvrWkXwb3dGgNaKqPnISzuSMzxPj1euQlI5GuEs0ggHsdMQov\n\tG/uv4Tnu6rDl6Ht01JXVE0q9P96p63bjsQE7I=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Z8H2KcasBrtHITEW+xLR8KUKI5vIbolbAOD7ZrBfjSA=;\n\tb=WrEUYUg6hZ/PwYKAEzpWsfTUcJ5Xw04dpITgkBw9Rvi3os/DDtG9gVwd3G8X3q+sw6\n\tpNzKOGIePb8NCTlmP/BC3t5Dopf5fE9pu2TABzPArVYo+uy5D2bar9WnuYt02Wmqc/99\n\t8IoRsK6Q4GZc+VAcfk7gJaGu4dztoR1Vf9mpVIPf9b2LzysBWLHRw4ShZEk+0DBJ0ppo\n\tw6D6GkGwSTSSFz6a70FUFvbgpQlTOBtbidJ+vvArlWO3PYFBXaqqVB3zMvAEHa+LGguG\n\t/jmY1IujtpGPcufei/52KrMUhJLt89ZLgnsHZMnzSLPLjBb0KS7y/H2M/gqOEoinzxjl\n\tFkuA==","X-Gm-Message-State":"AOAM5339prS69tPEerfNYJnLKYpDhex1FPACGbuw/2wKFYqvBN6G0eW4\n\tDjgV/BvUN4ocfMikGJEUOeIb3gYIy71eQBkGAvUAJw==","X-Google-Smtp-Source":"ABdhPJyPXK2nKxkmhrILNLKbkXtlSz2ZQv9YWnl/3bJ91lWPRws3LZk8VsziUXHo957sfwbWx54Y4RoFuHkxAaCv418=","X-Received":"by 2002:a17:907:209b:: with SMTP id\n\tpv27mr60341854ejb.475.1621222887165; \n\tSun, 16 May 2021 20:41:27 -0700 (PDT)","MIME-Version":"1.0","References":"<20210515183826.21003-1-laurent.pinchart@ideasonboard.com>\n\t<20210515183826.21003-4-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20210515183826.21003-4-laurent.pinchart@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Mon, 17 May 2021 12:41:16 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"0000000000004a9b0805c27e5eb8\"","Subject":"Re: [libcamera-devel] [PATCH 3/4] android: camera_metadata: Make\n\tinternal functions private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16987,"web_url":"https://patchwork.libcamera.org/comment/16987/","msgid":"","date":"2021-05-17T09:37:39","subject":"Re: [libcamera-devel] [PATCH 3/4] android: camera_metadata: Make\n\tinternal functions private","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 15/05/2021 19:38, Laurent Pinchart wrote:\n> The resize() function and the addEntry() override that takes a void\n> pointer are not meant to be called by the user of the CameraMetadata\n> class. Make them private.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/android/camera_metadata.h | 7 ++++---\n> 1 file changed, 4 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> index f95c34581fe4..d7c8d9df689f 100644\n> --- a/src/android/camera_metadata.h\n> +++ b/src/android/camera_metadata.h\n> @@ -24,7 +24,6 @@ public:\n> \tCameraMetadata &operator=(const CameraMetadata &other);\n> \n> \tbool isValid() const { return valid_; }\n> -\tbool resize(size_t count, size_t size);\n> \tbool getEntry(uint32_t tag, camera_metadata_ro_entry_t *entry) const;\n> \n> \ttemplate @@ -72,14 +71,16 @@ public:\n> \t\treturn updateEntry(tag, data.data(), data.size());\n> \t}\n> \n> -\tbool addEntry(uint32_t tag, const void *data, size_t count,\n> -\t\t size_t elementSize);\n> \tbool updateEntry(uint32_t tag, const void *data, size_t count);\n> \n> \tcamera_metadata_t *get();\n> \tconst camera_metadata_t *get() const;\n> \n> private:\n> +\tbool resize(size_t count, size_t size);\n> +\tbool addEntry(uint32_t tag, const void *data, size_t count,\n> +\t\t size_t elementSize);\n> +\n> \tcamera_metadata_t *metadata_;\n> \tbool valid_;\n> };\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C05BAC31FC\n\tfor ;\n\tMon, 17 May 2021 09:37:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 317DB6891F;\n\tMon, 17 May 2021 11:37:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82DB4602B2\n\tfor ;\n\tMon, 17 May 2021 11:37:42 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ED09188F;\n\tMon, 17 May 2021 11:37:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pFcPNFvW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621244262;\n\tbh=F/lCbwDcJ2P6ztrCFF2bUyguJRGQEcw1Vi4XDjzV2LY=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=pFcPNFvWgwVrL6vujy+kfju2Fg0K0DTI70/N1piypDgKV5QeB+d0o8uMUNmel1xKY\n\tYD1VdZFEJHE4FYy4Lo3bJUq4lSqWT+6KpcQu/YTa69eNUhf50px07/FSx4QLYkyYyr\n\txVZzQpUuE5TfIpyPI/l43zsKJ65rrohcRzXKo3N0=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210515183826.21003-1-laurent.pinchart@ideasonboard.com>\n\t<20210515183826.21003-4-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 17 May 2021 10:37:39 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"<20210515183826.21003-4-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 3/4] android: camera_metadata: Make\n\tinternal functions private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]