[{"id":16966,"web_url":"https://patchwork.libcamera.org/comment/16966/","msgid":"","date":"2021-05-17T03:39:47","subject":"Re: [libcamera-devel] [PATCH 2/4] android: camera_metadata:\n\tConstify argument to addEntry() and updateEntry()","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent,\n\n\n\nOn Sun, May 16, 2021 at 3:38 AM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> The addEntry() and updateEntry() overrides that take a reference to a\n> container don't need to modify the container. Make it const.\n>\n> Signed-off-by: Laurent Pinchart \n>\n\nReviewed-by: Hirokazu Honda \n\n\n> ---\n> src/android/camera_metadata.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> index 56df6f1c9008..f95c34581fe4 100644\n> --- a/src/android/camera_metadata.h\n> +++ b/src/android/camera_metadata.h\n> @@ -42,7 +42,7 @@ public:\n>\n> template typename T = typename S::value_type>\n> - bool addEntry(uint32_t tag, S &data)\n> + bool addEntry(uint32_t tag, const S &data)\n> {\n> return addEntry(tag, data.data(), data.size(), sizeof(T));\n> }\n> @@ -67,7 +67,7 @@ public:\n>\n> template typename T = typename S::value_type>\n> - bool updateEntry(uint32_t tag, S &data)\n> + bool updateEntry(uint32_t tag, const S &data)\n> {\n> return updateEntry(tag, data.data(), data.size());\n> }\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35080C31FB\n\tfor ;\n\tMon, 17 May 2021 03:40:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E81C26891E;\n\tMon, 17 May 2021 05:39:59 +0200 (CEST)","from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com\n\t[IPv6:2a00:1450:4864:20::62d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 06AFD602B1\n\tfor ;\n\tMon, 17 May 2021 05:39:58 +0200 (CEST)","by mail-ej1-x62d.google.com with SMTP id k14so3486844eji.2\n\tfor ;\n\tSun, 16 May 2021 20:39:58 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"K8q5drRt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=r8GFRHsRZrGfcXQ9oYeeWeSRAR8HltnlpUEV9QQkgGk=;\n\tb=K8q5drRtrwRHWear0aGl8ujgpN2KLuiNh+ZtcUkd5kQsDiJJgex+ZqyRrSomuAdsi4\n\t0XVsJmW0qPrLFRuBqVkfxdil+mOnpVeDBMUic9ddaqKVeS1axZE3qtmPDJcGVIq3s5fn\n\tpoxCmfsmiXAeWhte9lOXH+uKuB5ULJfLkaZ8I=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=r8GFRHsRZrGfcXQ9oYeeWeSRAR8HltnlpUEV9QQkgGk=;\n\tb=TVQCKLRs1Onh6kfUibdXbg57f2mc6Flx7j++Q8WnyiDtdgQ/rQE6/lCiBbgWHix3p9\n\tOAh/z8rS0DDfeG3Cez2Q/bhJbxMauLE2VEjiqsK+fJTvjwsGj/dg6UXA0Wyc5w6lLHA3\n\tGxKCg1DJcz1b3AYjSzsli0udEgIMf1B79sS1Kl3OmUwvKj0Rnz+2An4AsTOZGrBCVmIQ\n\t4KAGBiwLLoyAJcN9CKOMcQiuzQZ/bRbykElBTtUH6yvAw49Ki9n+7pdWGwF8ZyQAAmaL\n\t5Lk9I11H72ApIgwar0itnL8WLQd6sr71d9VLAlzsiIYdkTsLFFt7NXaGgQq88AQ9+fHH\n\trKKQ==","X-Gm-Message-State":"AOAM531MQqwOG1ucffq9glGZmRxtYuiez59WCJswp9jKe8qgSZJo0adf\n\t5ubsA+oLDxHN9CLfJYBywOAySB1/Y0BzSETkmTD3lGTMJbc=","X-Google-Smtp-Source":"ABdhPJyy3heFdUBxJIcE/duc7BW44S9q50keyqrQlsNB7x5HXbj3HddkMOEXymvuL0BlOCmaC8dxAoE1RChCmrFD3rw=","X-Received":"by 2002:a17:906:2559:: with SMTP id\n\tj25mr58198898ejb.42.1621222797708; \n\tSun, 16 May 2021 20:39:57 -0700 (PDT)","MIME-Version":"1.0","References":"<20210515183826.21003-1-laurent.pinchart@ideasonboard.com>\n\t<20210515183826.21003-3-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20210515183826.21003-3-laurent.pinchart@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Mon, 17 May 2021 12:39:47 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"000000000000f5a25a05c27e5815\"","Subject":"Re: [libcamera-devel] [PATCH 2/4] android: camera_metadata:\n\tConstify argument to addEntry() and updateEntry()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16986,"web_url":"https://patchwork.libcamera.org/comment/16986/","msgid":"<9909c36f-18c9-ced8-2eca-58ded30fb401@ideasonboard.com>","date":"2021-05-17T09:35:40","subject":"Re: [libcamera-devel] [PATCH 2/4] android: camera_metadata:\n\tConstify argument to addEntry() and updateEntry()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 15/05/2021 19:38, Laurent Pinchart wrote:\n> The addEntry() and updateEntry() overrides that take a reference to a\n> container don't need to modify the container. Make it const.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/android/camera_metadata.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> index 56df6f1c9008..f95c34581fe4 100644\n> --- a/src/android/camera_metadata.h\n> +++ b/src/android/camera_metadata.h\n> @@ -42,7 +42,7 @@ public:\n> \n> \ttemplate \t\t typename T = typename S::value_type>\n> -\tbool addEntry(uint32_t tag, S &data)\n> +\tbool addEntry(uint32_t tag, const S &data)\n> \t{\n> \t\treturn addEntry(tag, data.data(), data.size(), sizeof(T));\n> \t}\n> @@ -67,7 +67,7 @@ public:\n> \n> \ttemplate \t\t typename T = typename S::value_type>\n> -\tbool updateEntry(uint32_t tag, S &data)\n> +\tbool updateEntry(uint32_t tag, const S &data)\n> \t{\n> \t\treturn updateEntry(tag, data.data(), data.size());\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6874C31FC\n\tfor ;\n\tMon, 17 May 2021 09:35:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D9E56891F;\n\tMon, 17 May 2021 11:35:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F10F602B2\n\tfor ;\n\tMon, 17 May 2021 11:35:43 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1D95B88F;\n\tMon, 17 May 2021 11:35:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ncuDCUcS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621244143;\n\tbh=QzvCfGDrV6nPZUJjf9AXH7W1NsMLCO1h/j8A1ykIjlU=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=ncuDCUcS91o2wKow8qsZ4xwJtdMoHzvZ2LMfwM0sSx2MBrU0YJH42CFH3mA0vpqBS\n\tCq4Z9U/GeeH8achCj6nKj5rA0pY+8cQiJzwMxRivCeitSleWb557XG/pHp1jUK5p+1\n\ty/uc29H36YnvaBc6slEje/N/AB2gx+DhZiKrFFeQ=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210515183826.21003-1-laurent.pinchart@ideasonboard.com>\n\t<20210515183826.21003-3-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Organization":"Ideas on Board","Message-ID":"<9909c36f-18c9-ced8-2eca-58ded30fb401@ideasonboard.com>","Date":"Mon, 17 May 2021 10:35:40 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"<20210515183826.21003-3-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 2/4] android: camera_metadata:\n\tConstify argument to addEntry() and updateEntry()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]