[{"id":16965,"web_url":"https://patchwork.libcamera.org/comment/16965/","msgid":"","date":"2021-05-17T03:38:24","subject":"Re: [libcamera-devel] [PATCH 1/4] android: camera_metadata: Rename\n\tsizeofT argument to elementSize","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent,\n\nOn Sun, May 16, 2021 at 3:38 AM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> The sizeofT argument to CameraMetadata::addEntry() stores the size of\n> one element. Its name is a bit cryptic as the function isn't a template\n> function with a typename T. Rename it to elementSize.\n>\n> Signed-off-by: Laurent Pinchart \n>\n\nReviewed-by: Hirokazu Honda \n\n\n> ---\n> src/android/camera_metadata.cpp | 4 ++--\n> src/android/camera_metadata.h | 3 ++-\n> 2 files changed, 4 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/android/camera_metadata.cpp\n> b/src/android/camera_metadata.cpp\n> index bf8d2781cc21..59366c50cc16 100644\n> --- a/src/android/camera_metadata.cpp\n> +++ b/src/android/camera_metadata.cpp\n> @@ -110,12 +110,12 @@ bool CameraMetadata::resize(size_t count, size_t\n> size)\n> }\n>\n> bool CameraMetadata::addEntry(uint32_t tag, const void *data, size_t\n> count,\n> - size_t sizeofT)\n> + size_t elementSize)\n> {\n> if (!valid_)\n> return false;\n>\n> - if (!resize(1, count * sizeofT)) {\n> + if (!resize(1, count * elementSize)) {\n> LOG(CameraMetadata, Error) << \"Failed to resize\";\n> valid_ = false;\n> return false;\n> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> index 07afd4b25ae7..56df6f1c9008 100644\n> --- a/src/android/camera_metadata.h\n> +++ b/src/android/camera_metadata.h\n> @@ -72,7 +72,8 @@ public:\n> return updateEntry(tag, data.data(), data.size());\n> }\n>\n> - bool addEntry(uint32_t tag, const void *data, size_t count, size_t\n> sizeofT);\n> + bool addEntry(uint32_t tag, const void *data, size_t count,\n> + size_t elementSize);\n> bool updateEntry(uint32_t tag, const void *data, size_t count);\n>\n> camera_metadata_t *get();\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 532ACC31FB\n\tfor ;\n\tMon, 17 May 2021 03:38:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BEEC96891E;\n\tMon, 17 May 2021 05:38:36 +0200 (CEST)","from mail-ej1-x629.google.com (mail-ej1-x629.google.com\n\t[IPv6:2a00:1450:4864:20::629])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 573CF602B1\n\tfor ;\n\tMon, 17 May 2021 05:38:35 +0200 (CEST)","by mail-ej1-x629.google.com with SMTP id lg14so6962243ejb.9\n\tfor ;\n\tSun, 16 May 2021 20:38:35 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"mMzYcNZG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=ZgrsJPCnf5jft7ntEMB6b/8w8sZflOCwoPYimZCuPyg=;\n\tb=mMzYcNZGdIMjTcGXw2qFGRMFKE4PdakXutJt9W0WriBf892j1ZxDwXywLvphzaj9wt\n\tTtbryrdCKn+bRfJckMGG0ykpJP7/QfAX2p1+GCa7j1e2EQj0toLY17Zyu44EvHNpxpS3\n\tbOmx+b9jZW7XXWOK8XZTS1wDs+IVJnsa/AGYg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=ZgrsJPCnf5jft7ntEMB6b/8w8sZflOCwoPYimZCuPyg=;\n\tb=mQxkiHooauXpLUPIeVGkqJiILI3ipkv1wxff1FGrt2bvO2Je3tD9oYaCa0Ot+U4lSE\n\tM1aJieJE0IWM6rZC+8eOG/4VZyUZ02wJtcn9Lroih3YDz9TCyy4sTw8ajVg6awChD6Ch\n\tBPrhdTt/1PIIv+T6i7CHx+BwLiWklOCSTEt7qzlpYWZ7oV6JmxbBQiM+mT1fkgaUpHgv\n\trV50qUtmp6Hl5zG4ZGDaAgyKOjmUPmGEXX1kA2GPFz5f0RIYN6va8U+XiXwJwwvOQeyQ\n\tvNKanu06mPIFBC4r4jX2BJW5exsY8zCHmIV7MnOtZFBid0HGvhKfD16ln62RC6ibXZBG\n\tBj5A==","X-Gm-Message-State":"AOAM5331zzGq+BCu2GmO3dhI+HcS6eO22o2t04vO8J7CdF7d4cb2HnWo\n\twD6RkRm5eeUvQXuHZDVO2YZwre15yvAcrCBs8Tl9+Q==","X-Google-Smtp-Source":"ABdhPJyypzB7zk5sc9IGcIV6dEgoyzRJs0xyCCNQscw1/VeJxL4Xx8a5qeqyghkG5tyk/WNCQhUTZ9U7BOBUZJmNxmw=","X-Received":"by 2002:a17:907:209b:: with SMTP id\n\tpv27mr60332599ejb.475.1621222714976; \n\tSun, 16 May 2021 20:38:34 -0700 (PDT)","MIME-Version":"1.0","References":"<20210515183826.21003-1-laurent.pinchart@ideasonboard.com>\n\t<20210515183826.21003-2-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20210515183826.21003-2-laurent.pinchart@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Mon, 17 May 2021 12:38:24 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"000000000000073b9f05c27e5498\"","Subject":"Re: [libcamera-devel] [PATCH 1/4] android: camera_metadata: Rename\n\tsizeofT argument to elementSize","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16985,"web_url":"https://patchwork.libcamera.org/comment/16985/","msgid":"","date":"2021-05-17T09:34:53","subject":"Re: [libcamera-devel] [PATCH 1/4] android: camera_metadata: Rename\n\tsizeofT argument to elementSize","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 15/05/2021 19:38, Laurent Pinchart wrote:\n> The sizeofT argument to CameraMetadata::addEntry() stores the size of\n> one element. Its name is a bit cryptic as the function isn't a template\n> function with a typename T. Rename it to elementSize.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/android/camera_metadata.cpp | 4 ++--\n> src/android/camera_metadata.h | 3 ++-\n> 2 files changed, 4 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\n> index bf8d2781cc21..59366c50cc16 100644\n> --- a/src/android/camera_metadata.cpp\n> +++ b/src/android/camera_metadata.cpp\n> @@ -110,12 +110,12 @@ bool CameraMetadata::resize(size_t count, size_t size)\n> }\n> \n> bool CameraMetadata::addEntry(uint32_t tag, const void *data, size_t count,\n> -\t\t\t size_t sizeofT)\n> +\t\t\t size_t elementSize)\n> {\n> \tif (!valid_)\n> \t\treturn false;\n> \n> -\tif (!resize(1, count * sizeofT)) {\n> +\tif (!resize(1, count * elementSize)) {\n> \t\tLOG(CameraMetadata, Error) << \"Failed to resize\";\n> \t\tvalid_ = false;\n> \t\treturn false;\n> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> index 07afd4b25ae7..56df6f1c9008 100644\n> --- a/src/android/camera_metadata.h\n> +++ b/src/android/camera_metadata.h\n> @@ -72,7 +72,8 @@ public:\n> \t\treturn updateEntry(tag, data.data(), data.size());\n> \t}\n> \n> -\tbool addEntry(uint32_t tag, const void *data, size_t count, size_t sizeofT);\n> +\tbool addEntry(uint32_t tag, const void *data, size_t count,\n> +\t\t size_t elementSize);\n> \tbool updateEntry(uint32_t tag, const void *data, size_t count);\n> \n> \tcamera_metadata_t *get();\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36232C31FB\n\tfor ;\n\tMon, 17 May 2021 09:34:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A649B68921;\n\tMon, 17 May 2021 11:34:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33332602B2\n\tfor ;\n\tMon, 17 May 2021 11:34:56 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B4E5D88F;\n\tMon, 17 May 2021 11:34:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Dj1noHQV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621244095;\n\tbh=895bCItRQMG5PtcGoeOVTiRDem+1rCCBZP49tJyuAZM=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Dj1noHQVvdZQ4HyYv0z5Aqf49aPI3hiiWFPRbgQvSz+7zsPPXO5Rg0gvQ8+c8vwKa\n\tja1/W6c6xtj72i1czRWzGLpWaCmx/d4OqJC/TaeyC/ItbWMSil2tQiz2bbSG+85843\n\ta0OOOtTytK+r4lAy1CamF5IuviBCWQzjd/AYxUtM=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210515183826.21003-1-laurent.pinchart@ideasonboard.com>\n\t<20210515183826.21003-2-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 17 May 2021 10:34:53 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"<20210515183826.21003-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 1/4] android: camera_metadata: Rename\n\tsizeofT argument to elementSize","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]