[{"id":1625,"web_url":"https://patchwork.libcamera.org/comment/1625/","msgid":"<20190518204830.GJ25081@bigcity.dyn.berto.se>","date":"2019-05-18T20:48:31","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: rkisp1: Fix\n\tusage of uninitialised variable","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-05-18 23:44:26 +0300, Laurent Pinchart wrote:\n> Commit 1a813a5c3ab7 introduced usage of an uninitialised variable. Fix it.\n> \n> Fixes: 1a813a5c3ab7 (\"libcamera: media_device: Handle media device fd in acquire() and release()\")\n> Signed-off-by: Laurent Pinchart \n\nSorry this was my mistake, wonder why my compiler did not catch this..\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +----\n> 1 file changed, 1 insertion(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index b395405c9ddb..96553bf2d9ef 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -159,12 +159,9 @@ int PipelineHandlerRkISP1::configureStreams(Camera *camera,\n> \n> \t\tret = link->setEnabled(enable);\n> \t\tif (ret < 0)\n> -\t\t\tbreak;\n> +\t\t\treturn ret;\n> \t}\n> \n> -\tif (ret < 0)\n> -\t\treturn ret;\n> -\n> \t/*\n> \t * Configure the format on the sensor output and propagate it through\n> \t * the pipeline.\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DBCB60BFD\n\tfor ;\n\tSat, 18 May 2019 22:48:33 +0200 (CEST)","by mail-lf1-x143.google.com with SMTP id c17so7664983lfi.2\n\tfor ;\n\tSat, 18 May 2019 13:48:33 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tr69sm2789379lfr.32.2019.05.18.13.48.31\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSat, 18 May 2019 13:48:31 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=xkZ/Pv3eDyUkD7CrM1TDiXlhCpLVGd5TzwODdWZ/vYQ=;\n\tb=Z8ypUY7EjSi940ghB21yQIxyhGs8ZEaiIsWHzD7rSa2TPz+adnXGw5qu868f4yFxlA\n\t0WJ8gpSAcdb2uUfyiiJonsS+/k1zXcT1tilXAtRuEx3r80+vnSMKtYh/6UATAZohXYIF\n\tXhe57ORnYB8T+61UasEFmJbaHy77xm/5EM6kkYzbTWIATpCkWzgHUxtFem24YT/y7MLG\n\toqUMOGWnJc0mXzmPyXCcEBEVJuouZ2z/oCOOmMuLj1SJvQ3X75VXzLx1y9dfm8Ii0YEM\n\teF7qN52eVATRD/BOXv0J8qXIFIqpXQoI7GT1se9LcinNDJMJtKVQ+jPSefQZkwHojjd3\n\t11MQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=xkZ/Pv3eDyUkD7CrM1TDiXlhCpLVGd5TzwODdWZ/vYQ=;\n\tb=k/jX/e55w5SYF/Bb4h3CsVcxQj34M76N130QjgrJLuaDKzI0xtGimAwWc37og/5/7J\n\tz59FqxeFh5tjm6zxv3sq5n5ciegbIpDkjfeZWsIkeyJ71voWc0PFB1sOrLnhvJOH/yBw\n\tYkJuJgcM10IQzi9HCrxW9AjoILqpUENse6wJLry5lfiYjbBuzO4N+vabqYCboOf9FbZ6\n\tCTO8X1/d+32D3Kw9pXa9KFBiXyfe3wgGlC/Rw9Fyk5lHnFCHeNziuvhAb1Vj44I4pkrB\n\tjEH0PWhdOHG9Zh7WpydNYWJCuvyYorS8Lz0ARrLZlViX8591yBbiPkzcOIwjsrvosapA\n\tSM/A==","X-Gm-Message-State":"APjAAAUMEh3Pg9oYFP8Q0wq9zRWEvSOCZo4UpSHZTzt/61CYu2XA3AYC\n\tWIPUhcpHy1IgMHBSgQQxcjufyw==","X-Google-Smtp-Source":"APXvYqwGCFPwcqb79tcqMtmafDh88F3Yq5t/3QexMnLGnJ1tbd8OjRr+L3EehZEAvQW6kOoWxPkSpg==","X-Received":"by 2002:a19:9c8f:: with SMTP id\n\tf137mr32039894lfe.94.1558212512524; \n\tSat, 18 May 2019 13:48:32 -0700 (PDT)","Date":"Sat, 18 May 2019 22:48:31 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190518204830.GJ25081@bigcity.dyn.berto.se>","References":"<20190518204426.15119-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190518204426.15119-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: rkisp1: Fix\n\tusage of uninitialised variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 18 May 2019 20:48:33 -0000"}}]