{"id":1230,"url":"https://patchwork.libcamera.org/api/patches/1230/?format=json","web_url":"https://patchwork.libcamera.org/patch/1230/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190518204426.15119-1-laurent.pinchart@ideasonboard.com>","date":"2019-05-18T20:44:26","name":"[libcamera-devel] libcamera: pipeline: rkisp1: Fix usage of uninitialised variable","commit_ref":"06387039d6f59f8cb1829edfc09d2d9c8b33d62c","pull_url":null,"state":"accepted","archived":false,"hash":"d2b5d85f23d751e3aeabe6ec5ddb0dd1ce0ab4ce","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1230/mbox/","series":[{"id":308,"url":"https://patchwork.libcamera.org/api/series/308/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=308","date":"2019-05-18T20:44:26","name":"[libcamera-devel] libcamera: pipeline: rkisp1: Fix usage of uninitialised variable","version":1,"mbox":"https://patchwork.libcamera.org/series/308/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1230/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1230/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F54160BFD\n\tfor ;\n\tSat, 18 May 2019 22:44:47 +0200 (CEST)","from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 821ADD5\n\tfor ;\n\tSat, 18 May 2019 22:44:46 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1558212286;\n\tbh=OV2eFvO3uJNTlvvBoDLXTL0evwNUv/EZAo3YrOeyysY=;\n\th=From:To:Subject:Date:From;\n\tb=eAQLRJ+H+mu61o3xhEWerzOSevdgvVZaHh4fnwWcS1FPC2N1rvtDUtT4ZHEgdboQh\n\tD1amg+dapp1Xf3TXqtUy4p42VRo5MX2geQSE/8IU+ZCGSakBBAvuCb1B6zxlz4Ogyq\n\tJq3w6JFwoe1/y+cPrSHZL+KxYReV4tWVbfPsTNe8=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 18 May 2019 23:44:26 +0300","Message-Id":"<20190518204426.15119-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: pipeline: rkisp1: Fix usage of\n\tuninitialised variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 18 May 2019 20:44:47 -0000"},"content":"Commit 1a813a5c3ab7 introduced usage of an uninitialised variable. Fix it.\n\nFixes: 1a813a5c3ab7 (\"libcamera: media_device: Handle media device fd in acquire() and release()\")\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex b395405c9ddb..96553bf2d9ef 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -159,12 +159,9 @@ int PipelineHandlerRkISP1::configureStreams(Camera *camera,\n \n \t\tret = link->setEnabled(enable);\n \t\tif (ret < 0)\n-\t\t\tbreak;\n+\t\t\treturn ret;\n \t}\n \n-\tif (ret < 0)\n-\t\treturn ret;\n-\n \t/*\n \t * Configure the format on the sensor output and propagate it through\n \t * the pipeline.\n","prefixes":["libcamera-devel"]}