[{"id":1624,"web_url":"https://patchwork.libcamera.org/comment/1624/","msgid":"<20190518182322.GG4995@pendragon.ideasonboard.com>","date":"2019-05-18T18:23:22","subject":"Re: [libcamera-devel] [PATCH/RFC 12/12] cam: Validate camera\n\tconfiguration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Sat, May 18, 2019 at 02:06:21AM +0300, Laurent Pinchart wrote:\n> From: Niklas Söderlund \n> \n> Use CameraConfiguration::validate() to validate and possibly update the\n> stream formats before configuring a camera.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> src/cam/main.cpp | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index a962f94c8f59..91785b7fea31 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -140,6 +140,18 @@ static CameraConfiguration *prepareCameraConfig()\n> \t\t\tcfg.pixelFormat = conf[\"pixelformat\"];\n> \t}\n> \n> +\tswitch (config->validate()) {\n> +\tcase CameraConfiguration::Valid:\n> +\t\tbreak;\n> +\tcase CameraConfiguration::Adjusted:\n> +\t\tstd::cout << \"Adjusted request format\" << std::endl;\n\ns/format/configuration/ as we support multiple streams ? And should we\nprint what the configuration has been adjusted to ?\n\n> +\t\tbreak;\n> +\tcase CameraConfiguration::Invalid:\n> +\t\tdelete config;\n> +\t\tconfig = nullptr;\n> +\t\tbreak;\n> +\t}\n> +\n> \treturn config;\n> }\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B31E60C1D\n\tfor ;\n\tSat, 18 May 2019 20:23:39 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 96869D5\n\tfor ;\n\tSat, 18 May 2019 20:23:38 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1558203818;\n\tbh=0Wne3wAfgZsnFtZISY1FWTlAgHsOK8qqYfLCuXPM5RA=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=fYq9mYHKUjC/833mScuTyMRJVJk2pFJT7NKlKpUuWjOzjhCSkFko7bQz0ArSU1JZW\n\tPNLz3azanRZ6E5QJLQDGkGqN4QdyjfRPSdhu60Q82OiAaO1jW5skaSWprURkNGJsyo\n\tqzygzr62m0vY/Dqmm9OnIKMUXhTPM9wm1BotCZEE=","Date":"Sat, 18 May 2019 21:23:22 +0300","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190518182322.GG4995@pendragon.ideasonboard.com>","References":"<20190517230621.24668-1-laurent.pinchart@ideasonboard.com>\n\t<20190517230621.24668-13-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190517230621.24668-13-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH/RFC 12/12] cam: Validate camera\n\tconfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 18 May 2019 18:23:39 -0000"}}]