[{"id":16972,"web_url":"https://patchwork.libcamera.org/comment/16972/","msgid":"","date":"2021-05-17T03:59:39","subject":"Re: [libcamera-devel] [PATCH v3 6/8] libcamera: ipu3: imgu: Fix BSD\n\theight size comparison","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Jacopo, thank you for the patch.\n\nOn Fri, May 14, 2021 at 12:20 AM Jacopo Mondi wrote:\n\n> Fix a size comparison when iterating on the BDS sizes to accepts\n> values that are equal to the minimum accepted height.\n>\n> Signed-off-by: Jacopo Mondi \n> Tested-by: Jean-Michel Hautbois \n> Reviewed-by: Jean-Michel Hautbois \n> Reviewed-by: Laurent Pinchart \n> Reviewed-by: Niklas Söderlund \n>\n\nReviewed-by: Hirokazu Honda \n\n>\n\n> ---\n> src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp\n> b/src/libcamera/pipeline/ipu3/imgu.cpp\n> index 5912ae4dfc87..df5a1b5b0826 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> @@ -177,7 +177,7 @@ void calculateBDSHeight(ImgUDevice::Pipe *pipe, const\n> Size &iif, const Size &gdc\n> }\n> } else {\n> ifHeight = utils::alignUp(iif.height, IF_ALIGN_H);\n> - while (ifHeight > minIFHeight && ifHeight / bdsSF >=\n> minBDSHeight) {\n> + while (ifHeight >= minIFHeight && ifHeight / bdsSF >=\n> minBDSHeight) {\n>\n> bdsHeight = ifHeight / bdsSF;\n> if (std::fmod(ifHeight, 1.0) == 0 &&\n> std::fmod(bdsHeight, 1.0) == 0) {\n> --\n> 2.31.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E5530C31FB\n\tfor ;\n\tMon, 17 May 2021 03:59:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A914A6891E;\n\tMon, 17 May 2021 05:59:52 +0200 (CEST)","from mail-ej1-x635.google.com (mail-ej1-x635.google.com\n\t[IPv6:2a00:1450:4864:20::635])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB1CF602B1\n\tfor ;\n\tMon, 17 May 2021 05:59:50 +0200 (CEST)","by mail-ej1-x635.google.com with SMTP id k14so3528623eji.2\n\tfor ;\n\tSun, 16 May 2021 20:59:50 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"UnW268TM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=aZ58hcZUrkU+KB+UBdCvIS/Hyi02uiZCm5D57J0CeJQ=;\n\tb=UnW268TMdJhAxRrFaDEuCVdzHA4eO7AcvEkrQqRaV31FrQmWW2Yt+AmzFxE3N+nHhk\n\ttpZIVzo4MOv7kiQ6Ggx34NB551+cPCMwFQkJ2ycEsRDl7ly7R8/Slh0D8i+SR3cow4oo\n\t000IgVGW2g6dDg4P8ItDLtc+mOaeC4bMOtz2Q=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=aZ58hcZUrkU+KB+UBdCvIS/Hyi02uiZCm5D57J0CeJQ=;\n\tb=RZQWbKAEGti1n5sHxLh0u1LrbH2bxPsE78u/tHABEcYouihllFPx1dWLDBeXBdquUP\n\tCMNr9VckJNFq6oHC/rBmfBHMxQby2SImyQO1Liw0/hlqG0/hhCkx8+E/5+mvkHniKiWg\n\tHp955xXt5tpDdxcatFQ5tav1CSMTodVRfZXkazhIcEADE71PLUQBwMC1vmkOrfZu2KqT\n\tc3Z11vx4X6MvKOivJwD8wQnzxc6oWFCAGxqFkyAlAzW5S7ANtife/l4aA/EOwQJAEmgr\n\tSa1SjgNTk4oCxKW/5gJokEeLsFlxZmaEwjhfKgLwNxlb+GPAVmvlBvGFuJu5YKl+K2eI\n\tt15g==","X-Gm-Message-State":"AOAM531Vj2L2u68CT65YuKhgbc8hijr0ouwLVQQ0ae/22sVkj9sOhpvb\n\tQJOiY3qjeBhMxv5Hrh0kS/Ho454mYQK7dgoQ7e3J60UdPY+VCQ==","X-Google-Smtp-Source":"ABdhPJwUppEMaCjwjhRJg3ZXYPstBel8VDxwXcoW38x0IcNI/xs4jsOU3Qtsx69ICi0plhLLkYCMNb0TZHI6yUdp2NY=","X-Received":"by 2002:a17:907:209b:: with SMTP id\n\tpv27mr60401576ejb.475.1621223990414; \n\tSun, 16 May 2021 20:59:50 -0700 (PDT)","MIME-Version":"1.0","References":"<20210513152116.17666-1-jacopo@jmondi.org>\n\t<20210513152116.17666-7-jacopo@jmondi.org>","In-Reply-To":"<20210513152116.17666-7-jacopo@jmondi.org>","From":"Hirokazu Honda ","Date":"Mon, 17 May 2021 12:59:39 +0900","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"multipart/alternative; boundary=\"0000000000000cd7f405c27ea0c7\"","Subject":"Re: [libcamera-devel] [PATCH v3 6/8] libcamera: ipu3: imgu: Fix BSD\n\theight size comparison","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]